Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp713460lqb; Wed, 29 May 2024 08:29:16 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV59mF0r+i60b4qdmk59wuH1w+y9l54eRN94VR3QOidfzqzwi3eB1l6Zfa3bj+zLOn3EYnFwW6dlmoo8cEAi66IlYzlTSBG2fF5ZpCB/g== X-Google-Smtp-Source: AGHT+IF4SELh16xCbUJO3YLtU3uXVNUxShI7FTwZi99mbcO+MHnR5MXcFkzVSe2UtjJtZ8jg7KDj X-Received: by 2002:a17:902:e5c7:b0:1f2:f8b7:60cf with SMTP id d9443c01a7336-1f4eacc10dcmr36638305ad.27.1716996556559; Wed, 29 May 2024 08:29:16 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716996556; cv=pass; d=google.com; s=arc-20160816; b=D1CGzcazZRaHBtvL3uhCTX0DwqXYobT2Fr/JxYbx96gnxSkAA0JDVKcc7XqKkKRYzA 7CHdCkNQRllhJPxCoLH7Ea+HE6Xs6jgGTC9SNqa8LvFqc9DwWuTltuZRgAD6BSkYagOp iolS4ufaLlkv+AxUuas0t2uVfn279RW8UxG3k32c/5HHHbW7+YTJt7Wkn3ZFi8qTr5aI 7h81WYF6mlhiHPSbo0ceMZOWoJm73LEYiKMjpkBgQddM0NppGc5Z/AEyUIdbH46Jp+7e /r7oaZy+osbCWbN4cqJF8XPebbxygHP0UXsc9w3+BbKwNaZbRnCQNB0r2uChNbr8avXx tVsw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=mFHpztQhwU5HG7lA94/ryMM368oC6ZMtci9dOyduPBc=; fh=i8n+M78iwH9bwT44Zfp4q0x6vkHwuNa6zopLolSE1XM=; b=ORLHWN1NTvdevQFKrNEcy0rChI2mw5UnDIU4c7bzZ4xAEzU+Ipwz+MjQIfVH7+PObf ebqcRVEOwY3COpzr7P5t8Gvd1b6cp8VG+qNn8EFdsEuUzt/HAEEIN/faTo9dQKcoXPIZ gyM66YjBx+7QGyuhbgCTfLotnc3Vvw2igPFRE6J+HsQu5Sa4oILZY+dPzC6PoA73vgRJ JOT64qxBUISr+whGlk4IYFollLHb1/Ksrd7ANMmbpLTvk8QoX6Ovpjn2VsRN3WLKL8a2 AvmpYc4eVCHxLXzJ6vjA3GY7lntI8ptE5Sz3Ap4cX752K/l3qPi7/Uz/gqmEvqWop23W 68hg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=d560bNoH; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-194363-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-194363-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d9443c01a7336-1f44c96faa4si102461915ad.203.2024.05.29.08.29.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 08:29:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-194363-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=d560bNoH; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-194363-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-194363-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E59A8289EED for ; Wed, 29 May 2024 15:29:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AFD5118132A; Wed, 29 May 2024 15:29:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="d560bNoH" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 361D91802A3 for ; Wed, 29 May 2024 15:29:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716996545; cv=none; b=le9BUejh5PBUj3eoElOX/b/Ql/XzX7jlOSD7BK1ujVx5Ywugr5EPKZ29X5rtk/ihvg1mLduwnN1A6A/fQp+d9HA72adVkGYnt3ucthlY8/Euu5VV/ECUHY7/B8POZNMAsdFQkvymviagOdND0k5dRo2ldish+RpvgkcW3vMN7wM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716996545; c=relaxed/simple; bh=8TSpQpuVN6z+ZuZk68PMhyHU89nHlEi7bQ43I1w48bQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=k0OZADA1ATkkLKXZOVe+DIv/A+a5A0jJvBU8BgULMlMetlB0mJDhbrXeCh/92/Z/juTDvMjflqrAhDjDnplWIdAEe9MCQwKSBZSUPQmhR13K+C8t5cz2oconOhggYZOyZfd8zudyLOx17YJKgi6gb9cq68QJDFFS6BfkrCrgQQk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=d560bNoH; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1716996542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mFHpztQhwU5HG7lA94/ryMM368oC6ZMtci9dOyduPBc=; b=d560bNoHhvyGhyRkAMbL62elWnPbGw5OTgtprwHhX23FE1PFCqo1rmhKPGilo/4fIJtGTb 5RCNjdqhODjcxXIUopT5g/ubc5aPhUIECLxzi66HQPYQ5eoAIZaeRTR8FVFuCcDyL1q7sn wOYS1ipyyytri7E7MQeyYao2kVinP8k= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-333-BSvXLLU2PeWMZw7EI74hIQ-1; Wed, 29 May 2024 11:29:00 -0400 X-MC-Unique: BSvXLLU2PeWMZw7EI74hIQ-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a62c4ffecefso112696566b.2 for ; Wed, 29 May 2024 08:29:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716996539; x=1717601339; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mFHpztQhwU5HG7lA94/ryMM368oC6ZMtci9dOyduPBc=; b=ajQwsXZI2c9nTrBwnpWfxNLJB5vZj/Q//MR3Mw4tw7tzrZHxwxls0cjbDqjGCm2NbY pk3jBPg2X2oVM4FcKiQzuH/KZEQfM2HItT2a2vyRE596slOH6+rQPc0FrBDr1kO5G7wU 3JbPw8j4czgx2pkUcMWRnmWQ5MN2Cl+LKHETkgMwAsq/JyKwdNiyznIbymNnL9QEHqU7 kvSVx1DP3uOHZn3f7gr8UbjafP8q6tK8nLWC6LOhiXcmz+v+sy/xqP4yqBlZlqnZWAo9 YHemdQxVn0jgdreqsd9uq7vch7RlmfpWEXQcEJ5npf7Ou6Z1Y61oi8GwhKHfsUA+8I9i fNYw== X-Forwarded-Encrypted: i=1; AJvYcCWft7u84e88gkxjoMLvTVfI0XAiz3YiobTPmO4gny+KHm24CcwRM2Y7IwkTEp1eZkzTi/0UzYHw5BCuegQ7FgOOwBHmAvo8GJi8c+5C X-Gm-Message-State: AOJu0YyzdmO4XBvkhtUbL0Ei5KBl0SNAR1Z6m5pIIgiZmSpDjyNkwXwz B48aosC8vQ46QCzVcNrsqBclcsZDPfuLm8DfUp1I1y0Wc8PJ79HhWR8p22EHGoqZhvbDArEvUF6 hdMLmRFTrb0ITotoH+J9HqJqn2bG+HCyOHLqsxhoJRvGyavSL+3mnxeAjNzr0Gw== X-Received: by 2002:a17:906:6d95:b0:a59:bbd6:bb39 with SMTP id a640c23a62f3a-a6264f0ebfamr1092763166b.55.1716996539682; Wed, 29 May 2024 08:28:59 -0700 (PDT) X-Received: by 2002:a17:906:6d95:b0:a59:bbd6:bb39 with SMTP id a640c23a62f3a-a6264f0ebfamr1092760466b.55.1716996539217; Wed, 29 May 2024 08:28:59 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a626c8182edsm734297466b.9.2024.05.29.08.28.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 May 2024 08:28:58 -0700 (PDT) Message-ID: Date: Wed, 29 May 2024 17:28:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/2] asus wmi and hid: use HID LED for brightness To: "Luke D. Jones" , Jiri Kosina , Benjamin Tissoires Cc: ilpo.jarvinen@linux.intel.com, corentin.chary@gmail.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org References: <20240529012827.146005-1-luke@ljones.dev> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20240529012827.146005-1-luke@ljones.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi all, On 5/29/24 3:28 AM, Luke D. Jones wrote: > Changelog: > - v1 > - Split the patch in two > - Move function body to asus-wmi and export > - Use array of names and for loops > > History: > - https://lore.kernel.org/linux-input/20240528013959.14661-1-luke@ljones.dev/T/#u > > Luke D. Jones (2): > hid-asus: use hid for brightness control on keyboard > hid-asus: change the report_id used for HID LED control > > drivers/hid/hid-asus.c | 32 +++++++++++++++++++- > drivers/platform/x86/asus-wmi.c | 35 +++++++++++++++++++++- > include/linux/platform_data/x86/asus-wmi.h | 10 +++++++ > 3 files changed, 75 insertions(+), 2 deletions(-) Jiri, Benjamin since the first patch now also touches pdx86 files we need to coordinate merging this. There also is a long list of patches pending for drivers/platform/x86/asus-wmi.c So I would prefer to take this series (both patches) upstream through the pdx86 tree to avoid conflicts. May we have an ack from one of you for merging this through pdx86/for-next ? Regards, Hans