Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp727495lqb; Wed, 29 May 2024 08:52:07 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVzVD1znA5cLkcy7Hcov9TyZWTcoc2i0sZoUD7xLvP422oEeBgDTefhy+uQkbsq49eA28JeATK0TK/BKvNllaTtecGDON7voHZquG6B8Q== X-Google-Smtp-Source: AGHT+IEm0us1F2Yo7JD/Ra+593uEn5s3NM0qWxbuEjDd7O7lYAMF4Y6LkNUxPB/7puIQiXW49FJI X-Received: by 2002:a17:90a:6fa2:b0:2bd:e874:f169 with SMTP id 98e67ed59e1d1-2bf5e18909dmr14940657a91.29.1716997926999; Wed, 29 May 2024 08:52:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716997926; cv=pass; d=google.com; s=arc-20160816; b=dZ18jMs5Bk0IYWMggDe26RM7VLUySmFnPak6Taf3WcMxGsa2mWrgyneBRflYriGrsr upb+t6bLL0YLou/UyZp4j66ScyhSKBkJ2ApWKjy5lEmRU/415nuqombd2/txAZxTF226 WIYBznJiicB2qCikdGE/WWNgBE5MGBlWdL+dA70WmXF+b3KCh6mE1H9Olw3Ec9SYexmV HyuQ+6q8uDh4axf0vcMqMSW/Ne2C8FVJ29yk+HENCKh90Ap8tFggAoYjEqzcB5uE+8+G t3nvemMMAADnyvC946sOVLbc5L1ExgTGalU5J/VuHtQhXvA8hek+j3oNZJacdbxVApVT r3UQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=AkY36TdEnC/9YyDKMo/neQgq54UDQwPidns+t1wxmY0=; fh=9yIRN0EWxvIl8CbPHP4PcywOJ5JUMXbT4de3rm7mcgA=; b=PdsXV6P2u5gz71YMDtKoxDF9E2Hg7ql3pGIp3lQi4emrCv25RlGZbjJYLONsGNL5oD OQ8WniuiFJP1rvs2IvKG0OoMFZqVAIGBwvIvxfp5B2zbyGxtY8DY4EryK31oEpn7R1Ci RtDLBn+GElDyqBoQ18/aTzFcN7bdgctkbnaspeNohelgsRdd0CcvKQsgeL1tk5pxy5DU FlubCiV6AGiMiYu3CC3k0PmLh/Zd7M405QPz8eOUMWqT0afCiqxEsyteCJeNnJzflEah lfw3ehi5axFzE3nCYC2FnYv1019xGKEQNitxI/K1BYTBEPcwdkugWsbIA4hOEMH4GW8G DhhA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XNsa17zi; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-194368-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-194368-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2bdd9ed2cd3si12253747a91.4.2024.05.29.08.52.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 08:52:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-194368-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XNsa17zi; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-194368-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-194368-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6DD42B2220B for ; Wed, 29 May 2024 15:36:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 264E8181334; Wed, 29 May 2024 15:36:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="XNsa17zi" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FF5D1B947 for ; Wed, 29 May 2024 15:36:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716996975; cv=none; b=d/5R0JdNLNI/my4iRXCA/3OodD2l/q0VKi44SGLN4CZ8KWauH8Bfie9MyIcRSaZPbfiIUPGZGqaCHZbgz6In1JNUSZdi+e1iyCtW3Bsb/Pi62KYDlZ9bcnAZxZDh6d3CQJA7HgAojJPLstlktgSmpStrDlqOuEwGnc43jMQYOHg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716996975; c=relaxed/simple; bh=6JX0bcSygA8SohlvD/rPbKhtNBZVT2R1agnaXyctjDs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GZ9836t9rqMauLa5F7jvv8dkrBAhHnkpBBiWGTAj4izQ5XS8T8nxJNk2PQW5HWn1Yaj8CBnB4fpNyiZQMNp9cD9asXfcA5l9Ralcne0utRDccFfxVQIU4x0thm9Ta0fmqvo4n2gFAzQCRWlwlaP/FymiCAgX3qOtY87qqGVLLlU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=XNsa17zi; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716996973; x=1748532973; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=6JX0bcSygA8SohlvD/rPbKhtNBZVT2R1agnaXyctjDs=; b=XNsa17zi7lgd4niS4btjLHGfsx9FBBZLuGOIkEXPeSgzeAKESSUanQfk r7mXXGqfN/EyTGNrEK7oiW74rdnKdEE1qooZqogOLD6IQ5shXowqs8UJf eOucBvRJiTALabKoOBkV2e2O/MXK0JLuHbjfN2PHJbabKKtgYNv8/CJBC e//nx9DzpSG3o/Maf64DV4MVgkEDfBwXy8VBDPs+g1Ct5xMZNhN+atmRM own2qkPjcJyuGlTdGvkIZec6mgkKII/wrnBEov6r+3y/AB3htmoTYP05D 5Dz8Nw0Oln93yvPJFT9fBEirj+mGRtcxCwtKwRnhiU1mpK9tACsopcb7f Q==; X-CSE-ConnectionGUID: iS7OTR+pQhSoqfyUwkOJsg== X-CSE-MsgGUID: ifKWnFCmSDiMo6f+tUrXCg== X-IronPort-AV: E=McAfee;i="6600,9927,11087"; a="35930097" X-IronPort-AV: E=Sophos;i="6.08,198,1712646000"; d="scan'208";a="35930097" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2024 08:36:12 -0700 X-CSE-ConnectionGUID: TVMu6kHxQJWlOH2On8comw== X-CSE-MsgGUID: rgOdKNTaR9+eMmMJij8tkw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,198,1712646000"; d="scan'208";a="35536778" Received: from kinlongk-mobl1.amr.corp.intel.com (HELO [10.125.111.96]) ([10.125.111.96]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2024 08:36:12 -0700 Message-ID: Date: Wed, 29 May 2024 08:36:11 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/NUMA: don't pass MAX_NUMNODES to memblock_set_node() To: Jan Beulich , lkml Cc: Dave Hansen , Andrew Lutomirski , Peter Zijlstra References: From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/29/24 00:42, Jan Beulich wrote: > On an (old) x86 system with SRAT just covering space above 4Gb: > > ACPI: SRAT: Node 0 PXM 0 [mem 0x100000000-0xfffffffff] hotplug OK, so you've got a system with buggy NUMA information. It _used_ to "refuse" the NUMA configuration. Now it tries to move forward and eventually does a NULL deref in memmap_init(). Right? > the commit referenced below leads to this NUMA configuration no longer > being refused by a CONFIG_NUMA=y kernel (previously > > NUMA: nodes only cover 6144MB of your 8185MB e820 RAM. Not used. > No NUMA configuration found > Faking a node at [mem 0x0000000000000000-0x000000027fffffff] > > was seen in the log directly after the message quoted above), because of > memblock_validate_numa_coverage() checking for NUMA_NO_NODE (only). This > in turn led to memblock_alloc_range_nid()'s warning about MAX_NUMNODES > triggering, followed by a NULL deref in memmap_init() when trying to > access node 64's (NODE_SHIFT=6) node data. This is a really oblique way of saying: ... followed by a NULL deref in memmap_init() of NODE_DATA(MAX_NUMNODES). > To compensate said change, avoid passing MAX_NUMNODES to > memblock_set_node(). In turn numa_clear_kernel_node_hotplug()'s check > then also needs adjusting. > > Fixes: ff6c3d81f2e8 ("NUMA: optimize detection of memory with no node id assigned by firmware") I was expecting to see MAX_NUMNODES checks in ff6c3d81f2e8 somewhere. But I don't see any in the numa_meminfo_cover_memory() or __absent_pages_in_range(). In other words, it's not completely clear why ff6c3d81f2e8 introduced this problem.