Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp739499lqb; Wed, 29 May 2024 09:08:52 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUfOPplm5HoGCMvz75iC5hNrU/IJaKBscXi5I9QCsvm0HquXcG2XnYC2o97ZZUGtObWOIP5dP3v9NzjsfPyXs9zXpUZqKF1MicUVDdqQA== X-Google-Smtp-Source: AGHT+IGnAVm9wGO9I1TqSzdzZJ6ANaUGUVErHrYlWtPDwvc+A2E4v6/jYMzdWzlIJg9/DAXQGV89 X-Received: by 2002:a67:eb51:0:b0:47b:dc5d:6364 with SMTP id ada2fe7eead31-48a3851f726mr15200093137.8.1716998931981; Wed, 29 May 2024 09:08:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716998931; cv=pass; d=google.com; s=arc-20160816; b=IO2RGNlJfKG+Obg5KT5FMpoIVhlcl5hG+xLR2bXZPSuastZ3TrprOHwkiqTehtG+xM 6ILJNE3ImZFwmNVlBgBHTcoCr3geIORqE1jf3Xi6BbkMJ1+y6cS1zG0lyayZAjXxAuCF 89WxKJnTlFXSdnkqDVDnhGtKjaECj5erqMxGbG7wO51bfzvTLwNDCebeOwncJk2FeJxg Ad0hxVPPsScdAVPnFtrlViQ92tPkUFHaAOHu/iPb4ktAgPN5FQUcv63Gj5kH8Mu5g5HT VFwudziD4A/D5tGzIvrXKM5EcuFnjqqQuq2WqYoQwmUnc5Aviy3pqljdVloEdO56oEHa ImTQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=zMNPoU2sspFJfheTsjGe6KWO2eLcRkrFTo2drcXpclo=; fh=gOwJIfMdmXlwIUggWV15oPn+SoKDxnPS5TQRYQYwDdM=; b=dTgWKubmU4exTONcCLYLYInOpRiDIUZvgBvycxVpb9TpQdDiTJxP+U7PqEvICRrHVF xOtavtUE4b4G6Epx5kQQnmTfkeRs80XwxGWXKVFetcR2vCwy32LhW2uco1bEWTZ9ybOn cTTiLxTe4LOAShC3euZ6H5QkdoA98sIKUw+2nFYBtm8ehQJiQsgooHMUJeXwJPcCFC7B u95fN1MebcOhg6792aZ7FLw8zpa85Ad03+HvW3jOqlIcCPm0W5BH341RblVo8cGmED50 JkWnIJGjZfJxSEjEZqVnX3EMihTX9o15PkYWRckpVadZ2nMdg0cEi7WDMI8HrzXngqWF 0K6A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=RTqSf+y4; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-194421-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-194421-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id ada2fe7eead31-48a3a3d2032si2940149137.666.2024.05.29.09.08.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 09:08:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-194421-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=RTqSf+y4; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-194421-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-194421-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id DDC791C237AA for ; Wed, 29 May 2024 16:08:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A3AC9184137; Wed, 29 May 2024 16:08:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RTqSf+y4" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C7CF1836D9 for ; Wed, 29 May 2024 16:08:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.15 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716998895; cv=none; b=FJytcZpG30av+f6T2eMTlbNyqO3cMKqC9ZWp4mbVi581XKw2VaLgRElDjJCjjOrOZAEImKgLpkaWGCxps6bFt7rMuWV4im++L8HOpEbcaZDDjzxneBM133eEcRVPTlQ+SCpiomTcUoVce+tmjnyrRNudMNv24Xn/4VNvG+zczUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716998895; c=relaxed/simple; bh=mypyeBy10eC32EWreE3zy7qZftI+o09k5prgCQsZJYs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HYqMEzwD8IakT1lLUYVvGPB7l6Ps1epeqhWfUXfXoseaLiTEbnC5lQeQD16PzvyZOn4NB+2xax/MirM/0E6XR4OYrxULTt15rNHgUQVq7W+uklF6+eqpI0MqiM3bSGmpkgLRwI/eCwBG19tXSVTyoxCVrQQlFLhv+6csKa57n2A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=RTqSf+y4; arc=none smtp.client-ip=192.198.163.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716998894; x=1748534894; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=mypyeBy10eC32EWreE3zy7qZftI+o09k5prgCQsZJYs=; b=RTqSf+y4/zJ2ul+lzH4qjTVZyBEz+wiqsPHysAVnE8N1ifxVBGHiYaoz qlqqP1cYMU51vhkRga42K5vD+ZTT5T1cR8HPbvTUzh77dp4ITPRMh37Ef GrJndhh9umvPjJqSwrPg1A5OGPwQur0dEQ1vqWSz25o2N9Mv8JB0URYmW aeDrApcPsiBFKngqIAYpNx8pi2N21+lC/C6F65fWtVJweSdbePAwCDaWP itYN3nnwmxPdkI/CF40rstn/RcPC3pJ1hqdqDESynyzhzoGnwhYqXf5XL HAC1WINXD8PhmUyMkv5+HTtk+FgF0meQfChopMHlMnOShUU/CN0pQpaAJ A==; X-CSE-ConnectionGUID: 80RAcwueRhOSxfL6sc5FZw== X-CSE-MsgGUID: XyXALf1pTNWvHdDs3vx1cA== X-IronPort-AV: E=McAfee;i="6600,9927,11087"; a="13596578" X-IronPort-AV: E=Sophos;i="6.08,198,1712646000"; d="scan'208";a="13596578" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2024 09:08:13 -0700 X-CSE-ConnectionGUID: sF3J89y7TpCrYnNy9n/42Q== X-CSE-MsgGUID: V4M93vcvT0uTWReqe893GQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,198,1712646000"; d="scan'208";a="40341989" Received: from kinlongk-mobl1.amr.corp.intel.com (HELO [10.125.111.96]) ([10.125.111.96]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2024 09:08:14 -0700 Message-ID: Date: Wed, 29 May 2024 09:08:12 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/NUMA: don't pass MAX_NUMNODES to memblock_set_node() To: Jan Beulich Cc: Dave Hansen , Andrew Lutomirski , Peter Zijlstra , lkml References: <997fcbc7-4e75-4aa2-974c-15d984f02d02@suse.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <997fcbc7-4e75-4aa2-974c-15d984f02d02@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/29/24 09:00, Jan Beulich wrote: >> In other words, it's not completely clear why ff6c3d81f2e8 introduced >> this problem. > It is my understanding that said change, by preventing the NUMA > configuration from being rejected, resulted in different code paths to > be taken. The observed crash was somewhat later than the "No NUMA > configuration found" etc messages. Thus I don't really see a connection > between said change not having had any MAX_NUMNODES check and it having > introduced the (only perceived?) regression. So your system has a bad NUMA config. If it's rejected, then all is merry. Something goes and writes over the nids in all of the memblocks to point to 0 (probably). If it _isn't_ rejected, then it leaves a memblock in place that points to MAX_NUMNODES. That MAX_NUMNODES is a ticking time bomb for later. So this patch doesn't actually revert the rejection behavior change in the Fixes: commit. It just makes the rest of the code more tolerant to _not_ rejecting the NUMA config?