Received-SPF: pass (google.com: domain of linux-kernel+bounces-194424-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Luck, Tony" <tony.luck@intel.com>
To: Arnd Bergmann <arnd@kernel.org>, Borislav Petkov <bp@alien8.de>, "Zhuo,
 Qiuxu" <qiuxu.zhuo@intel.com>
CC: Arnd Bergmann <arnd@arndb.de>, James Morse <james.morse@arm.com>, "Mauro
 Carvalho Chehab" <mchehab@kernel.org>, Robert Richter <rric@kernel.org>,
	Marvin Lin <milkfafa@gmail.com>, Shubhrajyoti Datta
	<shubhrajyoti.datta@amd.com>, Sai Krishna Potthuri
	<sai.krishna.potthuri@amd.com>, "linux-edac@vger.kernel.org"
	<linux-edac@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] EDAC, i10nm: make skx_common.o a separate module
Thread-Topic: [PATCH] EDAC, i10nm: make skx_common.o a separate module
Thread-Index: AQHasa3a1dpIalxTtEymaZnJ+xR+PrGuXnyg
Date: Wed, 29 May 2024 16:14:47 +0000
Message-ID: <SJ1PR11MB60838B76940188104D57E53FFCF22@SJ1PR11MB6083.namprd11.prod.outlook.com>
References: <20240529095132.1929397-1-arnd@kernel.org>
In-Reply-To: <20240529095132.1929397-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?U//VpsgX66oRc9BQuZmAtvTZXYYohp3Ko1clAbOEQZ1hLHq4MU8/rEnakJG8?=
 =?us-ascii?Q?xMiwK0caSLJkmb/EbYQ4MgLMz7gSNO/WFJtGiaYt881R6ymdtwVy1ER/c4AJ?=
 =?us-ascii?Q?TNnT1W4omZSHd7GZHB774kuOM8Dy442OzZ3jfBONeWd3xkefcVNdMc7t1G86?=
 =?us-ascii?Q?qDMpUmJooEk5zvKxkG1g5djKrN6wXW334vgtLC2WUiVP+KxJAegi+isb+nMA?=
 =?us-ascii?Q?3R7zjUbprs5TLdpRQGXLXk+WDaqjLxlMQkyxvbbgrsxQlxjGZ7IEgOROswwo?=
 =?us-ascii?Q?w1s94Ut0M/8r0T3dJBZ297/oY6hkOsaxgQIHWGTzSbgnodRbpu9clJ3afWnF?=
 =?us-ascii?Q?nADLpXyXhVzhCf1Xk+dvpuKXpepiXzumJgeVrMJI1p6QHuoPRGGIvCsbRxRY?=
 =?us-ascii?Q?09cL0D98ctDufUgMB5vPAlBSvJweLr5NXD3OjxeYEAts025bAuj4gJUNEO1X?=
 =?us-ascii?Q?p2k3AhxHE/sHYGmIkMAhwZ6JCVdji75rspT32EXx9V9CCLf5ftRrHw7Vtpue?=
 =?us-ascii?Q?H6Xwp5HnkfZysVcxWh6e68Ov/FyVhh+XUqSeUB6xw3TuJzDS+rrzEKeJT8vR?=
 =?us-ascii?Q?x3TNwoIHKzDOFzBBQxohANWFkEZBQy0gQGkWLMAF9e7YqWxxYooar109OoGm?=
 =?us-ascii?Q?kOrkaQiwWQE5GiyL//KIuVWX9oT7j873Fq39bvxa+xXWBq7OEWghsPldyXq+?=
 =?us-ascii?Q?q5YjlbsUo0n46rOYyRfOQhKbelO6UsEuJ1uR09cZp+ofJ/sgNYXeX5kQE8AM?=
 =?us-ascii?Q?LRcdhYIp432uQC146evFd1Yy8WpQu3PGi9gTu7QA2q5L8dtudYdraWDlNF3x?=
 =?us-ascii?Q?peh8t+5sy90uOHq0PRBHKs1k0TeB8YcT4pEIPgg2gRQcHz5yLo0FHCOCJJZG?=
 =?us-ascii?Q?MFBviKEcVDy5BwqrvQQCTtmiFUGvvW7ztYOVAxqfIff4Lf85w0HqImxEdJw3?=
 =?us-ascii?Q?fNC+kPnUkj6exgmJfgWJxM/5WkFBBvqN2Mt6Hk1b7TOlbZgeZo7o+ETIQ9I0?=
 =?us-ascii?Q?0LnM9KR3Ne4eb1dOqK6gzJEvB0CEjDWWG7kXCZNiHlXxDTvl3h5fBalwZJ7I?=
 =?us-ascii?Q?wEoV5N5r/noO22u7++A55kFU4/e7urSBErjdOniTpVZPM+fk2YZQJZO1pju3?=
 =?us-ascii?Q?zUgJIL07eLMYfCz/jyoMV/CzbDgMm9HViUwegAnUBpuSP/u1KY6qwnnmIjqG?=
 =?us-ascii?Q?S4lrUS1lueELipp/UydFwRJrpKUkSpYOEW/vhiq1E6QX7YzimQ/6RLBjrkyp?=
 =?us-ascii?Q?6yIpM/3nhtenL1cxuMnTXnIkUhs4oi0JUwxEcc8UrcpqlrrSrhFMDihjeV2e?=
 =?us-ascii?Q?WmpkCexs0WJdtINXrC0MvlLIGuZpxC/csUnHkRBys9sPJzAx2BgE2qaFYFOI?=
 =?us-ascii?Q?ogNDmdSvQoqENeEEknzZZzqB07ix7t5DP1aPGPhOYZBuSUZyLsixwKpf6JBG?=
 =?us-ascii?Q?bfZF0bQqKWGHWFuOS6jKpqoYJHi+M5DfJhgRKKMlQU8IEEafQlPrCpitcSBK?=
 =?us-ascii?Q?Jkv7PbqIqrhD43YcMWRzhbdKaT+mcrtfpTyYL56NYqI1Xeh86BgUfvXzrG8k?=
 =?us-ascii?Q?tY8oyq8COMFsnZvthNZx4JlS7xEGeveerUuyE+ER?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6083.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 87f13a56-e969-41f7-f895-08dc7ffa75d0
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2024 16:14:47.4585
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BUN5goPnuWT6DLzDy1Kh5UwooH/4RGxMFBNdAE/Ri3nEpr4K1gx2RD1mEoaNuiZ/SSMlGYKKfVzQViuuD/MvFA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4572
X-OriginatorOrg: intel.com

> Linking an object file into multiple modules causes a warning:
>
> scripts/Makefile.build:236: drivers/edac/Makefile: skx_common.o is added =
to multiple modules: i10nm_edac skx_edac

In this case there is no practical problem from this double link. The two m=
odules created: skx_edac.ko and i10nm_edac.ko
are mutually exclusive. A system may load neither, either, but not both (en=
forced by the x86_match_cpu() check in each
modules init function).

> Make this a separate module instead.

> +EXPORT_SYMBOL_GPL(skx_adxl_get);
> +EXPORT_SYMBOL_GPL(skx_adxl_put);
> +EXPORT_SYMBOL_GPL(skx_set_mem_cfg);
> +EXPORT_SYMBOL_GPL(skx_set_decode);
> +EXPORT_SYMBOL_GPL(skx_get_src_id);
> +EXPORT_SYMBOL_GPL(skx_get_node_id);
> +EXPORT_SYMBOL_GPL(skx_get_all_bus_mappings);
> +EXPORT_SYMBOL_GPL(skx_get_hi_lo);
> +EXPORT_SYMBOL_GPL(skx_get_dimm_info);
> +EXPORT_SYMBOL_GPL(skx_get_nvdimm_info);
> +EXPORT_SYMBOL_GPL(skx_register_mci);
> +EXPORT_SYMBOL_GPL(skx_mce_check_error);
> +EXPORT_SYMBOL_GPL(skx_remove);

With all these new EXPORTs ... perhaps drivers/edac should start
using a local export name space?

    -DDEFAULT_SYMBOL_NAMESPACE=3DEDAC ?


But maybe a better fix might be to somehow tag skx_common.o to tell the
checker script "It's OK. I meant to do that."

-Tony