Received-SPF: pass (google.com: domain of linux-kernel+bounces-194441-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <e70742ea2df432bf57b3f7de542d81ca22b0da2f.1716225483.git.dsimic@manjaro.org>
In-Reply-To: <e70742ea2df432bf57b3f7de542d81ca22b0da2f.1716225483.git.dsimic@manjaro.org>
Reply-To: wens@kernel.org
From: Chen-Yu Tsai <wens@kernel.org>
Date: Thu, 30 May 2024 00:27:10 +0800
Message-ID: <CAGb2v66DPvvRcq+98vF2mCF8URW_qys1+B_FM9kcm6ppuPvyeg@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: rockchip: Fix the DCDC_REG2 minimum voltage
 on Quartz64 Model B
To: Dragan Simic <dsimic@manjaro.org>
Cc: linux-rockchip@lists.infradead.org, heiko@sntech.de, 
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, 
	robh+dt@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, 
	linux-kernel@vger.kernel.org, stable@vger.kernel.org, 
	Diederik de Haas <didi.debian@cknow.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, May 21, 2024 at 1:20=E2=80=AFAM Dragan Simic <dsimic@manjaro.org> w=
rote:
>
> Correct the specified regulator-min-microvolt value for the buck DCDC_REG=
2
> regulator, which is part of the Rockchip RK809 PMIC, in the Pine64 Quartz=
64
> Model B board dts.  According to the RK809 datasheet, version 1.01, this
> regulator is capable of producing voltages as low as 0.5 V on its output,
> instead of going down to 0.9 V only, which is additionally confirmed by t=
he
> regulator-min-microvolt values found in the board dts files for the other
> supported boards that use the same RK809 PMIC.
>
> This allows the DVFS to clock the GPU on the Quartz64 Model B below 700 M=
Hz,
> all the way down to 200 MHz, which saves some power and reduces the amoun=
t of
> generated heat a bit, improving the thermal headroom and possibly improvi=
ng
> the bursty CPU and GPU performance on this board.
>
> This also eliminates the following warnings in the kernel log:
>
>   core: _opp_supported_by_regulators: OPP minuV: 825000 maxuV: 825000, no=
t supported by regulator
>   panfrost fde60000.gpu: _opp_add: OPP not supported by regulators (20000=
0000)
>   core: _opp_supported_by_regulators: OPP minuV: 825000 maxuV: 825000, no=
t supported by regulator
>   panfrost fde60000.gpu: _opp_add: OPP not supported by regulators (30000=
0000)
>   core: _opp_supported_by_regulators: OPP minuV: 825000 maxuV: 825000, no=
t supported by regulator
>   panfrost fde60000.gpu: _opp_add: OPP not supported by regulators (40000=
0000)
>   core: _opp_supported_by_regulators: OPP minuV: 825000 maxuV: 825000, no=
t supported by regulator
>   panfrost fde60000.gpu: _opp_add: OPP not supported by regulators (60000=
0000)
>
> Fixes: dcc8c66bef79 ("arm64: dts: rockchip: add Pine64 Quartz64-B device =
tree")
> Cc: stable@vger.kernel.org
> Reported-By: Diederik de Haas <didi.debian@cknow.org>
> Signed-off-by: Dragan Simic <dsimic@manjaro.org>
> ---
>  arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts b/arch/ar=
m64/boot/dts/rockchip/rk3566-quartz64-b.dts
> index 26322a358d91..b908ce006c26 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-quartz64-b.dts
> @@ -289,7 +289,7 @@ vdd_gpu: DCDC_REG2 {
>                                 regulator-name =3D "vdd_gpu";
>                                 regulator-always-on;
>                                 regulator-boot-on;
> -                               regulator-min-microvolt =3D <900000>;
> +                               regulator-min-microvolt =3D <500000>;

The constraints here are supposed to be the constraints of the consumer,
not the provider. The latter is already known by the implementation.

So if the GPU can go down to 0.825V or 0.81V even (based on the datasheet),
this should say the corresponding value. Surely the GPU can't go down to
0.5V?

Can you send another fix for it?


ChenYu

>                                 regulator-max-microvolt =3D <1350000>;
>                                 regulator-ramp-delay =3D <6001>;
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel