Received-SPF: pass (google.com: domain of linux-kernel+bounces-194445-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Michael Kelley <mhklinux@outlook.com>
To: Aditya Nagesh <adityanagesh@linux.microsoft.com>,
	"adityanagesh@microsoft.com" <adityanagesh@microsoft.com>,
	"kys@microsoft.com" <kys@microsoft.com>, "haiyangz@microsoft.com"
	<haiyangz@microsoft.com>, "wei.liu@kernel.org" <wei.liu@kernel.org>,
	"decui@microsoft.com" <decui@microsoft.com>, "linux-hyperv@vger.kernel.org"
	<linux-hyperv@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v5] Drivers: hv: Cosmetic changes for hv.c and balloon.c
Thread-Topic: [PATCH v5] Drivers: hv: Cosmetic changes for hv.c and balloon.c
Thread-Index: AQHaseJ69t/2vyNxWkWkqbj5I7HRCLGuZKrA
Date: Wed, 29 May 2024 16:29:17 +0000
Message-ID:
 <SN6PR02MB41572A8E15A990EB162C60FCD4F22@SN6PR02MB4157.namprd02.prod.outlook.com>
References:
 <1716998695-32135-1-git-send-email-adityanagesh@linux.microsoft.com>
In-Reply-To:
 <1716998695-32135-1-git-send-email-adityanagesh@linux.microsoft.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?2ocTWdRznMtBUGq1YHSb8t1kBVLFLb4DTAwtapTobvgSMw8xpxiLqZxNMZGp?=
 =?us-ascii?Q?UEeuLOiIljiIljT5HR/6qgq7sE1XrofBiaMrBmY4LzJWbBEl6mxvnADq975T?=
 =?us-ascii?Q?FaZnuzLv4ESSGdUwlOTAPccH2wfEHm+38kZ82V6n9ioGSMfe8vmjtcZZK/Xr?=
 =?us-ascii?Q?+fkDG5s/WpixLfxHpjslXC5bEM0UO+Ah8mdiM6YXeqU+dmYtNfQfCiMEb3Wd?=
 =?us-ascii?Q?MTrzSEwTstMvAnGX8Yt5cQ7EeO7G0kbZ4MMfnOteQe3Fbek5ueatWpZ3XLLy?=
 =?us-ascii?Q?VSLguCIq4hKLXxq1Cuxq6YokRW3VZmrLELBO49Jr8cq1uz2bKs9O4T/Sn9Xs?=
 =?us-ascii?Q?JZbVYfDa+V2FKtRyhX+mq2k+rVoW1FYQWjnwfsGVKajB+A3LBPsPGlu1HtSW?=
 =?us-ascii?Q?EM7Zi1OEQvWr/C89HcgS0H7usR2VEp2Azhhqifv8qZXBC8ViAO5JiWUY4orG?=
 =?us-ascii?Q?AgmRv/l/0kes6wy9PYYzSnypcKYsatA4L8ffADqHCheN2E+lKZDUczqx1evr?=
 =?us-ascii?Q?jInK53dFmhXHhdhHXgsmD19p+8XlwFDV+PZyYa84GyHy2vYxjOHOaChg/l79?=
 =?us-ascii?Q?rwGtDIrvOtTxqQ0lH/33B5+lKviIPbujGKQ8ki3+/728FEJQEFCrDQ2VxXOd?=
 =?us-ascii?Q?63US9e95V2jSzFU/gcB3grgJJa7tYXj25CfB87TURFnUTY9EFGnuNYgmYAq9?=
 =?us-ascii?Q?g2fKDvyLGtuHqaUOr1R5aSWFZnnywkhbgT7rkia0zFTn0co5mi0024IWv3wh?=
 =?us-ascii?Q?fZ5eCVD1jtvo0tuXMG+9FVy0k558wTBebBeqkgVm5WBop2DcBqVfraN3GPtG?=
 =?us-ascii?Q?u3N83cwlCVhQI5Rcl5WzWaad2NAbwplWh6kP06U+XBCx5n5fUI0wUOkqlKHz?=
 =?us-ascii?Q?LkkP2rvQqkv0kmtAv63ImUU2cUZIZqfc5a0lvNhuGgJvZyVPbZMuS9UX7ZHr?=
 =?us-ascii?Q?oAcNXtX9N4FRQ6iKEt/6bN3wcCYNkXGeJhk/pSuWzKLQpuO2HOQhr2KpDaRA?=
 =?us-ascii?Q?iofgutvTw2CdRwhqbRqHmGiirzZnlLoUfUx1oDTLchkUBKHUDL8hBV/J1Bca?=
 =?us-ascii?Q?U8BgHcRcT+D3eWgr6Ez/ISRPM0JUOU2DjzjtIe9VsMPb99MzUCrcnUDvBYuW?=
 =?us-ascii?Q?IfM5kPQf4BT3gfXAOS/R+f97HcuisiWpVn0hEEQn5di0R1j5Lh6xfgh84VeY?=
 =?us-ascii?Q?ZUVTTQpKLFgjC4x12y5UfMdycvAfQPh71vOrfwQE7RszRCvr5ZQUrVy++1g?=
 =?us-ascii?Q?=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR02MB4157.namprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f555280-1bb0-4661-a3e6-08dc7ffc7ca1
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 May 2024 16:29:17.8976
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR02MB9582

From: Aditya Nagesh <adityanagesh@linux.microsoft.com> Sent: Wednesday, May=
 29, 2024 9:05 AM
>=20
> Fix issues reported by checkpatch.pl script in hv.c and
> balloon.c
>  - Remove unnecessary parentheses
>  - Remove extra newlines
>  - Remove extra spaces
>  - Add spaces between comparison operators
>  - Remove comparison with NULL in if statements
>=20
> No functional changes intended
>=20
> Signed-off-by: Aditya Nagesh <adityanagesh@linux.microsoft.com>
> Reviewed-by: Saurabh Sengar <ssengar@linux.microsoft.com>
> ---
> [V5]
> Rebase to hyperv-fixes
>=20
> [V4]
> Fix Alignment issue and revert a line since 100 characters are allowed in=
 a line
>=20
> [V3]
> Fix alignment issues in multiline function parameters.
>=20
> [V2]
> Change Subject from "Drivers: hv: Fix Issues reported by checkpatch.pl sc=
ript"
>  to "Drivers: hv: Cosmetic changes for hv.c and balloon.c"
>  drivers/hv/hv.c         |  37 +++++++-------
>  drivers/hv/hv_balloon.c | 105 ++++++++++++++--------------------------
>  2 files changed, 53 insertions(+), 89 deletions(-)
>=20

[snip]

> @@ -999,21 +984,14 @@ static void hot_add_req(struct work_struct *dummy)
>  	rg_start =3D dm->ha_wrk.ha_region_range.finfo.start_page;
>  	rg_sz =3D dm->ha_wrk.ha_region_range.finfo.page_cnt;
>=20
> -	if ((rg_start =3D=3D 0) && (!dm->host_specified_ha_region)) {
> +	if (rg_start =3D=3D 0 && !dm->host_specified_ha_region) {
>  		/*
> -		 * The host has not specified the hot-add region.
>  		 * Based on the hot-add page range being specified,
> -		 * compute a hot-add region that can cover the pages
> -		 * that need to be hot-added while ensuring the alignment
> -		 * and size requirements of Linux as it relates to hot-add.
> -		 */
> -		rg_start =3D ALIGN_DOWN(pg_start, ha_pages_in_chunk);
> -		rg_sz =3D ALIGN(pfn_cnt, ha_pages_in_chunk);

Hmmm.  The above is not a cosmetic change.  Looks like this
delta was erroneously introduced in the v5 version.  It wasn't
there in v4.

Everything else LGTM.

Michael