DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=date:from:to:cc:subject:message-id:references:mime-version:content-type:content-disposition:in-reply-to:user-agent:sender;
        b=mSJbYYHZGmYmuDbwWYnPZ2zlGnTqsUz0QX6AxTn7OC/SMgjJYlV5WdtcDom5GFALm+EiVWASX3Dm7ZB1oUC5jKLwp2eRl+uQ5oI/SxPvAcCKkQt1N89DsaxrMEFvSdDTo5hlwxQCQpLeqDVaXXLQQwTNv3XqteaW9SsP4PTRdY0=
Date: Sun, 3 Feb 2008 23:28:55 +0530
From: Rabin Vincent <rabin@rab.in>
To: Frank Seidel <frank@f-seidel.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Remove unneeded code in sys_getpriority
Message-ID: <20080203175854.GB3124@ubuntu>
References: <20080203030429.GB7459@ubuntu> <200802031054.45604.frank@f-seidel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200802031054.45604.frank@f-seidel.de>
User-Agent: Mutt/1.5.13 (2006-08-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 924
Lines: 25

On Sun, Feb 03, 2008 at 10:54:45AM +0100, Frank Seidel wrote:
> On Sunday 03 February 2008 04:04, Rabin Vincent wrote:
> > This check is not required because the condition is always true.
> > ...
> > -				if (niceval > retval)
> > -					retval = niceval;
> > +				retval = 20 - task_nice(p);
> 
> Thats surely correct, but on the other hand currently those
> case blocks are quite independet of their possition/could easily
> be rearranged now .. or think of another case is put ahead.
> Then this could mess up things.

Do you mean the PRIO_* cases in the switch?  They're still independent
of position after the patch because they don't fall through.

> Thanks,
> Frank

Rabin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/