Received-SPF: pass (google.com: domain of linux-kernel+bounces-194427-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 29 May 2024 17:17:15 +0100
From: Conor Dooley <conor@kernel.org>
To: Amna Waseem <Amna.Waseem@axis.com>
Cc: Jean Delvare <jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>, linux-hwmon@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@axis.com
Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: ti,ina2xx: Add
 ti,alert-polarity property
Message-ID: <20240529-untangled-occultist-5c9804aa9c8f@spud>
References: <20240529-apol-ina2xx-fix-v2-0-ee2d76142de2@axis.com>
 <20240529-apol-ina2xx-fix-v2-1-ee2d76142de2@axis.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="B08QvXBxqEuzg5Yv"
Content-Disposition: inline
In-Reply-To: <20240529-apol-ina2xx-fix-v2-1-ee2d76142de2@axis.com>


--B08QvXBxqEuzg5Yv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 29, 2024 at 11:47:44AM +0200, Amna Waseem wrote:
> Add a property to the binding to configure the Alert Polarity.
> Alert pin is asserted based on the value of Alert Polarity bit of
> Mask/Enable register. It is by default 0 which means Alert pin is
> configured to be active low open collector. Value of 1 maps to
> Inverted (active high open collector).
>=20
> Signed-off-by: Amna Waseem <Amna.Waseem@axis.com>
> ---
>  Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 9 +++++++++
>  1 file changed, 9 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Doc=
umentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> index df86c2c92037..5a16d2d94587 100644
> --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
> @@ -66,6 +66,14 @@ properties:
>      description: phandle to the regulator that provides the VS supply ty=
pically
>        in range from 2.7 V to 5.5 V.
> =20
> +  ti,alert-polarity:
> +    description: Alert polarity bit value of Mask/Enable register. Alert=
 pin is
> +      asserted based on the value of Alert polarity Bit. Default value i=
s Normal
> +      (0 which maps to active-low open collector). The other value is In=
verted
> +      (1 which maps to active-high open collector).
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    enum: [0, 1]

There's no need for this to have a value, it's sufficient to be a flag
of "ti,alert-active-high". Present would mean active-high and absent
active-low. This has the added benefit the devicetree node being
understandable to a reader.

Thanks,
Conor.

> +
>  required:
>    - compatible
>    - reg
> @@ -88,5 +96,6 @@ examples:
>              label =3D "vdd_3v0";
>              shunt-resistor =3D <1000>;
>              vs-supply =3D <&vdd_3v0>;
> +            ti,alert-polarity =3D <1>;
>          };
>      };
>=20
> --=20
> 2.30.2
>=20

--B08QvXBxqEuzg5Yv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZldVCwAKCRB4tDGHoIJi
0gNKAP9tdovZVC/pwj2mW9ZIqPBsKDXqAn23r9f3tZKtfS7x1QEA5EkK2S6RSWXv
IzKEudQYn6vqfCJVpRUGcUwVAKG0Og4=
=2DdV
-----END PGP SIGNATURE-----

--B08QvXBxqEuzg5Yv--