Received-SPF: pass (google.com: domain of linux-kernel+bounces-194481-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 29 May 2024 17:36:34 +0100
From: Mark Rutland <mark.rutland@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Arnd Bergmann <arnd@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Jason Gunthorpe <jgg@ziepe.ca>,
	Valentin Schneider <vschneid@redhat.com>,
	Baoquan He <bhe@redhat.com>, Peter Zijlstra <peterz@infradead.org>,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64/io: add constant-argument check
Message-ID: <ZldZkm_bqDSZ1oS5@J2N7QTR9R3.cambridge.arm.com>
References: <20240528120844.3523915-1-arnd@kernel.org>
 <ZlcODqVXTDh6n0h-@J2N7QTR9R3>
 <8ff9bc52-bf2f-4856-9335-14bf659e7e4c@app.fastmail.com>
 <ZldE0dp7cBpZl4JY@J2N7QTR9R3.cambridge.arm.com>
 <c63093a6-6787-49ba-ac23-8e27b4861560@app.fastmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c63093a6-6787-49ba-ac23-8e27b4861560@app.fastmail.com>

On Wed, May 29, 2024 at 06:15:57PM +0200, Arnd Bergmann wrote:
> On Wed, May 29, 2024, at 17:08, Mark Rutland wrote:
> > On Wed, May 29, 2024 at 02:29:37PM +0200, Arnd Bergmann wrote:
> >> On Wed, May 29, 2024, at 13:14, Mark Rutland wrote:
> 
> >> 
> >> Yes, your version addresses both failures I ran into, and
> >> I think all other theoretical cases.
> >> 
> >> I would prefer to combine both though, using __always_inline
> >> to force the compiler to pick the inline version over
> >> __iowrite32_copy_full() even when it is optimizing for size
> >> and it decides the inline version is larger, but removing
> >> the extra complexity from the macro.
> >
> > Sorry, I'm not sure what you mean here. I don't see anything handling
> > optimizing for size today so I'm not sure what change your suggesting to
> > force the use of the inline version; AFAICT that'd always be forced for
> > a suitable constant size.
> >
> > What change are you suggesting?
> 
> What I meant is that reason gcc chooses to not inline
> the macro is when we build with CONFIG_CC_OPTIMIZE_FOR_SIZE.
> 
> Since it doesn't know that __const_memcpy_toio_aligned64()
> is intended to be small after inlining, it sometimes
> decides against it, which (with just my patch) would
> fall back to the out-of-line __iowrite32_copy_full()
> while trying to generate smaller code.
> 
> The __always_inline annotation just overrides the
> calculation.

Ah, ok.

I think what you're suggesting is:

* Add the __always_inline annotations, as in my patch.

* Move the __builtin_constant_p check into __const_iowrite32_copy(), as in your
  patch.

* Remove the __iowrite32_copy() macro and rename __const_iowrite32_copy() to
  __iowrite32_copy(), removing the redundant logic.

Assuming so, that makes total sense to me.

Mark.