Received-SPF: pass (google.com: domain of linux-kernel+bounces-194482-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 29 May 2024 17:36:38 +0100
From: Conor Dooley <conor@kernel.org>
To: Gustavo Silva <gustavograzs@gmail.com>
Cc: jic23@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, lars@metafoo.de, christophe.jaillet@wanadoo.fr,
	devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] dt-bindings: iio: chemical: add ENS160 sensor
Message-ID: <20240529-upper-brisket-f326418bcfc2@spud>
References: <20240529001504.33648-1-gustavograzs@gmail.com>
 <20240529001504.33648-2-gustavograzs@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="qWWuIHVqaicUKbf/"
Content-Disposition: inline
In-Reply-To: <20240529001504.33648-2-gustavograzs@gmail.com>


--qWWuIHVqaicUKbf/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, May 28, 2024 at 09:14:19PM -0300, Gustavo Silva wrote:
> Add bindings for ScioSense ENS160 multi-gas sensor.
>=20
> Datasheet: https://www.sciosense.com/wp-content/uploads/2023/12/ENS160-Da=
tasheet.pdf
>=20
> Signed-off-by: Gustavo Silva <gustavograzs@gmail.com>
> ---
> changes in v2:
>  - Add devicetree binding file specifically for this sensor instead of
>    adding it to trivial-devices.yaml. This is needed in order to
>    document that this chip supports Vdd and Vddio supplies.
>  .../iio/chemical/sciosense,ens160.yaml        | 68 +++++++++++++++++++
>  1 file changed, 68 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/chemical/sciose=
nse,ens160.yaml
>=20
> diff --git a/Documentation/devicetree/bindings/iio/chemical/sciosense,ens=
160.yaml b/Documentation/devicetree/bindings/iio/chemical/sciosense,ens160.=
yaml
> new file mode 100644
> index 000000000..7dd442f94
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/chemical/sciosense,ens160.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/chemical/sciosense,ens160.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ScioSense ENS160 multi-gas sensor
> +
> +maintainers:
> +  - Gustavo Silva <gustavograzs@gmail.com>
> +
> +description: |
> +  Digital Multi-Gas Sensor for Monitoring Indoor Air Quality.
> +
> +  Datasheet:
> +    https://www.sciosense.com/wp-content/uploads/2023/12/ENS160-Datashee=
t.pdf
> +
> +properties:
> +  compatible:
> +    enum:
> +      - sciosense,ens160
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  vdd-supply: true
> +  vddio-supply: true
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    i2c {
> +      #address-cells =3D <1>;
> +      #size-cells =3D <0>;
> +
> +      gas-sensor@52 {
> +        compatible =3D "sciosense,ens160";
> +        reg =3D <0x52>;
> +        interrupt-parent =3D <&gpio0>;
> +        interrupts =3D <19 IRQ_TYPE_EDGE_FALLING>;
> +      };
> +    };
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    spi {
> +      #address-cells =3D <1>;
> +      #size-cells =3D <0>;
> +
> +      gas-sensor@0 {
> +        compatible =3D "sciosense,ens160";
> +        reg =3D <0>;
> +        spi-max-frequency =3D <10000000>;

If you want to include this, you need to add an
allOf:
  - $ref: /schemas/spi/spi-peripheral-props.yaml#
above. Otherwise this looks pretty good, so with that added
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

--qWWuIHVqaicUKbf/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZldZlgAKCRB4tDGHoIJi
0g03AQD9mMzRxuq5lalKfEVAFTGZoMACZkTJNATWvobYmPeI1gD8DdGZHwZmmO2G
xQRJoSkgZK6Dq33FTVKRxp1vaIJqWgw=
=kMRI
-----END PGP SIGNATURE-----

--qWWuIHVqaicUKbf/--