Received-SPF: pass (google.com: domain of linux-kernel+bounces-194497-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240528143420.742611-1-talycb8@gmail.com> <520cf8db945cf8dce4afdaddb59ceda65463a406.camel@codeconstruct.com.au>
In-Reply-To: <520cf8db945cf8dce4afdaddb59ceda65463a406.camel@codeconstruct.com.au>
From: Tal Yacobi <talycb8@gmail.com>
Date: Wed, 29 May 2024 20:01:52 +0300
Message-ID: <CAN7-cG5w9rjhJnDJJSOTiopxkj75mOJEC9eKZqmJaqbeMudPQQ@mail.gmail.com>
Subject: Re: [PATCH] mctp i2c: Add rx trace
To: Jeremy Kerr <jk@codeconstruct.com.au>
Cc: matt@codeconstruct.com.au, rostedt@goodmis.org, mhiramat@kernel.org, 
	mathieu.desnoyers@efficios.com, netdev@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

Hi Jeremy,

Thanks for the reply.

> > mctp-i2c rx implementation doesn't call
> > __i2c_transfer which calls the i2c reply trace function.
>
> No, but we can trace the i2c rx path through the trace_i2c_slave
> tracepoint. It is a little messier than tracing trace_i2c_write, but
> has been sufficient with the debugging I've needed in the past.

Oh, I missed that.
I had to test it with an older kernel without i2c_slave tracing
so I looked only at the regular i2c and mctp trace paths.

> > Add an mctp_reply trace function that will be used instead.
>
> Can you elaborate a little on what you were/are looking to inspect
> here? (mainly: which packet fields are you interested in?) That will
> help to determine the best approach here.

Sure, I basically wanted to trace the i2c packet buffer in a simple way.
Although, it seems we already have that in the trace_i2c_slave since 5.18 so
it could be redundant, unless you see any other potential use for it.

Thanks,
Tal.