Received-SPF: pass (google.com: domain of linux-kernel+bounces-194500-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 29 May 2024 10:08:56 -0700
From: Shakeel Butt <shakeel.butt@linux.dev>
To: Roman Gushchin <roman.gushchin@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>, 
	Johannes Weiner <hannes@cmpxchg.org>, Rik van Riel <riel@surriel.com>, 
	Michal Hocko <mhocko@kernel.org>, Facebook Kernel Team <kernel-team@fb.com>, linux-mm@kvack.org, 
	linux-kernel@vger.kernel.org, syzbot+17416257cb95200cba44@syzkaller.appspotmail.com
Subject: Re: [PATCH] mm: vmscan: reset sc->priority on retry
Message-ID: <3rtsgmhjxlaafdw7zeasyt4voa77mzpb32s6tsdz4pj4jglq4p@uuekegdnsolw>
References: <20240529154911.3008025-1-shakeel.butt@linux.dev>
 <ZldV3pNL6ArlgPyU@P9FQF9L96D>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZldV3pNL6ArlgPyU@P9FQF9L96D>

On Wed, May 29, 2024 at 09:20:46AM GMT, Roman Gushchin wrote:
> On Wed, May 29, 2024 at 08:49:11AM -0700, Shakeel Butt wrote:
> > The commit 6be5e186fd65 ("mm: vmscan: restore incremental cgroup
> > iteration") added a retry reclaim heuristic to iterate all the cgroups
> > before returning an unsuccessful reclaim but missed to reset the
> > sc->priority. Let's fix it.
> > 
> > Reported-and-tested-by: syzbot+17416257cb95200cba44@syzkaller.appspotmail.com
> > Fixes: 6be5e186fd65 ("mm: vmscan: restore incremental cgroup iteration")
> > Signed-off-by: Shakeel Butt <shakeel.butt@linux.dev>
> 
> Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>
> 
> Good catch!

Thanks.

> 
> > ---
> >  mm/vmscan.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/mm/vmscan.c b/mm/vmscan.c
> > index b9170f767353..731b009a142b 100644
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -6317,6 +6317,7 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
> >  	 * meaningful forward progress. Avoid false OOMs in this case.
> >  	 */
> >  	if (!sc->memcg_full_walk) {
> > +		sc->priority = initial_priority;
> >  		sc->memcg_full_walk = 1;
> >  		goto retry;
> >  	}
> > -- 
> > 2.43.0
> > 
> 
> I wonder if it makes sense to refactor things to be more robust like this:

Oh I like this as it will make sc->priority values explicit. I hope we
don't have any hidden dependency on do-while semantics for this code
path.

> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index d3ae6bf1b65c7..f150e79f736da 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -6246,7 +6246,7 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
>         if (!cgroup_reclaim(sc))
>                 __count_zid_vm_events(ALLOCSTALL, sc->reclaim_idx, 1);
> 
> -       do {
> +       for (sc->priority = initial_priority; sc->priority >= 0; sc->priority--) {
>                 if (!sc->proactive)
>                         vmpressure_prio(sc->gfp_mask, sc->target_mem_cgroup,
>                                         sc->priority);
> @@ -6265,7 +6265,7 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
>                  */
>                 if (sc->priority < DEF_PRIORITY - 2)
>                         sc->may_writepage = 1;
> -       } while (--sc->priority >= 0);
> +       }
> 
>         last_pgdat = NULL;
>         for_each_zone_zonelist_nodemask(zone, z, zonelist, sc->reclaim_idx,
> @@ -6318,7 +6318,6 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
>          * good, and retry with forcible deactivation if that fails.
>          */
>         if (sc->skipped_deactivate) {
> -               sc->priority = initial_priority;
>                 sc->force_deactivate = 1;
>                 sc->skipped_deactivate = 0;
>                 goto retry;
> @@ -6326,7 +6325,6 @@ static unsigned long do_try_to_free_pages(struct zonelist *zonelist,
> 
>         /* Untapped cgroup reserves?  Don't OOM, retry. */
>         if (sc->memcg_low_skipped) {
> -               sc->priority = initial_priority;
>                 sc->force_deactivate = 0;
>                 sc->memcg_low_reclaim = 1;
>                 sc->memcg_low_skipped = 0;