Received-SPF: pass (google.com: domain of linux-kernel+bounces-194509-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <ebd69de8-5c97-487e-b86a-8afdcde49a6d@web.de>
Date: Wed, 29 May 2024 19:20:27 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add CM3588 NAS board
To: Dragan Simic <dsimic@manjaro.org>
Cc: Jonas Karlman <jonas@kwiboo.se>, Heiko Stuebner <heiko@sntech.de>,
 Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>,
 Sebastian Reichel <sebastian.reichel@collabora.com>,
 linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20240526214340.8459-1-seb-dev@web.de>
 <20240526214820.9381-1-seb-dev@web.de>
 <9f40c748-691b-4a03-bbd6-54870f46bf05@kwiboo.se>
 <29e5cf31-3d9a-469a-befa-41a5aa2fe8b3@web.de>
 <bccd8879a19ceacfd92a41e7533b324c@manjaro.org>
From: Sebastian Kropatsch <seb-dev@web.de>
In-Reply-To: <bccd8879a19ceacfd92a41e7533b324c@manjaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:AWu6vFBFlaM=;iS1IlLJHaAyDKPqsIyiWaZlG9iZ
 thspF47GX2usRA858C/sGhaax0Uygs+xMCeaKF0ehVcSpam+FvfJlJY8TkJCtKF8hR4mGDUtc
 /4LMkbGQ7gpRmjF9sDoKtqxfp0yfvjVJQFsHKQhINcxtFVpXu71BVJc17NvyGxZH6M6HsUxiM
 E9jqU+pJAOInJd0BOutE8UyzDY3FRV5bKAI7cDGjjIofsB+nek+37JOAEoI8faGZDgbHB+f8E
 Bq51n4wWDbg0/98OhjZBpfwhcVlsxQnZBz0uJLNgg+EFHXLf1fgsC5/eOR7d20nOSOo7q6Utq
 5E3ibIASn/yJX3cZvFOxniVPpD3wG1kOKRHBs/0bwnZbZKWIexs4C1XoA2ZUZ2THKtAIo6ipL
 PQvwQ41pT8KX6PAN9YEV7CkSkh1DcgQTMVDYymiP/qbo/BPP8Ng+4ZPqgwLMwFZRaUFbsIPDv
 U84gguIDvIB4YXw3LE+SsJ9L9vZTrXn614Fi/0JauA8lo5FaSE7DlJLmKgj17y6undLOaOHqv
 NNTQH7w6eiABoJ9cwOoX3o1FqdNByEkKt0jVfPTnjKAmXmVuZkLMkvUFlFpr6ezIwGXpKqRE6
 jswOT7vlTjB00g8BziSoQKAouLS8MBahgykDqDuNgirocupdV4g0zwhwrpd8ldMKTIqqrgHeu
 bCIVRjT3CoLzc3g8+x6Ko2WlW4Cwq9A3H4jAhd/zVwn7pkiImvsFuQWYlAWkYXY7nNjXP+F/N
 aP0i6ktWYbELG/G8oDqH+USmlqFOKWnuGOd916BfjJILxeggarbY+Lmu2JPaUN1dHrZhw5mqV
 LxKxYt++K6JXOVcfWYqgSsV+v2sz1Rq8qj6WwAbtsVwoY=

Hi Dragan,

Am 29.05.2024 um 02:10 schrieb Dragan Simic:
> Hello Sebastian,
>
> On 2024-05-28 19:22, Sebastian Kropatsch wrote:
>> Am 27.05.2024 um 21:02 schrieb Jonas Karlman:
>>> On 2024-05-26 23:48, Sebastian Kropatsch wrote:
>>>> The CM3588 NAS by FriendlyElec pairs the CM3588 compute module,
>>>> based on
>>>> the Rockchip RK3588 SoC, with the CM3588 NAS Kit carrier board.
>>>>
>>>> [...]
>>>>
>>>> PCIe bifurcation is used to handle all four M.2 sockets at PCIe 3.0 x=
1
>>>> speed. Data lane mapping in the DT is done like described in commit
>>>> f8020dfb311d ("phy: rockchip-snps-pcie3: fix bifurcation on rk3588").
>>>>
>>>> This device tree includes support for eMMC, SD card, ethernet, all US=
B2
>>>> and USB3 ports, all four M.2 slots, GPU, RTC, buzzer, UART debugging =
as
>>>> well as the buttons and LEDs.
>>>> The GPIOs are labeled according to the schematics.
>>>>
>>>> Signed-off-by: Sebastian Kropatsch <seb-dev@web.de>
>>>> ---
>>>> =C2=A0 arch/arm64/boot/dts/rockchip/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0=C2=A0 1 +
>>>> =C2=A0 .../boot/dts/rockchip/rk3588-cm3588-nas.dts=C2=A0=C2=A0 | 1269
>>>> +++++++++++++++++
>>>> =C2=A0 2 files changed, 1270 insertions(+)
>>>> =C2=A0 create mode 100644 arch/arm64/boot/dts/rockchip/rk3588-cm3588-=
nas.dts
>>>
>>> Because the CM3588 is a SoM and the NAS is a carrier board this should
>>> probably be split in two, cm3588.dtsi and cm3588-nas.dts.
>>
>> I thought about this before submitting. My reason for not splitting thi=
s
>> into two files for now was that as far as I know this board is the only
>> combination for the CM, maybe no other daughter board will ever get
>> released. If another carrier board compatible with the CM3588 is
>> released, the splitting could be done at that point in time.
>>
>> But since both you and Heiko prefer to have it split, I will figure out
>> a way how and which parts will have to split up to the CM so we can
>> have two files in the end. I guess most things will go into the NAS dts
>> anyway.
>>
>> I'll have a look how other Rockchip compute modules with split device
>> trees were done in the past and orient myself by that.
>
> I also support the DT split between the SoM and the carrier board,
> even if there are currently no more carrier boards available for
> the particular SoM.=C2=A0 That may seem redundant, but it reflects the
> nature of the hardware setup, in which the SoM plugs into the carrier
> board.=C2=A0 This follows the principle of the DT describing hardware.

Following the principle of the DT describing the hardware does make
sense, that's a very good explanation!
I'll try to follow up with this in a v2 in the next few days.

Thank you,
Sebastian