Received-SPF: pass (google.com: domain of linux-kernel+bounces-194520-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <c17774d8-11b3-4f59-a995-329bf2300fce@intel.com>
Date: Wed, 29 May 2024 10:42:47 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 01/16] selftests/resctrl: Fix closing IMC fds on error
 and open-code R+W instead of loops
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, Babu Moger
	<babu.moger@amd.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>
CC: <linux-kernel@vger.kernel.org>, Fenghua Yu <fenghua.yu@intel.com>, "Shuah
 Khan" <skhan@linuxfoundation.org>
References: <20240520123020.18938-1-ilpo.jarvinen@linux.intel.com>
 <20240520123020.18938-2-ilpo.jarvinen@linux.intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
Content-Language: en-US
In-Reply-To: <20240520123020.18938-2-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RHBoaU1Qc0VMZ0g4enpGLzFGSmxkRkRSUHhZV0xTQ2ltNEUxbnBUZmYrelk1?=
 =?utf-8?B?dGpENEZvOWdUSjdqZ25MV2w2ckFMNXpyell5R056L1IyaE1nbXZKc0U3MEE5?=
 =?utf-8?B?M1duOUhqYnd2U3l1Yk9Ta3FLRWNSYjd1cnIxVzR1RFErVUhJTWM4NUNyclNJ?=
 =?utf-8?B?TzBSTzdodjhiU2w4amEyKzNkV2ZGQy9Ob1J3WHhrSmxwUXY1dkhub3ErK21x?=
 =?utf-8?B?OVhuMU43aCtSOExGSGoxakVFbjA5djBvaWx6cGViY0xlUDBtQWx0YkJsMEdU?=
 =?utf-8?B?WnZveHROcTJYRWt4YlAxN0kzaUdLdEtjL01yYWM5Z3IzNkMyQ3ZIajgrY2dY?=
 =?utf-8?B?S1RwaTN3OVEvSlVjMjYzNFNBSzhjdklMaGtxUmFKc1hGVHJxVGcvS2NDVkFu?=
 =?utf-8?B?Y25Id01iSDBzVDNZUFVkenpFNVNuaHBvUkQrWWxsZC9rb3ROczRyakRyVDE3?=
 =?utf-8?B?bEw5T25TSHZoNnRQM0ZSKytES2ViSk42UEdDd0F3d2kva0FDSUppMHhlTmZM?=
 =?utf-8?B?cTR0bkRmQk1zTFpkcU5wb1htaWs1QTNtL2tSMWdjdnN0RFVYdTlxUEIvcmVF?=
 =?utf-8?B?TExFK3hIbFNoS1NaUW52M29ETHRDeWVxVU5CZDNmdWxZWjBLbW0vaHFRdzdt?=
 =?utf-8?B?cmx4OHJxazdFNFJ3cC8wbTl0Z2h0NzlwaHJORnYvczM1VkNKNWNrTytGUXg1?=
 =?utf-8?B?M09mUUFpc01pdHM0c2x6cENaMWVzbzQ4ajhDS1NkVVlZdjZNRm9uWVVNejM0?=
 =?utf-8?B?YWFMYklmSXQrQ25MMVo4S0RKTG9PRHM5MVNJTEZyWFdwbHoxcVNzRStzOThh?=
 =?utf-8?B?aVIzTFRIZlNUaktjdndVMlZTNjNUSjMxeU9QYm5pZHJhYnh5TXlDaVhRdG5j?=
 =?utf-8?B?SkJlajB2U0pNVjh2V1FlWmgyOU1lUXE4T2lUb0xKSWhvSmxrWlpHeDhxNkNE?=
 =?utf-8?B?Smx2NE5sWjhrZXN3ZXlJTzlnbHg4U2ZaMU9rT1kwdkhpSXBWWHlPalU1WTFT?=
 =?utf-8?B?dWZpUEJlR3JOTnM5SXo1bDdsM2Z0UXIzSk9ZNWFpN0ZhMHJsdFFQMnlOWFo0?=
 =?utf-8?B?YkFRK0NVRXF0VkFsVkI2b1p6a25HNE9IMWd0MENMbEEzWjJkQjBESWszWkpy?=
 =?utf-8?B?djJtYkUxSE94MlFBRGRTT2RHeE1kdVNRZjgwcXRnM0Y2VHIrSEtoaVd1OXo0?=
 =?utf-8?B?WlkzbkFqODhyU1JJN01uM3dZc1drM3R6WlZrVkF2OHRkOVdzVk05NHBKVHBW?=
 =?utf-8?B?R0hEK0R1T3ViSGxRaDZ2dlRrSnBMdXF6dnpSTnM5Y2w2UWl1WGY1a0hSbWg4?=
 =?utf-8?B?UHc4dERzOUlwQ05VUEg5VzM4NVJKdm9vc1g4V1ZCUVVhcUNlWGo3MFNYaVRR?=
 =?utf-8?B?ckdmV1BJRlgrVmVxQnpWVHZxYklIYTJSS25FQjdJK2ZnNkliWUZtbXpMSFp2?=
 =?utf-8?B?dDMvZmZXMVQ0eXZJNzNFMDVJbGVsZk1ORDd5cnM0M01DeThTRDFLMlZNdytt?=
 =?utf-8?B?WUVEbGRlODVSTlJFWkJkd2NMaFZWQWVRZHdVTE9ZSjBFbVlYVnppMDdReUly?=
 =?utf-8?B?L256TExFTGxYSlhTRUg5NjBKcUtNWDdReCtsTWVDbUFaY0ZEcTdiNExjMEVV?=
 =?utf-8?B?QmZmdjRqN2xTOFYybGpRMEl1b1lBRWlmM1NDZThQZGNUM3Q2NnZFMDZQZXQ2?=
 =?utf-8?B?QnBhb1NjN250SEhSTXZobVNPZ2p2Zzhwb3pUb2tLNnVYZ0JBSDJoc2FXNUdj?=
 =?utf-8?B?c296MkxUaXZvYTdZQlI5OUJTYnNaSlRscWJzZnVCMENyeEJYMjlPSU9VSTFm?=
 =?utf-8?B?UzBzVHRvRjI2Nms3WTFta0lmSG1hOHlySDFXb0l4SFBrTmloTU4rZFppS0hv?=
 =?utf-8?B?QWdyN3lFOVRRNW1XRHR4ckJWUk9Yc3hCa09sQzhGaUZQSDdmK0xtYWlGZ0Jv?=
 =?utf-8?B?RmFGbm4vSmFpWkJma0tSKzBFbFg5U0w5ai95aS9iakV2NVdmb3Mzak9tSy8v?=
 =?utf-8?B?YzdLRU5aVmptc3E0d2NOVzFmSDBzbWN1OVlGY3dIZEFsRENrUDQvZDU1eDhB?=
 =?utf-8?B?dEFnQ1htMHI3aFZxbG00NlFGUEgrSFZPVG5GZlE1N1o4ZUdvQVJsS2xmK1BR?=
 =?utf-8?B?Um9LNUZGcVd0OTNFcWdSSXEwdElDSnFpWUF0UGk0NWJLZFo4MFVjdFc5TGFm?=
 =?utf-8?B?RVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e782216-d14b-4ab0-4673-08dc8006c25c
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 17:42:50.0471
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Hw+0Aj/uOSiQdyMiHlnEcDMTHv2l2qcrV1Hgg3vS8Xd3jtg5QLuSiGGnt583OtyFktb4KYZfiCNeRJGhlCTn2+0HL3IHbsm9v5KhX2NMkTw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7854
X-OriginatorOrg: intel.com

Hi Ilpo,

On 5/20/24 5:30 AM, Ilpo Järvinen wrote:
> The imc perf fd close() calls are missing from all error paths. In
> addition, get_mem_bw_imc() handles fds in a for loop but close() is
> based on two fixed indexes READ and WRITE.
> 
> Open code inner for loops to READ+WRITE entries for clarity and add a
> function to close() IMC fds properly in all cases.
> 
> Fixes: 7f4d257e3a2a ("selftests/resctrl: Add callback to start a benchmark")
> Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette