Received-SPF: pass (google.com: domain of linux-kernel+bounces-194522-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <0e931356-abde-4118-94cc-6905f409cf95@intel.com>
Date: Wed, 29 May 2024 10:43:23 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 04/16] selftests/resctrl: Consolidate get_domain_id()
 into resctrl_val()
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, Babu Moger
	<babu.moger@amd.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>
CC: <linux-kernel@vger.kernel.org>, Fenghua Yu <fenghua.yu@intel.com>, "Shuah
 Khan" <skhan@linuxfoundation.org>
References: <20240520123020.18938-1-ilpo.jarvinen@linux.intel.com>
 <20240520123020.18938-5-ilpo.jarvinen@linux.intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240520123020.18938-5-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFNmd1ErNUtGQzRiMi9rNXJWN0JnOTBKbFRBbWJSaVRDTFlnNCtWMDV4MnJF?=
 =?utf-8?B?cUxqOWtJZ0RObjRUNVFaRmxPaDZyTVBCOTRkdDJHcHp4THczazdwbDAwMmlC?=
 =?utf-8?B?WUlaSFFNeFVsNURJV3R2b3Q2eEsyanFKV3pMc2NNNnVwN0x0dk9pNVVjVVM3?=
 =?utf-8?B?c2tMaDNMYWxPMUFrNTVOYTNJY2F6QkoyUUJYaTBCV3BIbnZBSnRwSzRIdlNw?=
 =?utf-8?B?N1JKTnRjbnZpQUxOMGRjVisyK3BoV3NpNThaT2ZKZGF1eDJ6RlpGMEFQSzJH?=
 =?utf-8?B?UXJpYlpqT1lJSUF4T1BaSlFaYmpYb3RMMmo5V0V6ZjBQZGxGa0puUVYyczFz?=
 =?utf-8?B?VUpZL3VubTV1aC9MRGRsK0pEMWxrM1Y3a3lpSUZ6WnU2MjVIRE5SSG1paEpl?=
 =?utf-8?B?ajRpTjduZVJleHd5QkVzMktYT2FWQ3RTd1QwdEhheEVmR1pvdUxUOGllVit6?=
 =?utf-8?B?NldHTVJ6MDNzaFBNZGtpK3FNTlhjajlKOGxQNmUrdm0xd0ttQysrQndKMWJL?=
 =?utf-8?B?U3A3Ni9WODU2WDBZMjFwL3hFY2IwN2pUb2FwanZ4RXhFUklzM1Z1K0RBNWxB?=
 =?utf-8?B?Ym56SUZaOThRWkwwMmRLR0daRkVxcEZ6VTBlcTUxR0NjMUZ3dmttdks0aE9q?=
 =?utf-8?B?T2dxMzUxcVJSQnlUUHdCNG9FV1BNejB0c1IvMjZUL01DZ1F4b2ZDanFmVjg5?=
 =?utf-8?B?NTQ1Yzd3cnphcW8ySVZwckZiM3NnT3Z2OEs5S01zdFZsWTNOeVIyVTFFYzNs?=
 =?utf-8?B?MjQzaVFLOHhicTBIODI4VHJOQW1HWjRWMmZ4STRZckc0SzZvcHFEc1k3dHd0?=
 =?utf-8?B?VytyazJBRGs3elllenMrSU1YeE42ZWVBUTVVQ0FEZCt6SExuL2dWVXRZRjN4?=
 =?utf-8?B?OGIyMzdYVlJFVVM5WG83L3kxZ0UwWGhyaktFVTlwbmF6cExzdE9uZlp4Rkx6?=
 =?utf-8?B?SGI5c3ZLMzdHaFcrVE10Tms1UzJEdTUwTzFRbyt2Nk45MXVQY2FDY2VZZDdK?=
 =?utf-8?B?dkQ4bUtUVi90VU9XNGRJeS9hSXJrdUtoeTN3RWNoNStjN3ExdzhMZWpiN2VP?=
 =?utf-8?B?TS9nN0U4VVphVUp5NlEraXVRRkJJZVBMZno5QXdUMmtab1B6Z0s1WjYyU05r?=
 =?utf-8?B?bzducmM0RVZqNmRMUHl4MG0xQ3BkQXRtYWxLaFVDSkJob0daS0J3ZDlWbU1h?=
 =?utf-8?B?dkRpMThHbzVOenZhSU1kblhKY3Zqcks1SjFuRG82YVNKQUUyZkhUeUZNWlg1?=
 =?utf-8?B?Q1RTdE9WWk5ZdTZFN3JudVIrVTUvOHlEcktuN09LN3hjeVNXMVpHcnN4TWJW?=
 =?utf-8?B?N3ZTZ2VXaXFSVkQySFBEM1NXMFR0dFN5bkViMTdWWlpyc3hVaFZQYlNwejRH?=
 =?utf-8?B?NS9GM0hHZWhldDVKMzhyWTVqR2NGYUptR3ZYWEs3TDdWbHZjTk9aaHpNOHpo?=
 =?utf-8?B?ODVESXlmK3MzdXZnTFU2bXRDSXZSa0NCOGNHUnVZYmxIbjE0WVdTRnZRYnNR?=
 =?utf-8?B?UyttSXJtaGhNeXBmUkFSYVVDaVZpNmpVTmNSSEJwcEZnMFkvclFrOGFGVjBz?=
 =?utf-8?B?c0F2THlOU0d1d3Z3TVMrdFQ5Y3hJTG9zWUdNQVFpdlFsaURja1RudTB0TUpC?=
 =?utf-8?B?UThyVWJTeVBxaVgvNG1XVTd6eDNGbm1PVlNjejVuTDJQay9jNm1scFZUWUt2?=
 =?utf-8?B?RUx6NFVZOFZMNGJMdDY0dlRWU2dLRGE2Z1VRbzZIR0pSQ2FBTmdCTVpFaHM2?=
 =?utf-8?B?a0swOENCOEh0UktLSTZmVENCWitvL2RSMUp6a2c2M2U0S01RTlh1NlVIOGF0?=
 =?utf-8?B?RGthL0NGQnErbFBxNWFrK1pJdStteGJ0TjU2SmMxT0dyS25iMmVxeElQa3ND?=
 =?utf-8?B?bnJlTkJ6Q1ArQUtiTDVqTk1HOE5JeUlydG5MblZlbmZURjBlSmhoeVNna0Fi?=
 =?utf-8?B?UEc5RkVVNFN1bFlPYkdrVFpBMEdDVklMRXVCRmloS3l2YXNTVXg2NkFhZE9O?=
 =?utf-8?B?dVJ4VHRyUFZmZ01Tc0h2Q2ROc2N6Y2NtZjYzeXRMS0NlZXN2SHNub0hORzNK?=
 =?utf-8?B?Qm8vaUxrWFkvVjVEOFltNW9TQTNnTGk2aVVNNnlrRE4wYlVMWEdkeU03cmpk?=
 =?utf-8?B?ZEUrdEZXNURlSGxTSUhqQWpZN3BUMUlnUHAwa05uTVBielRUa3c4bEt5Z1FX?=
 =?utf-8?B?OGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bae612c5-f9c3-4012-beb5-08dc8006d767
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 17:43:25.3049
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MtIGQ/2vuL2pCh/wZVu2HGUdSMfWbPN+iP1gD3MBmup79Om9wR9Gt3in2KQAK6cdWqO00Ekt2h5Xo8ePjKPgADiu8oCETMOsquOwR5qK+Dk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7378
X-OriginatorOrg: intel.com

Hi Ilpo,

On 5/20/24 5:30 AM, Ilpo Järvinen wrote:
> Both initialize_mem_bw_resctrl() and initialize_llc_occu_resctrl() that
> are called from resctrl_val() need to determine domain ID to construct
> resctrl fs related paths. Both functions do it by taking CPU ID which
> neither needs for any other purpose than determining the domain ID.
> 
> Consolidate determining the domain ID into resctrl_val() and pass the
> domain ID instead of CPU ID to initialize_mem_bw_resctrl() and
> initialize_llc_occu_resctrl().
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette