Received-SPF: pass (google.com: domain of linux-kernel+bounces-194523-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <80b08de1-fa61-4c20-aad9-1844d2303df7@intel.com>
Date: Wed, 29 May 2024 10:44:01 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 05/16] selftests/resctrl: Use correct type for pids
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, Babu Moger
	<babu.moger@amd.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>
CC: <linux-kernel@vger.kernel.org>, Fenghua Yu <fenghua.yu@intel.com>, "Shuah
 Khan" <skhan@linuxfoundation.org>
References: <20240520123020.18938-1-ilpo.jarvinen@linux.intel.com>
 <20240520123020.18938-6-ilpo.jarvinen@linux.intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240520123020.18938-6-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emEvUkFHcSs0c2VRb3VINXFUbXZtcDlYamhGMEsrR2xLMElRMXJoNGIyMzBo?=
 =?utf-8?B?QXIwU2p3ZmhKTzRNbHJDTE9vYmtVSTdTdWhsSUREMGd4a3lYYisycnVyV2M3?=
 =?utf-8?B?SjZzeEx5VEFLQjhpVmlpaWUvd3hsRmt5K1UwdnlPdVJWam1HQ1QvdlpRdmpq?=
 =?utf-8?B?K1YraUxrek5IQzNHaG40eEdickF2ZHBib3hubFdjVDVoZFN1encrQ0xONWY1?=
 =?utf-8?B?aDhhbGdXeGljWVFpSEtIeFNuZWdsOHRnYkQyOTVFQ1FVa2F1VlkzeWVMQ0hk?=
 =?utf-8?B?RDY0ei9mdExVYzdYMnpLRTR5UFNmOGRoRTRZanF6ZWlMSzJzaEc4OGVhRUR3?=
 =?utf-8?B?cmZYaGV4alNyZ2t2NUtqTmZoTW9RbUFDVEcxNGJQaStpTWJXRGhkRzlTWWs5?=
 =?utf-8?B?WGJ4UlNFYXhScVRZUmk2M1QwLzRjMUxzMWovcXVaQkl0cU05Z3N3NXVBMUdY?=
 =?utf-8?B?bUVqTDh5TEEzK0RRa2dVSUUxUC9aajVFcWxjU0xlb3FtYW9ndVN5bnVaais3?=
 =?utf-8?B?WUYyKytCVkZpeVk4dlROUjdWK3llSVRCallHSHhiNTFPWkgrd1l4K3FhWGZG?=
 =?utf-8?B?eEF2RGdKT3F2WE1qallqTDFGTEtrdU5jK2xTVEdxRzJoZE9Ua3FDbFVxMnpQ?=
 =?utf-8?B?cWVjQlQ1Q2xrWStPNHRUWTIrK3ZwR2NUS28vOWFKVnpRc1ZjQW9JWHhpNFVS?=
 =?utf-8?B?RkF1N2hOVUF4bHVrakRWQldSNmdRZUdzTXJha3AwQU4xaXI5RDBUenRSUHFM?=
 =?utf-8?B?QkQzem42MXdkbGlKcVZ0VU5hY1hYbHo0S3Jmc3cwRThnc3gwamNKM0tCTCtv?=
 =?utf-8?B?alFQVzFvMlk4RkhEQzExQk1DL25nelJYcTZVSzZDQXdoOGNQU3RJazh5MFVM?=
 =?utf-8?B?Vk9qNzlMQmJKRHg2dDc2WDNHTGVYaFJWUDRFdWJYNmVrcmlNQ0h6eU9CbU1k?=
 =?utf-8?B?blhBSGlFNVV6R1Z1bEY1M1E3M3BPckd5MHM4dUE5cmQ1eFRiMVNueE1EZzMw?=
 =?utf-8?B?Y29oNGVnZ0NJOUtZTGc5WXRZOWRHVC95bzdIK25lY0dvUnpKY0g4K0R6dVBY?=
 =?utf-8?B?RFJuUHhMd3Zicy9NeTh0eitNZ0crYjBJOXNCdjRqcG9FOFJkMGNyZkhHMHBI?=
 =?utf-8?B?TXU4bTVGdEl2elZLSTUwUFhLRzY1Y1pRanlnbWVYRkM4Q1NoNXVnN2RYMlgr?=
 =?utf-8?B?UjlROUV5ajFTK0pIL0xselRYeHhERU9aZFBFS1R6SlZCKy9aR2RPWm51VS9N?=
 =?utf-8?B?eGMyZEE2UFc3TGdVMXhvdnR1YmJWMStwa1dkam1QbUVxZ1V2Rk54b3NGM3ZH?=
 =?utf-8?B?ejM0SkRGZ1VIT0ErTFc5bXY4dU0zdmxVN0Y2SWhLRUErdE9vanRnSGFvM0VD?=
 =?utf-8?B?TXFnWGFlRGZDcUVEN0d1TXJ0dzhBVlFZWjhDb09TYkZCeGI5SlZQZHpSaFNh?=
 =?utf-8?B?OXFOUERldS9CRDF1QVBHZmVncUNHTjlWb245Ykh5UlQ2bVNSa2FmNE02ZG5G?=
 =?utf-8?B?ckxldmY4QWYzSkVoeE1TWVA5RDFWZmxqZ00yWDQzUSt0RzIzYUFKMkRzV0x6?=
 =?utf-8?B?WlArRGgxNll1eTQ4K2NHRlFuYWxRUzg3b1RBTWlodExyeUx2RDJWWEx1dWRB?=
 =?utf-8?B?RVBqc3pBNFd2Y1QwS3ZiaVNNUkdJSXZ2djQ4U2l1OHBqeXpBNk9zQW1mYWV0?=
 =?utf-8?B?cFdQcUFzMFJvZ3RFbFlaRWtpdkErNW92WTUxa254K1MvdnhNeGdNSytBSGxH?=
 =?utf-8?B?Z2FRKzFnc3R5UGt5MDZuS09BNm9NZG9COUJ3WVZtWmpnbjZBVTBoTjJPVFZB?=
 =?utf-8?B?M2N5N2RtWUFxTGJHbXhwRE52UmdhU1BLRFpRVGlLVDFjVENGV01CNW1YU2ov?=
 =?utf-8?B?TkFwcWc2VDFlUklwUkx3TGllbHp3ZTFwNVR5bDhiblVVeW95STR1cDZSZTgz?=
 =?utf-8?B?MGh0RkhMN2xQVUl3MFZ1bmxDRURHSkY2OGRnZ3Exa1poVzBkNUR3QkYzMkQ2?=
 =?utf-8?B?ZlNNakVra1pXSEg4eHd1UFQ1eEVpeDFSRWFFRkN0NTgxQkxBMGVja2dxeEJJ?=
 =?utf-8?B?ZXRuU3J6S2REMStXYmxsa1hlMnFhUHMyK1FOc2UwTVhNSWlhaXFYajR4UjZO?=
 =?utf-8?B?cjVpT0VpSytLdGZtZkJsZDB6U0dpdW1tSjJVaDBscFBwZUpNMkJ2V240ck45?=
 =?utf-8?B?N3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e8659c14-d252-45b4-8408-08dc8006edef
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 17:44:03.0912
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VD4WL1D5jdMBB4dbzf9qAlaFzZVAEjp+qvrnA8vYQUhPkYIP/aJWvE3GPxhcJXT8pdA1tIWxp0KqhWC7vlTiLP7NK/Nkt5oS+HlJWva3izE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7378
X-OriginatorOrg: intel.com

Hi Ilpo,

On 5/20/24 5:30 AM, Ilpo Järvinen wrote:
> A few functions receive PIDs through int arguments. PIDs variables
> should be of type pid_t, not int.
> 
> Convert pid arguments from int to pid_t.
> 

This looks good to me. A couple of places remain that treat
pid_t as int ... that is via the %d format specifier
used to do the printing in print_results_cache() as well as
print_results_bw(). I understand we do not see any warnings
since these are indeed int. So, I wonder if an explicit (int) cast
would not make things obvious and match the stated goal of
not treating pid_t as int?

Reinette