Received-SPF: pass (google.com: domain of linux-kernel+bounces-194524-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <8b437845-8132-40e6-b442-1b85e5b8aae6@intel.com>
Date: Wed, 29 May 2024 10:44:18 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 06/16] selftests/resctrl: Cleanup bm_pid and ppid usage
 & limit scope
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, Babu Moger
	<babu.moger@amd.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>
CC: <linux-kernel@vger.kernel.org>, Fenghua Yu <fenghua.yu@intel.com>, "Shuah
 Khan" <skhan@linuxfoundation.org>
References: <20240520123020.18938-1-ilpo.jarvinen@linux.intel.com>
 <20240520123020.18938-7-ilpo.jarvinen@linux.intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
Content-Language: en-US
In-Reply-To: <20240520123020.18938-7-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGVTRGFtbE9rSGxiRkNOVFZkcGFIQmFRL1N4Qkt5empZVDVSNEhmd3BZY2NU?=
 =?utf-8?B?WU95RU16dEJPRmxpR2RJL1lSMFFxd0prbE9BdkxTN08zb1IyLzFLNTB4WXdx?=
 =?utf-8?B?UTU1TElkaE9wTDh2djdVTVdNMzJPeDl5LytyNENDZ0xGTXNLS1NPSFpoWWxp?=
 =?utf-8?B?NVpSM0JnOEtrdGFoeUhnTlc2b1VSeE82SDFoSGpnOXRhWTM3cW4zakZiMkg0?=
 =?utf-8?B?Nlo3Y3pmcHZ4QkdWMTBiaHVsTUtYajEvcnMzSlJIUzhEWnB4TW5pK254RjFT?=
 =?utf-8?B?MVJiTlh5QUZPVCt4UkorTng5Y2JhckhjQ3AwYnhxSm1IaFc1eHZTa1lRM3N2?=
 =?utf-8?B?ZUF0TDcrTmNnbUt5OFJxUS9LWlZIZk1wUlBsT2hBSFBGUEFSWllQYkRra2cz?=
 =?utf-8?B?SE82N0VhWm1HTzEvT2FvdzZrRjdmc0VHT1hQcnJlUkE5M0M1RVhCK2pVWXdB?=
 =?utf-8?B?ZVBCcVNUVXFJK0FjazdFYjlNRFdDa2NYU2JUa3JlK216Y2RzQTZCcnBYVWJK?=
 =?utf-8?B?ZGI5SkxVbzNaSnAzRW9aT1MxclpNdHU4SllPMnZEUWxRTGlNZ1IxNjJGMFZO?=
 =?utf-8?B?K21YS2d4VDJkZ3pjRnhFTXd4azUzS1RkVHVKZHY3U0RpWG5zc3REQVlYRkor?=
 =?utf-8?B?SzY3dk1iYko3WDNBQ0lEbXBkZnBCbDc2OWFUL1Zxbkp4TlZDWFBzaTZFa3Fo?=
 =?utf-8?B?QjV2OExLUFFKL0VMYWxwODMxdU9nejFJRytGS3BJRXVDNFBicG1XSncySElp?=
 =?utf-8?B?VG5aZS9uaGZWL2NNRlNQb09JNCszcURSc3A0MVZGbjFMRXppNmtmYnExaHF1?=
 =?utf-8?B?WDRjNm91WUVqcDBLUnBISkoxd3lDL3FvdTUrYkVwZzBjdTBxUnllUjNaaTQ1?=
 =?utf-8?B?L1hiWDdOVjcrcDVIZEhWYmZGc3RmM1kwdnRENXZRNkFOZ2JaeE1xNktPNWw4?=
 =?utf-8?B?UG5vMkxhcXVIQXB0U0lZZHJQOWhFWlkxOHdtbkM0TFlMWFVWeFFpV3hYMmVv?=
 =?utf-8?B?Z0VkMGNkNVZxSU9kNXo4SndzNGsrdGhTNlMvaEVVWDd5a3RWOXhTdUJVVThj?=
 =?utf-8?B?b0hRcmVTSk91ZDJFNDVRODUxUUthMWFNSXJFL1FvYWZQT2loY1QzbU9VbGsz?=
 =?utf-8?B?Q0trcG0rL2xveWVlWmFOcEl5NGNRWGhMVzB5Unk1OGJsbE9oUUZhLzFBR0RN?=
 =?utf-8?B?Ty9aU3pNajhGTGwxbXBha25MSkdpRmcvRm9FQlc2NURvT2tkcit2TjBrejMv?=
 =?utf-8?B?RzRNU0dJUFBPaXZxNksxcTViU3ZkaTZLQ1pDcHExelNoYlpxOGM5aVFYOFND?=
 =?utf-8?B?d2FjQkFxMGtVWVdOSXRTWGN4MUVDbVBEUW9TcmovdkM4VkxIQ3RFVEF3WXQw?=
 =?utf-8?B?S051aGVabVRhbG0wS3czSktCQytWL2RVdTRnbEQxL3hqSUprUGhCcUNwUzZk?=
 =?utf-8?B?RXV4dGYzYW8yUXFJV0JkVUVSajZaL1JTU0E1WCtXWUx6ZU1TM1d3d0RteTJ5?=
 =?utf-8?B?STV2UHNSOXpyQjRUY0JZRWdtZlhTcXl4bU43eVRkeU44T0NJQkhLMjRVVWpL?=
 =?utf-8?B?MzNnbVh3TGJqdlBjMXY4ZldPcHluc0FPUGw4dUhWMk9xdWRhdHlMdXN1YndG?=
 =?utf-8?B?VEgxTXc0U1BlakM4SkJrbkRVV3IrRVZkRG9QcjgrdXNGTjFveUI4TFhUd09h?=
 =?utf-8?B?bkliQkpldGtzME52aWxzV01USW1XQ1hMcGdjUkV3cXZwNFR0dGIrMk43YW5Q?=
 =?utf-8?B?UnE5aXhLQjVpdXBTK0FOZjBBdm5LTyt3c1dDZXE4ckpkeUNGM2pwb2V1SWM0?=
 =?utf-8?B?bndJWnhrMlE4QVJnRDNIbWZ6aGhDRkM0Y2hEck5tbloycVVydENzR1BzS3o1?=
 =?utf-8?B?MnArejlnVzdibm5CN3Q5MVFxM090RFg2ZldUYmg5TGFBZC9PTS9odml1Ym9L?=
 =?utf-8?B?cnJYYzJTL09aVThFb0dHN1FRa0xEYlZOdXE2WWgyYWg5V0JoSWpvZ3FjWW0z?=
 =?utf-8?B?K29zSGRQN25SMnBIRHNCM0duQ3psMzZqbHk0eVNBMm5JdGp5WmlEZ1R1eEtC?=
 =?utf-8?B?RzZjb1dNbm4yOTdzRkwrRHI5MEZDUExsNURZSERJNURUVERkc2dBWi8wajhx?=
 =?utf-8?B?azdFOWRTUmxpMEJER1ZiTmV6WGk5OGVOaEZmOExXOWxCUWpYWGNuVXhtYWgv?=
 =?utf-8?B?QUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d93be2a7-7bcf-44e5-ee93-08dc8006f887
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 17:44:20.8797
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fyCXP9igA1sik5/9MtXOE56cAM9jeoNqaL/GmcCUGeLSCvM8EsXT3K2u3PhzMXp2OLIj4nzOPJYwTjsoh8yl7ZSJMxUo8U7SD/DZcekMeeY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7854
X-OriginatorOrg: intel.com

Hi Ilpo,

On 5/20/24 5:30 AM, Ilpo Järvinen wrote:
> 'bm_pid' and 'ppid' are global variables. As they are used by different
> processes and in signal handler, they cannot be entirely converted into
> local variables.
> 
> The scope of those variables can still be reduced into resctrl_val.c
> only. As PARENT_EXIT() macro is using 'ppid', make it a function in
> resctrl_val.c and pass ppid to it as an argument because it is easier
> to understand than using the global variable directly.
> 
> Pass 'bm_pid' into measure_val() instead of relying on the global
> variable which helps to make the call signatures of measure_val() and
> measure_llc_resctrl() more similar to each other.

measure_val() -> measure_vals() (in two places above)

> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

With typos fixed:

| Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette