Received-SPF: pass (google.com: domain of linux-kernel+bounces-194527-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <7c5d83d2-3d65-4d75-ac25-dc818624db2d@intel.com>
Date: Wed, 29 May 2024 10:46:09 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 09/16] selftests/resctrl: Add ->measure() callback to
 resctrl_val_param
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, Babu Moger
	<babu.moger@amd.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>
CC: <linux-kernel@vger.kernel.org>, Fenghua Yu <fenghua.yu@intel.com>, "Shuah
 Khan" <skhan@linuxfoundation.org>
References: <20240520123020.18938-1-ilpo.jarvinen@linux.intel.com>
 <20240520123020.18938-10-ilpo.jarvinen@linux.intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
Content-Language: en-US
In-Reply-To: <20240520123020.18938-10-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WFpPb2ptaGlIaW1EWDJxSDhzWkg4VzZlWTFSSG9UeE5IOVFmN2VUc3pUL0NY?=
 =?utf-8?B?eTFmckViOWpqeEU5YVVXTVdZWGRjL3A3Z0xHWjVBcWYvbVZYV3hTZlNnck4w?=
 =?utf-8?B?WHFTQmliaUNHdGp1bXJyN3ozUkVvdlM5QTRob2UrOWZhV2lQWmtaOVBHQUhm?=
 =?utf-8?B?eUZGTlA3NFNiS2tLN3BFT2Fza3dRUEVjbCt3N3U0RDBuQnRZNVVUc0dNUUU0?=
 =?utf-8?B?R245b3JtODFvM00xZFhsWmcybHZramNOdzNuYlREU244dmJvMWUxaFJxVUp2?=
 =?utf-8?B?N1h5QmhheHlsVVFUL2NnU2YwVXkrOXVReVhSVHU5aWsyWkhTQnd4UUQvK2di?=
 =?utf-8?B?VmVtYXNVS3RmVUxRYzJvcjVqSTNZT3JBMHd3THZ5NDltT1oyTit1MHowUDZ2?=
 =?utf-8?B?d0IwL3NWOE1jZnEyMXllbVNGYlZ5dXdTdlFFdDM5VGNIUFkxbVJVcEZoeE5E?=
 =?utf-8?B?QTVQbEFiOFZEbUZXWlRzMnlYN3d6cVdRL2ZVd21zQld3ZkJnZmZFd0NHTWJv?=
 =?utf-8?B?NUFNd3Y4OGhWeVB5NnE3NlVERVhORDZoYkRGN0RVZ3lrdlZHU2NpQmNSTkJL?=
 =?utf-8?B?emVqUkw3cGcrN0hKaktGSjlkWG1OY1hWWmlVWDh5a3VIQWxPamhNOEFkWjl6?=
 =?utf-8?B?a2xUcEQreFo5M2JPY2p4Z3pEdkJBSk5kekJwT3A5dDBXeTdOeisrRVZic3RF?=
 =?utf-8?B?SVpMTkhFVzhERnl4VXh2YzdHSDA0T2N3ditBL3YzUHJ2anFtSFpsRGhrdnpw?=
 =?utf-8?B?blVVbzEwNHIrcFpBN29TQmNKWG4vUldvZHV4VzkySS8wNm5UeTR2Q1cxMHho?=
 =?utf-8?B?aC9tOVFoSFhVU2xlejBwUkRnUXhiRjFVWVZIUUVSZ3ZjbFAveDZzb3VTS0Vz?=
 =?utf-8?B?NzUxQkRycFh2YjVWRGhtL2traEVkSE1HTm1YdTZuLzBlQVFvVjEvWlkvMzJN?=
 =?utf-8?B?dnltWW14TG5mWTNKbmdEYmh5K2RMY0dsSDFHcUNjWUdodGp1a0JDNkhSQjVG?=
 =?utf-8?B?MzdmRHpiZmhVcHN4SUpudll0eldNZ0dGUDdCQjRqZG5FV3l2QUZxR2kzMk9y?=
 =?utf-8?B?Nm45K24zWHluTFIxQThXM0luUmlBTDdzVTRya09RLzFvcEd1ZGhEQnpyMExV?=
 =?utf-8?B?Wi9sQm9ZcVJzQ0w2ZHhETGNUNmg5Rm53ZXlCdUViM3JqQURnemtCT1ZWUUtC?=
 =?utf-8?B?bVpHODVZNHVzTjlnNTcxZTBoQ1Y1Z2ZWMFZIU3hQWGhvaDNMQTRUckRiMU9F?=
 =?utf-8?B?eGZOcFltRG85WnF6RWpYZmw3Mk93OUp1WXpRQkkxaUVtNVMwbUhJcFJHQ05w?=
 =?utf-8?B?RHd1ckYycGpTeFZpOENaRjhIU0pZc2h4M1JPVWhjdFh2cVUrZVRxOXNJWjdv?=
 =?utf-8?B?RVp2a2VndzM5T0tYOVIzNXpRUDl2dFBtQS9sZG9XMEVOTjZkb2tScDR2ak01?=
 =?utf-8?B?S2VrQmd3endkb2RVZUdkMVkrMUVLYXR1N3RnazFPOE5uTVEvUFlzT1VYLytk?=
 =?utf-8?B?KzNVbGxrZ0tnNERrV1FuZVBrS0QzWWdhc3k0d3J1SjBpR2J3bnV4bkx1emtD?=
 =?utf-8?B?T3pqZHFPaEtqU08zNHdxNFZDMVYxZkI0dDk3TkpLV3BaTXRxY3ZFQ0tZSzdW?=
 =?utf-8?B?eElpb0tFekpnVFZHRG5oWHFLM0U3MXUxRHhkelp2Y0lGeEtOVkF0Q3A4Q0V1?=
 =?utf-8?B?am5mbkNQbzc5L3E4S3A2U1lJVy93VVh5T3NhQmIvRHp0OUswTUhyWXp1Tzc5?=
 =?utf-8?B?ZzFZbGV3S3dxRGdML3huK1lkRlBHRlVQQUw4ZHBmSFJ1blcyNW85bzdYNHVF?=
 =?utf-8?B?a2lZRVFqU3J5Sm1vVFQxVGtHSFNFZUxJV094TkJydGdJdDROYVkreEtrYkdt?=
 =?utf-8?B?bk01dUxDMWhKTlh1TmY2cGIwNE5rVkF6a216N1crZ2hzd05XZGZ3bnByZU5I?=
 =?utf-8?B?S2pCNUtONkZWakhGbzA4Vm41QmduZXhtODRSV1RPREt1QjJvZVphMlBJZmxZ?=
 =?utf-8?B?MkNOVC9LOFJnR3dxeEpzYUpGbkJPZHBYbkg1N2FiTXZ6OUhuL25nUzVMZnRI?=
 =?utf-8?B?bFVlTjhxNHlMNW1SakJsUUpRUjQ0Q3BRYlRiQ0txdWE0eGR1cjUyMzZyTjEy?=
 =?utf-8?B?UW5obzFaL3JSSnpEWVlwQmZjM2pSYXhFcHJSVjJaenFNUXI5cFpsNGNIOFFS?=
 =?utf-8?B?VlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b362f9ea-1924-4e66-2df1-08dc80073a0d
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 17:46:10.7929
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CegFe1Vv4LaNat6lw5qdZAzdS8wMb9cf7cXUUWXZtu9iUOHLJMf4+UOOgZQ0uXfu+ur32lXz/TZcXHfVGr8jKb6JWNYXGJQ/wFiH5QKoFl4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7914
X-OriginatorOrg: intel.com

Hi Ilpo,

On 5/20/24 5:30 AM, Ilpo Järvinen wrote:
> The measurement done in resctrl_val() varies depending on test type.
> The decision for how to measure is decided based on the string compare
> to test name which is quite inflexible.
> 
> Add ->measure() callback into the struct resctrl_val_param to allow
> each test to provide necessary code as a function which simplifies what
> resctrl_val() has to do.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette