Received-SPF: pass (google.com: domain of linux-kernel+bounces-194534-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <f2a8e8ad-311c-4302-a200-03fc9f02b20b@intel.com>
Date: Wed, 29 May 2024 10:49:07 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 14/16] selftests/resctrl: Remove mongrp from MBA test
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, Babu Moger
	<babu.moger@amd.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>
CC: <linux-kernel@vger.kernel.org>, Fenghua Yu <fenghua.yu@intel.com>, "Shuah
 Khan" <skhan@linuxfoundation.org>
References: <20240520123020.18938-1-ilpo.jarvinen@linux.intel.com>
 <20240520123020.18938-15-ilpo.jarvinen@linux.intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
Content-Language: en-US
In-Reply-To: <20240520123020.18938-15-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlpjVERtcGRoWkFzS29Lc3dRNzBuQ1RjMFVja2tUYmJ6bWdrY2F5dFN2VEJa?=
 =?utf-8?B?ZDBIblpWcGhVZHgvSGhubjZCNnZ1NDlKcEc5eVNuN2FCVzJOTk8vak0vZXlX?=
 =?utf-8?B?SWxpZnJ4NmdVSGxlWUJSdDdHSnNwdW8zdkR2MTlmWUhzdmNxQy9tV1g3MVcw?=
 =?utf-8?B?TUd3M0owL0Z0bTZ6cFQ5R3VEWnlBeTA4VTJva09LdWI1eEc2dEgxNmhKYkpC?=
 =?utf-8?B?ckxiRFBsalYzME9tMDFWOHdZOXdHd2pJZXZEWHF4NUVDTGlzQVlCQVUwVGUw?=
 =?utf-8?B?NmdHbUhqQmMvZFY0WmhzTjllV2hqV2hJendZNk1iMitvQ2c5NlY3MkFmZkJE?=
 =?utf-8?B?T1NPMElhQi9mNHRnRGZYUWdQbzBWdkxkTlFPMmV2ZU9MMjNxZmY0QkNpdi9l?=
 =?utf-8?B?bFVOR3NBQ055QVZkU0pXMDMrYlBLcG9PY2lwWXVibTFuR3R3YzhpbkdmbWM1?=
 =?utf-8?B?Um85MVl5K254RFJ1UlhVRm1LclJhaWE2eW1HVXIrRU5ZblZpemdZcHZEVWtO?=
 =?utf-8?B?cFRkNEVDeHNvZU5iZlFTU20xTDRuazhlSWdCQ3FQUXlCcFJjb21hY0gwM015?=
 =?utf-8?B?cFZ5T3M4SFVZWnh6dXhpVzZpencwRE1QNDJRTVdHNTk3N3dRVFVoOTM3ME13?=
 =?utf-8?B?R0FGc2ZMbElLT0dnc1RUbkFEVm5POURGOFNTcThwZk9OUkwveENDamNmUmI2?=
 =?utf-8?B?aWd4UklydmZWamg2RUZ0bWJ4V2NnOXMwQ1ZyVTFjcGlRUjdwTElPc2h5dTRt?=
 =?utf-8?B?cmpxY1hRdUV0RU1YT055dTBLdE9jc2RrZlFwNm5ubnBEY09rNEFUSGdnSC9n?=
 =?utf-8?B?VjFlcEdLcXFnQkZ4K25QcTZVZml4aUtOZCtYWW92dm9paVoraEp0QUdSTTRa?=
 =?utf-8?B?c1BwYmZxelROME1Ma08yMDZIOUovZHpmTTFMdzhYcGRnbUpMck1wSHBvS054?=
 =?utf-8?B?dDMzUTJzT1VVNW90YU5Ja1o5Z00zOElyeEtpQ0h2WWZqR2RMVTV5ZTFmRHhl?=
 =?utf-8?B?Snp5T0tUbFlWSmlIODkxZThMRVRlTG93TW9QRENhaVVwOTR2Z3ZaRVRQTXhY?=
 =?utf-8?B?SU42Q1AvekJvSVlSa0hTZDBnMXUvRlZyTzczVURDaTZFWFZyQU9kbXUrcnp0?=
 =?utf-8?B?YkpXUlE1Wi9kNzFJYUFaVVVSYlRRSjB4NUJmY0JNZjVYTGkrMGgwY1RMQkpV?=
 =?utf-8?B?VDlGZHBjNnF4ckdPU21KTjNpM1V1L2hkZ0pZWWN0eVBLV0RmYzZ4Y3Nmb3hn?=
 =?utf-8?B?WkVVdkpQWHdjMW1HSFdzaHBEVGdjY2hVUENFdnZORGl5UXdadmpRWDZocmZW?=
 =?utf-8?B?R0pod1UyMk9iYWVvcXR2WmN6cnB3SVBhNXl4TUpkbVcyRXMyMVZrOXJsUm1Q?=
 =?utf-8?B?MGJPYVF4L2pFVzVUc1BLN09USDhHNWRGM2d2Ym9lMnplbTgzTXVWNSttR2t5?=
 =?utf-8?B?ZnlPSnk3dEl3V0srbkRmL2xRNDBtNEF6V1RISTQ4RjlJTUo2WG5vNU9qbWlW?=
 =?utf-8?B?cU5OZ2VtNmRKV25DSmFkbDVxN0htaVhFNWRJVURNckFPbHRIV2pwUHAweU9r?=
 =?utf-8?B?WDA5QkNqR2E2OHN2NXFRalBqUytQSVlrZzBheHh2U1FoZytZcFMwQ3FCd0Jh?=
 =?utf-8?B?UUNCTzlGSDJtSUZmak9Idjd3T3VPcllhd0M2Zk5RRlBFWGV3WSt3MlBoR0pJ?=
 =?utf-8?B?cFRaRXVMSUtmYngrVWg1YW1LaERleWc1eU9mNUEwVjJQSFpidkRoZXYwN3du?=
 =?utf-8?B?UTRiYXlmN1lnU1RKb0tmNXhIcmxHZjdPRXNSeTd0UGxqa2pzTTdscVFiS2JQ?=
 =?utf-8?B?NHV2Zys1Tk04RmRQRjc1b1Q3Z2N1MnQwWmNlWllhZ3VqMWpQcDBhZGxlZVFS?=
 =?utf-8?B?VSs3Zzh3WXZRSGdQRDB6YmMzUk1adkVZbzIzbkF6SkFIc0R5RFRsUXBSZUFR?=
 =?utf-8?B?WmF2dXpwMGt0WkNHOWVSKzhXaTZPNzY0aCtjLzZEQTdiTWpUbmcxVmRjRUl5?=
 =?utf-8?B?eVhNRmU2VkdjMkQyRXNiMUxZRDNMZ2xtVVBQNzJCd201ZmRHWGhQN2VjbGE3?=
 =?utf-8?B?MUR6ZS9xRXZUdmFaZXU0S0VSQjlWMTZhQk5wTW52b09vL205QnMwWm1lZzRZ?=
 =?utf-8?B?QzB4bVUxNEEzVXlzREw3eS9pSXEybVI4RVc5dVZWY3Z5ZkYyVEROWWwwT3hW?=
 =?utf-8?B?YUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b36253e8-be62-4e2a-8b54-08dc8007a4a1
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 17:49:09.5957
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ufzyYbSLq+i2fCNKJx245ZuqvdQooLFk/7q7FRF1Mx2JYHRApczWr8umx0vbiNT0N14ZuvU35CHGu2wIxjg2m28jH0V/Wbp6ASN2bYJKG7o=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7914
X-OriginatorOrg: intel.com

Hi Ilpo,

On 5/20/24 5:30 AM, Ilpo Järvinen wrote:
> Nothing during MBA test uses mongrp even if it has been defined ever
> since the introduction of the MBA test in the commit 01fee6b4d1f9
> ("selftests/resctrl: Add MBA test").
> 
> Remove the mongrp from MBA test.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
>   tools/testing/selftests/resctrl/mba_test.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/resctrl/mba_test.c b/tools/testing/selftests/resctrl/mba_test.c
> index 9c9a4f22e529..5e0b1e794295 100644
> --- a/tools/testing/selftests/resctrl/mba_test.c
> +++ b/tools/testing/selftests/resctrl/mba_test.c
> @@ -166,7 +166,6 @@ static int mba_run_test(const struct resctrl_test *test, const struct user_param
>   	struct resctrl_val_param param = {
>   		.resctrl_val	= MBA_STR,
>   		.ctrlgrp	= "c1",
> -		.mongrp		= "m1",
>   		.filename	= RESULT_FILE_NAME,
>   		.init		= mba_init,
>   		.setup		= mba_setup,

This may explain the unexpected checks that are removed in final patch?

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette