Received-SPF: pass (google.com: domain of linux-kernel+bounces-194536-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <57116999-bc73-4277-90bb-4877145788cc@intel.com>
Date: Wed, 29 May 2024 10:49:28 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 15/16] selftests/resctrl: Remove mongrp from CMT test
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, Babu Moger
	<babu.moger@amd.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>
CC: <linux-kernel@vger.kernel.org>, Fenghua Yu <fenghua.yu@intel.com>, "Shuah
 Khan" <skhan@linuxfoundation.org>
References: <20240520123020.18938-1-ilpo.jarvinen@linux.intel.com>
 <20240520123020.18938-16-ilpo.jarvinen@linux.intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
Content-Language: en-US
In-Reply-To: <20240520123020.18938-16-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVJEZGFYeWJNdzFnQ2JHUThrLzJTVHZwa3JETVpBVTRRdGQ3eG4rMFVFY2VF?=
 =?utf-8?B?djVXQ0hsa2U4TkpGckNaWExuUXdqMCtkaVdyT0FkQkhiTitjVWxhbTFUV1Qy?=
 =?utf-8?B?ejZRbE13bXF3dEVNWTNIeTFTeVcrbWZTeTlZM3NMblpkZDZTRUNwa3ZlNFNo?=
 =?utf-8?B?KzJaajVMbnBuK2NUaThVTlFxSGpvbkdEamFlUkp2VkxkbEh6bENEOXo4RldT?=
 =?utf-8?B?NHRQMGhEblB4YnBrVGNKekZ3QXRiVG5BdmdrQ2xjT0ZzUlM4SjRqQ1BOTnJl?=
 =?utf-8?B?ZnJjdTkyOEdaeDMzLzZjY3h5TWF0Vk1oZGV0bThwMGVJNFBGWnVyT2JkYitj?=
 =?utf-8?B?d0xZSEtab3RmaWhIN3U4TjBqdmJFUGVvdlRKV215L0F3bytiZCt2cXIxWEhm?=
 =?utf-8?B?SVhLMkRCUTUvZW81ektsL0wxc0FrcUQ0YnVRS1FraTlZYWVIMWV6MTBIcDYy?=
 =?utf-8?B?UnJzNnRhdkJKUW1HUDNndERNclArYzN1T3lvMlFwakwyTWpGYjJ0MmljMHpq?=
 =?utf-8?B?cUxPWW9IYmdPbGZ5QkxzOTlDRS9pdXpvTExJd2IvR1FwdDBibVZIM3VrbDVR?=
 =?utf-8?B?dXZiV013K2x4QTJScG0xVTZjZG9xMk5SbW1XdUF1aHZpcll3Q2gvMmgzN3Bo?=
 =?utf-8?B?Z1B1b21EV0M0U2wyTjg4bjBsbjRmTjNDTHQ0RVBYNDIwOTRKMzMvdFRZeDlC?=
 =?utf-8?B?cWRHb3Y5VkNxV2VMa3YvYkRnQzVncURtdGtpQlVOclBUMEFzV0VOK1d3K0V2?=
 =?utf-8?B?NWd5QnpxcXJLWHluZCtkaE9nSzhkT2xYZnZKQS9WM3RXSS9wbEdrVFpaYmpL?=
 =?utf-8?B?MFJIZE5xWmxJN1hsYlE4aG5Zek1zT0UyZmx4b29BN2hFV1FDYzNGVGgyajdC?=
 =?utf-8?B?RXNEMlQ1cGp0KzZmNEVPdnltYTVDaEVGNE5vQVovTUFuWklCcWFWNTZDOW1K?=
 =?utf-8?B?blZXeGphbXVTaCtERDVocmZ3TlUxbkRqcExkK0VVb3JHUWN2dG1aSkN6RFZs?=
 =?utf-8?B?Z1k5L0wrWG1JWmhWWmlaOE5ES3VEUDEwVUVPaDVPS0ZmVkRmckErRjc1MGth?=
 =?utf-8?B?aUU1TWI0NzFzM2RocWsrWHBvTDRESGg0RmM1MDF5LzhydGRKYnlWZTZwZ2xU?=
 =?utf-8?B?T2xuc01tZ0gxNWJpM09vS0lSWVhxSVhEZEZZSENaYi8xdG52U0VkU2wrQVRp?=
 =?utf-8?B?YUNKUUxaN1dESGtCUTc4c1hHc3lneHE0QXFSRXpiUThvalpWOFZUdFR6VUpU?=
 =?utf-8?B?VEpYVFlSQUxvT2FWMjczOXY5a1JkSnE3dnVwVWxPaFhxMUd6TlhhbVN4dUdo?=
 =?utf-8?B?aGZyVUI0d2t6bUsrUnlVU3o2Q3dVTDB3NWY5QnRoWjRhM1VWQnM0RjkvNDZj?=
 =?utf-8?B?REMxU1JYY3lWK1lIdndTMytjQlBNcEtkWEdOemExSituQm0veXZCMFI3TGlD?=
 =?utf-8?B?TURmT2V6Y2tCZ1h5MTB6RXN0aUMwM0FTVXlJRWV5QnpxNmR4QndUZ0NQcHhO?=
 =?utf-8?B?dUVHUU0zbjFCWmdIL2dyZXdVVjdiNTlDeVEyYmYzdGFkN2NyYUIvZkRZV3F3?=
 =?utf-8?B?RVA0TGt2VUViV3BxOWZKTWN0aGRGWUdZM3hMN1FUOGRwaDN1UDEzRWlyYXV0?=
 =?utf-8?B?OE55SlhZdk5XOE43OGRWS3F1NXRNTHBHSGlQZitVbXVTRElhOGRmckVHQ05W?=
 =?utf-8?B?bGZ3Q3RTdngxZDNtM1NHZytoZDRkMzBTRityelIyR1h5ZE9oYk5WTng1TG5n?=
 =?utf-8?B?UExUSm5xT0xqYmtvWWc2MmdLTzhwSlFkNTlTNkdVYU5Na0hSRHkycW9naXlK?=
 =?utf-8?B?TS9yZURYOUhpK0t6WHpZWS9aRkF0ZWhDSjhBdVlVMjM1NCthaVlCTWRsNGFB?=
 =?utf-8?B?QnZtN3B0OEw2NXpQbk54c3RHWVF2ZTZCbko3V3BKVFRBK2tKYWpxNEJQb0xy?=
 =?utf-8?B?S2JRdE4wK0twVXFHdWpRdmpTNy9jaVo2b01DRTJvakoxb3M3SE9CbHZCMDJO?=
 =?utf-8?B?aHNIVUZOWGZ1Qm9UT0NDOWliN0pvYnlvc1BuaHljcUJ5ZnRLYVhaMEhNazBV?=
 =?utf-8?B?ZWpHQkRDbzhCUkNnbmtSMnM2cUplUHd0UnYzN3JTT0Qwc2NPenhXWGh2bEp4?=
 =?utf-8?B?eUtKdUUwc0QrT3RxWGk4N3YyMHlDMTVUU3JiRG0wMDhsVk0reWVldk1kVXpL?=
 =?utf-8?B?anc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c8368d2-524d-48d6-7297-08dc8007b0e2
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 17:49:30.1738
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xmv4Oo4y2BEeNMSizWvMjv6AI8yqZ+neMonrrApVWM6Ok9KtteCCYRJKC0Or3Am6ZnwMocpNYif9oxSBvYm3RIUW4r1uuLRHmImcuTHiYbU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7185
X-OriginatorOrg: intel.com

Hi Ilpo,

On 5/20/24 5:30 AM, Ilpo Järvinen wrote:
> The CMT selftest instanciates a monitor group to read LLC occupancy.

instanciates -> instantiates

> Since the test also creates a control group, it is unnecessary to
> create another one for monitoring because control groups already
> provide monitoring too.
> 
> Remove the unnecessary monitor group from the CMT selftest.
> 
> Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> --

With typo fixed:

| Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette