Received-SPF: pass (google.com: domain of linux-kernel+bounces-194360-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Wed, 29 May 2024 18:26:07 +0300 (EEST)
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
cc: Sebastian Reichel <sre@kernel.org>, Rob Herring <robh@kernel.org>, 
    Krzysztof Kozlowski <krzk+dt@kernel.org>, 
    Conor Dooley <conor+dt@kernel.org>, Bjorn Andersson <andersson@kernel.org>, 
    Hans de Goede <hdegoede@redhat.com>, 
    Bryan O'Donoghue <bryan.odonoghue@linaro.org>, 
    Heikki Krogerus <heikki.krogerus@linux.intel.com>, 
    Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
    Konrad Dybcio <konrad.dybcio@linaro.org>, linux-pm@vger.kernel.org, 
    devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, 
    platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org, 
    linux-arm-msm@vger.kernel.org, Nikita Travkin <nikita@trvn.ru>
Subject: Re: [PATCH v4 3/6] usb: typec: ucsi: add Lenovo Yoga C630 glue
 driver
In-Reply-To: <CAA8EJproC_mW4pZ_C-BUUm73xfqja0EKVLvCZ+C_1dhW3xoEnw@mail.gmail.com>
Message-ID: <97448807-e567-05a4-9361-efcc84b5f07f@linux.intel.com>
References: <20240528-yoga-ec-driver-v4-0-4fa8dfaae7b6@linaro.org> <20240528-yoga-ec-driver-v4-3-4fa8dfaae7b6@linaro.org> <ce6cbe69-f1de-1224-2a6e-3c7b07203d84@linux.intel.com> <CAA8EJproC_mW4pZ_C-BUUm73xfqja0EKVLvCZ+C_1dhW3xoEnw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/mixed; BOUNDARY="8323328-268320193-1716996253=:1108"
Content-ID: <a301cc47-942d-3661-b1ec-5130087bf169@linux.intel.com>

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323328-268320193-1716996253=:1108
Content-Type: text/plain; CHARSET=ISO-8859-15
Content-Transfer-Encoding: QUOTED-PRINTABLE
Content-ID: <6d420af6-f53c-8618-6400-2923bec3ea61@linux.intel.com>

On Wed, 29 May 2024, Dmitry Baryshkov wrote:

> On Wed, 29 May 2024 at 17:20, Ilpo J=E4rvinen
> <ilpo.jarvinen@linux.intel.com> wrote:
> >
> > On Tue, 28 May 2024, Dmitry Baryshkov wrote:
> >
> > > The Lenovo Yoga C630 WOS laptop provides implements UCSI interface in
> > > the onboard EC. Add glue driver to interface the platform's UCSI
> > > implementation.
> > >
> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > > ---
> > >  drivers/usb/typec/ucsi/Kconfig          |   9 ++
> > >  drivers/usb/typec/ucsi/Makefile         |   1 +
> > >  drivers/usb/typec/ucsi/ucsi_yoga_c630.c | 189 ++++++++++++++++++++++=
++++++++++
> > >  3 files changed, 199 insertions(+)
> > >
> > > diff --git a/drivers/usb/typec/ucsi/Kconfig b/drivers/usb/typec/ucsi/=
Kconfig
> > > index bdcb1764cfae..680e1b87b152 100644
> > > --- a/drivers/usb/typec/ucsi/Kconfig
> > > +++ b/drivers/usb/typec/ucsi/Kconfig
> > > @@ -69,4 +69,13 @@ config UCSI_PMIC_GLINK
> > >         To compile the driver as a module, choose M here: the module =
will be
> > >         called ucsi_glink.
> > >
> > > +config UCSI_LENOVO_YOGA_C630
> > > +     tristate "UCSI Interface Driver for Lenovo Yoga C630"
> > > +     depends on EC_LENOVO_YOGA_C630
> > > +     help
> > > +       This driver enables UCSI support on the Lenovo Yoga C630 lapt=
op.
> > > +
> > > +       To compile the driver as a module, choose M here: the module =
will be
> > > +       called ucsi_yoga_c630.
> > > +
> > >  endif
> > > diff --git a/drivers/usb/typec/ucsi/Makefile b/drivers/usb/typec/ucsi=
/Makefile
> > > index b4679f94696b..aed41d23887b 100644
> > > --- a/drivers/usb/typec/ucsi/Makefile
> > > +++ b/drivers/usb/typec/ucsi/Makefile
> > > @@ -21,3 +21,4 @@ obj-$(CONFIG_UCSI_ACPI)                     +=3D uc=
si_acpi.o
> > >  obj-$(CONFIG_UCSI_CCG)                       +=3D ucsi_ccg.o
> > >  obj-$(CONFIG_UCSI_STM32G0)           +=3D ucsi_stm32g0.o
> > >  obj-$(CONFIG_UCSI_PMIC_GLINK)                +=3D ucsi_glink.o
> > > +obj-$(CONFIG_UCSI_LENOVO_YOGA_C630)  +=3D ucsi_yoga_c630.o
> > > diff --git a/drivers/usb/typec/ucsi/ucsi_yoga_c630.c b/drivers/usb/ty=
pec/ucsi/ucsi_yoga_c630.c
> > > new file mode 100644
> > > index 000000000000..ca1ab5c81b87
> > > --- /dev/null
> > > +++ b/drivers/usb/typec/ucsi/ucsi_yoga_c630.c
> > > @@ -0,0 +1,189 @@
> > > +// SPDX-License-Identifier: GPL-2.0-only
> > > +/*
> > > + * Copyright (c) 2022-2024, Linaro Ltd
> > > + * Authors:
> > > + *    Bjorn Andersson
> > > + *    Dmitry Baryshkov
> > > + */
> > > +#include <linux/auxiliary_bus.h>
> > > +#include <linux/module.h>
> > > +#include <linux/platform_data/lenovo-yoga-c630.h>
> > > +
> > > +#include "ucsi.h"
> > > +
> > > +struct yoga_c630_ucsi {
> > > +     struct yoga_c630_ec *ec;
> > > +     struct ucsi *ucsi;
> > > +     struct notifier_block nb;
> > > +     struct completion complete;
> >
> > Add includes for what you used here.
> >
> > > +     unsigned long flags;
> > > +#define UCSI_C630_COMMAND_PENDING    0
> > > +#define UCSI_C630_ACK_PENDING                1
> > > +     u16 version;
> > > +};
> > > +
> > > +static  int yoga_c630_ucsi_read(struct ucsi *ucsi, unsigned int offs=
et,
> >
> > extra space
> >
> > > +                             void *val, size_t val_len)
> > > +{
> > > +     struct yoga_c630_ucsi *uec =3D ucsi_get_drvdata(ucsi);
> >
> > Missing include for ucsi_get_drvdata
>=20
> I'll review my includes, but this comment and the comment for
> ucsi_operations are clearly wrong. There is a corresponding include.

Ah, sorry about that. I completely missed there was that local include.

--=20
 i.
--8323328-268320193-1716996253=:1108--