Received-SPF: pass (google.com: domain of linux-kernel+bounces-194540-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <047c79de-c6b8-4fb0-aa9f-c48e4086e60c@intel.com>
Date: Wed, 29 May 2024 10:52:46 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 16/16] selftests/resctrl: Remove test name comparing
 from write_bm_pid_to_resctrl()
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,
	<linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>, Babu Moger
	<babu.moger@amd.com>, =?UTF-8?Q?Maciej_Wiecz=C3=B3r-Retman?=
	<maciej.wieczor-retman@intel.com>
CC: <linux-kernel@vger.kernel.org>, Fenghua Yu <fenghua.yu@intel.com>, "Shuah
 Khan" <skhan@linuxfoundation.org>
References: <20240520123020.18938-1-ilpo.jarvinen@linux.intel.com>
 <20240520123020.18938-17-ilpo.jarvinen@linux.intel.com>
Content-Language: en-US
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20240520123020.18938-17-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RFVtRlEwa241TEJNMkJMV1BrbWtXWFQ0TUJ4MDVqdDBCdGxkTFhOUjZwdzJH?=
 =?utf-8?B?RkZSbEx4QWVsUm1oaXNoMHR4QlJFOFk1MGEydXk0SXNnOFFaeG1xY0xWcXgz?=
 =?utf-8?B?K1hKdCtJYVlod2dhR0V3K3dCdHg1Uitmc3c2SXBmRUZTMTV1LzlrVnVWL3l3?=
 =?utf-8?B?QlFFZDR4OFFDTmgzUFJQbk1raVVIOE01RWVLTlZydFFEcmFybjlReGpyazFj?=
 =?utf-8?B?Nng2ejY4UlV6Z0JUbzMxSS9paXd0Zk83MlVrNDA3bHRaRGhFWkRnZGlCdUEv?=
 =?utf-8?B?bEEyOHB2SzRMQWRhMlJJZWQ3Qmp4bDJPMmZzMnREWWNYaWN0QWg4ejBzRHEz?=
 =?utf-8?B?bVRZV3RxZzR4ZGdoelg3UlB3bmU2THFUSUFvSWhxbjlNbVYyYW04QXVXTlVY?=
 =?utf-8?B?NDQ3cnFrcVBlZTRDeU1NaGZtL3NtSWY1UWZlRXNNRXViNmFWSmU0M0RSNEV4?=
 =?utf-8?B?b1ZPT2pGZUU5ZFJicFg0RFVLdDd0THZMOThTMFo1dUhsWjRXUXZHakdKNnpy?=
 =?utf-8?B?TEpUdDFRcGVuQWZ4UTlvQjRqaEtRUW5qVjJzcUdCa3d5ZGxFVjNXdUNSbGRF?=
 =?utf-8?B?SjR6ZWtKdDhlZmZvUTZiQ004NDMwb2JFdTkxK0l6akEwNVBzUTV0V0VRVDBv?=
 =?utf-8?B?TG1rdDRUaVBGRUgzTTRjMFJMNVd4YWYxNE04VGZkb2xJeU1YbzRWVlZmLzg2?=
 =?utf-8?B?b0dkbjEvWXZTblpWS1BXVStSVWJJOGg5U1BnN2dUS2JNMG45UzhPM0NTeXd0?=
 =?utf-8?B?S0Q4NHpXMlJCbDVRaVUyU1orVllXYWdvUTlQRFNSTkhWY0wrWVVkb0ZiL0M1?=
 =?utf-8?B?Z0F6c2NpMTZDcWpJenFRM0NPZnJFOE40a0tQNnZ5ZGlWNUsrYUJoeVZHaUVn?=
 =?utf-8?B?aEw3cHgyYkwyTll0ZlBFRkhSQnNYTVYySEhYZHRxNHBsWjI4WDkwTG8xZURp?=
 =?utf-8?B?c1BRcE1Ha3V2Uk9jL0dqMFlndkVBaXFPQXJkbzNrSkRTcFRkelVNNkdTZTRY?=
 =?utf-8?B?V1AyWG9vTythOTNoYWFRSG5oQ2JrMWZuSUw5WEFxL3U0MEc3emd6YWRvWHJi?=
 =?utf-8?B?MEFnNWVtRWZxT1Y2cEFFSlBHeitvd29aTjNtZ3NUYVh3enZxdlZZbWdVZU9w?=
 =?utf-8?B?eld3SjhvRy9PaytLeU5uZ0tiRllocGk2T01QcS9BdU1IWnpqQlF4dVQyYlZn?=
 =?utf-8?B?eUZDUHNxKzFKUHlJN21Ta1NUbmpqaldUSFU4UXlQQmFNTG5tRE0weVFvdjll?=
 =?utf-8?B?anVBOU1sYmY5SDdKSUYrcU1pWXBUWHZBaHdPUjlZUTAzRmZzcGJCZHh3OG9L?=
 =?utf-8?B?TkhEZWRCUTVHQTR6N0VhSU1sRGdBT05kclBQOUZxQUhkbmoyaUxWdFVBeHEr?=
 =?utf-8?B?bTZjNUswVkdGZGM0SlNJQk1SZlEwakUvTy9uamFHVHlrSk11YWk4Y25zOW1R?=
 =?utf-8?B?UVIxdy92ZjZHaWxtTmN2MjZJc1Z3eDNHdTJ4TWRuWi9qNUlaY2phWjBQM1Z2?=
 =?utf-8?B?LytQQlNNdkMzWkFzcDRYTFpjL1VabHRncHpRek9zK0d6UmMvLzlwNzRzeE9C?=
 =?utf-8?B?WjhJckZZdnBkY200Q0lvWnpuemFIeTVpUzdGT1FNbnlOTVcxN29NNUc5Y2Nw?=
 =?utf-8?B?RkhNLy9hTXVLYVhzU1NIeUU3OHJDd0U2RGExZUpZYVlCL0F4amcxdDJzU3Iv?=
 =?utf-8?B?Tk1XU05NSnlnTXJseHlZY25YZWttRGczWGRIR2YzYVRWV1Nsckp2emZXY2Fl?=
 =?utf-8?B?UE1MY3VZTnJLQUhjdTFiZFZsSG1GalFQSWxpZTlpTHAzaXpnYnFJdzFEVEFq?=
 =?utf-8?B?K2tTUHkwZWxXaGpORUdpcndGU2VKVmNGS0FlRDRna3RkOUdRQ3BhMlE4NkYr?=
 =?utf-8?B?bW9LcVNKck93Y2R1WXNsVHp0UCtpU1dWbzQ5clBiWWdmdkdYSUhNOUliUXVy?=
 =?utf-8?B?Zk9YUUNmdFpTWFRVU3lSYkZQQytHemhpRTFNSEpQaEVocTBvaGR0dmFGa2NK?=
 =?utf-8?B?S09Jd1ZBK2UrYVhEVjZJOEpDV0dFWE9mekJ2a3lBdG1KcTZjR1RxejBvUzZw?=
 =?utf-8?B?VGdvUnV6MUtSNE9uM1c1M1grUkdneGZ4c080VlRXV3k2UUxzWGsvM0N6NXdq?=
 =?utf-8?B?c3RENjhnK2I5VUtFdGQwOWRFd2lUWWd1ODZUZ3MrbGlyNWhBRUJiTUszT09k?=
 =?utf-8?B?MWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e671057-c560-44fa-e495-08dc80082716
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 17:52:48.5326
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pxBsVWj3TwVM67yNdo3Qm8oESrw3Y0L855fxN79Wt5Zr+S/Hb2zNxN6wBkNOHBANr8yHgaYYjnDQ0nfyMGe/UtB1otYBsmgL2jE/jh3Lj7Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8195
X-OriginatorOrg: intel.com

Hi Ilpo,

On 5/20/24 5:30 AM, Ilpo Järvinen wrote:
> write_bm_pid_to_resctrl() uses resctrl_val to check test name which is
> not a good interface generic resctrl FS functions should provide.
> 
> Only MBM and CMT tests define mongrp so the test name check in
> write_bm_pid_to_resctrl() can be changed to depend simply on mongrp
> being non-NULL.

Second paragraph needs to be reworked because at this point
"Only MBM and CMT tests define mongrp" is not accurate.
Perhaps just (feel free to improve):
	Tests define mongrp when needed. Remove the test name check in
	write_bm_pid_to_resctrl() to only rely on mongrp being non-NULL.

> 
> With last user of resctrl_val gone, the parameter and member from the
> struct resctrl_val_param can removed. Test name constants can also be
> removed because they are not used anymore.

Imperative tone needed.


> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---

Patch looks good. Thank you.

Reinette