Received-SPF: pass (google.com: domain of linux-kernel+bounces-194564-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <328386e6-7cb5-4571-97ae-23a6d266c1e5@oracle.com>
Date: Wed, 29 May 2024 11:21:12 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mm/hugetlb: mm/memory_hotplug: use a folio in
 scan_movable_pages()
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, vishal.moola@oracle.com,
        muchun.song@linux.dev, david@redhat.com, osalvador@suse.de
References: <20240528220321.144535-1-sidhartha.kumar@oracle.com>
 <ZlZfHNkWHxtpcXhO@casper.infradead.org>
Content-Language: en-US
From: Sidhartha Kumar <sidhartha.kumar@oracle.com>
In-Reply-To: <ZlZfHNkWHxtpcXhO@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?eGJaQ0orZ0ZiVTBCYmNYckZINGhVci9YZ0NGVGpvRDVXTVkxTXZCNWZLWTdr?=
 =?utf-8?B?R0g2UkRvV3pMdWxSWmdNcm0xZ0MxaDdsNG9wSFFESXM0d2VWVTA5ZENqS2pY?=
 =?utf-8?B?K1o3RTVUREowbHRKMHZ6Z1p1NFNPcnhOK05LNDJpbGpyRG1NY3JzTytqQm9C?=
 =?utf-8?B?Qlh1N21yVCs0MDFkSHoyR25KeVcvcUkyY0Qwa1drS3NEWkhQWGgvM0NKYXhS?=
 =?utf-8?B?Q09xcFIwazZXbWYzWUdWbWQwR3l4ZWJvZk50bUdXL1pXSXgwZWQ0SkxZRjFT?=
 =?utf-8?B?OFVsTWJod3UweERxS2RxSnBvM21ITHZSejJvRnI4c3YyTm90UWwycnN1S0Nh?=
 =?utf-8?B?dUFxUEUwZHJwazR0dW5KT3lld1ZndjR2STVuS0RmSnBtb3p4YUVJTnVxWjJW?=
 =?utf-8?B?cXp1ZXh5RmkwRkpOcFN4bER4R21ocHlCVlhaNEpRckx2U3hSUWVuOURoaHQ5?=
 =?utf-8?B?eW5DWEF0ZGduRXZkditpRWtXRGwyUitOVkg3aW5SNHhPc2RsVTNjdDlma29w?=
 =?utf-8?B?OGNoSUNRanNERFFPZG5SOTZiU2VtUFBkUkJIMVFEc3BMOVN2VmZ6bzMveHVN?=
 =?utf-8?B?VVJIRC8yTEJQZHQzOCtkS0dObE13ZjRtQ3VjSjRFT0p0bkh3WGlyVzBMcjc4?=
 =?utf-8?B?Mis0aHdzLzRLMVEvTWdjamY3Q1FNOWpKTGxuZUNqMDB2ckk4aTBBMlloWktN?=
 =?utf-8?B?Z2FweW5TT2RQMURmenhKMG9WNGxzMVVtV0lOc0FnOEY3cmJWY0xRdFh3OEd4?=
 =?utf-8?B?WXgrRVNFTDBSZm1ZY29OaFZJTmp3SHpRUlhYSTRzTDUySzBsVjVpS2lMR09q?=
 =?utf-8?B?a0JIN0M1M2ltbHp6YUlhcW15R0tXYlM2Q3FycUNLZXpUMWdhM2VPc3lCSHAx?=
 =?utf-8?B?MFF6MXRGWlR1UzlJOTgyeFkrM29vRVlLeHlKYy9kbG9RTjFvNE1wakhwN3Iw?=
 =?utf-8?B?ZGdHV2Q1OGJIemxXQ3Fac2t5TkxmdTJ3RWFVMG9sVzhFSDBoVXRGVktwQ2V3?=
 =?utf-8?B?bGtJd2JaWEo2SlJOeEUwSUtoNm41dnFKdDRsVWNZYTFYdG8xT0FrU1VoTE1J?=
 =?utf-8?B?SUhEQzlpLzAwQmFWN2VwdkNmRndGM1EzbEkrbDBFaVF3c2FQQkRTSWR4cU16?=
 =?utf-8?B?QTh0Y2VtcmVLazlKaklVdEM5RE4vYmllUHlDS29ib3BJSXRud1pPS0VxdUcy?=
 =?utf-8?B?anBFM0I2cnYyeUZXY0toMzJIMkV2R2JKUStsc21kQ0lVVlJYQ0NicWNzNXpJ?=
 =?utf-8?B?L0FveitJNFU0VmdYUDRFWGlWRGhpNTBRdEpCczdPRlpEQ0JlbHhLUXVnNWd2?=
 =?utf-8?B?T0QvaEVDQ2JhMkoxSG93V1EvZytJWndDeUVxTWxDNHlzWG96UmdIV2QrOTdW?=
 =?utf-8?B?eVRuV1lhMVdnL29Bb0VsLzRQT2doKy9QVEtITkxBSnNTUlJJOXJTdWF4azh6?=
 =?utf-8?B?c2Z3Q1RseUFFZmFpS0JSUEFXelFBeEpsRFVwNlU0NGxvV2pwT3B0WEw2S0E0?=
 =?utf-8?B?cHk2VGhQRWxSemwvM3hvQnBod3Q5a1QrU0xQWUtWL0RBVTQ2cVRHeGlmL2J2?=
 =?utf-8?B?TC9TUVZoMUZZL2NZbTJTb05KN0FHa1ZxTnd5NE1FSHVBcFBJOWdXbUxsZjhC?=
 =?utf-8?B?R05ObVNvQy9nZFY0YVpISEVKU2tQRlNFZ21Od0xqMGE0VkI5ZU5GdEdveTRR?=
 =?utf-8?B?aU5GWDJWbjhWdHdoN2RwUXdPNUhSUFE0blYrUC9CdnRKWFEvcVBtN1k5OENQ?=
 =?utf-8?B?RnhZYnBYN2FCbVJCc1FzT0FMOW9UN2lQQ0dUVXg5NkFEd2ZHbUFCVU16T2NQ?=
 =?utf-8?B?SGdXZjhjS2tUZ0MyL3k5ZGdHZlBodGFxK2dyTVhDdVBJcngyRUxXTENqQlpX?=
 =?utf-8?B?aEppdDZMaTArek9XVC9kU00va3dGSms3SW41VXVlV2ZnZG04WW5Xc3lTVVd6?=
 =?utf-8?B?MWdEc09kTVhiV1R6WXIwMXBjM2EybGFxOStTTUtyQ1BrQS9aVGE5TmxNMXRF?=
 =?utf-8?B?R3hQWDNPQTVpenBjSnhFakpHRXNqckxkOHk5ZStFa3krNm9LcWRTOXgzRGZR?=
 =?utf-8?B?ZG9VMFZCRkdXelN5b3BFc1Y0VCtST0l4Slh3aGlRMzNzNU85b0NOL1JxcVZT?=
 =?utf-8?B?QkRDeFFCeDhSM2VRUU9FeEplcUQ5VGtubXBRdERLQk1xZ1BNRHNXMTMyWG1t?=
 =?utf-8?Q?EKRz3Mq+prteO3s0PirQ1oU=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	AYZmrdOTZSFYrZ/wxBpdWOBr375cetUpWkmFJLqZBfzMUgcDgstEs+n59rpnqT+2aS8JsSUk/KT1B8AKLRaukwNu8005gy1otmOsmbUKq65xcpcaUcseoVsDdm5bUkKGms2zmMIEDM1w/fyA/tRZuDAXo6TtlxJEFmNh9eRBhKtYA6lWX8OO0QIFzF8fEYn6bs3t67qnWHTgmoCpJ0kk1lBgZRi0ZAbPik3YyZouvEg7nQAR2OujAT3rByb7FSYk0ESbVZNoUkR316IK4xC0Zbo/4tVlXGojX5OAlsLBRO1DWjC0YBJ+Hh6jh3ApWrZdnuwSWYL8ksLjyBhzpoK/vZGW+tpPuqMkIf5r4UgiISJ83HjprSvONb1r5pfAictDYySiiFAv2K0CbZRhxl7IMOBSkP+z9sP2X8NF558qG4pwuBHfhCHhF13LnduF4zRwxA4HnMwVr/syh84aKLUYHTI7t0K7DCKRZ6DXVS0rUA3kvrX+gMUhtQXJbPgLTw/dDlQ4eZ05YhoSjdBH7WSoM8y3/LT8ep7huiragn7hqVy7dXDvbpGafQuBIuSQ3Ng7PtdcZBdnDnzzOg5Xmsm07wdzNrKE+tJ0w3Icvk5v6tE=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9422293f-4b0e-4817-3a6c-08dc800c1fee
X-MS-Exchange-CrossTenant-AuthSource: CH0PR10MB5113.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 18:21:14.5803
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GaNrMX3AzBRM5FbFpqqYoXKxoMA+veerN4atNqH9lUdaOeZQrZv8Dh9YE/Vbtm85uU7k/aCfwqdZKvqm9RV3u6twxPwu1pcLRZI3oTYzk04=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7155
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-29_14,2024-05-28_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0 adultscore=0
 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405290128
X-Proofpoint-ORIG-GUID: EKVYs4TeD3vSQtan6OwNDxkIA-QsO2w_
X-Proofpoint-GUID: EKVYs4TeD3vSQtan6OwNDxkIA-QsO2w_

On 5/28/24 3:47 PM, Matthew Wilcox wrote:
> On Tue, May 28, 2024 at 03:03:21PM -0700, Sidhartha Kumar wrote:
>> @@ -1761,9 +1762,9 @@ static int scan_movable_pages(unsigned long start, unsigned long end,
>>   		 * cases false positives and negatives are possible.  Calling
>>   		 * code must deal with these scenarios.
>>   		 */
>> -		if (HPageMigratable(head))
>> +		if (folio_test_hugetlb_migratable(folio))
>>   			goto found;
>> -		skip = compound_nr(head) - (pfn - page_to_pfn(head));
>> +		skip = folio_nr_pages(folio) - folio_page_idx(folio, page);
>>   		pfn += skip - 1;
> 
> Isn't this an unnecessarily complicated way of writing:
> 
> 		pfn |= folio_nr_pages(folio) - 1;
> ?

Because folio_nr_pages() is a power of 2, I agree this is simpler. I'll make 
this change in a v2.

Thanks,
Sid