Received-SPF: pass (google.com: domain of linux-kernel+bounces-194565-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <f3474dd2-170b-4471-84ae-de3e9f1cf8ba@amd.com>
Date: Wed, 29 May 2024 13:22:48 -0500
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH] mailbox: zynqmp-ipi: drop irq_to_desc() call
To: Arnd Bergmann <arnd@kernel.org>, Jassi Brar <jassisinghbrar@gmail.com>,
 Michal Simek <michal.simek@amd.com>, Saeed Nowshadi <saeed.nowshadi@amd.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Ben Levinsky <ben.levinsky@amd.com>,
 "Gustavo A. R. Silva" <gustavoars@kernel.org>, Rob Herring
 <robh@kernel.org>, =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?=
 <u.kleine-koenig@pengutronix.de>, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org
References: <20240528120246.3313723-1-arnd@kernel.org>
Content-Language: en-US
From: Tanmay Shah <tanmay.shah@amd.com>
In-Reply-To: <20240528120246.3313723-1-arnd@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TUJsTDA5NUZSc1g5b2pBbkJBai9FbkdaOVBEalMvcHkxb3pINUV3T2wvTDAx?=
 =?utf-8?B?SjZBRVplVG5wU3NXdllEUStvK2VJWURiaXRPTldpbTJpeW5ETWY1cWdyaW9w?=
 =?utf-8?B?dmQ2MFZqZGNWU21nOWk4TmdyeEVYS0wvQU1oUlZVUGtEMCt4aGIzTXRmejk3?=
 =?utf-8?B?Z21hR0VPQytmR3dtOENTTXk3MW1DM0o0Y0FOeXRhaldrNVVHZjBKblQ2MkN5?=
 =?utf-8?B?TFViQ3dxd0dyVG1abVE5K05sQWlwQWdFM1QybG5qd0lzUWtQL2VTUlRRYWNm?=
 =?utf-8?B?WUlsVG0vT0JtQktVSWE3RTdxZVlHZU55MUkySWFNYWptU1lDS09OSUFNQm1Q?=
 =?utf-8?B?ZzRtWDQ1bCtwVXQ0ZWNoUUdkK2h1M2cvOVd1VVl2Smx4UzZZREhmcXozTWdt?=
 =?utf-8?B?dWxFaTI2QUdDQ2xiNmE3UDhuNVpRT25CMmlGZWpKZCtham4vZC9hcnpoRXBl?=
 =?utf-8?B?WHQzeDY0KzdXR21rZDdPemxRcU9IVVBpVFBzYysyRDhnQWRka0lHN1l2ZjNx?=
 =?utf-8?B?UGlXdTB2U001OVBZT2dsZDBWUE1vY0F6MzNSUTZ2c3lNczlVbUtWUEl1RXRV?=
 =?utf-8?B?M3NMS3Zobnk3bTFWZG5HY1c0cEkySngrTWZ1UE9PUjdWZlJCaUFiSkY4ei92?=
 =?utf-8?B?NlVTVlJ0cldudXJWQ0xjNDh6S1lZVWxhbDdNNms0cVVvTDUrSjFNdS9SZ2s4?=
 =?utf-8?B?NkNrOCtlMDFLbFZYWklBenVBTENiRFFoNkZsOExEekJ5NlJkN2FJWjFMY2lF?=
 =?utf-8?B?QktHOHBVZndyUHd2ek1ZSXNsY05nT3dKdzFrbWwzcENENXlLdzh5QVp0R1ov?=
 =?utf-8?B?bVBvRFNTcWZ3bGtGbnp3UWQxT3E3bkZUUzc1Zlg0bTBUK0lMbm83cmFZc2Vn?=
 =?utf-8?B?RjQ5OWJwYXpvYkdzU3JhWWpMQXc0VmVUbGtDSTY0a0wvTDZnMk9OeC90Qk15?=
 =?utf-8?B?azUzRUIxKzRPTE9sT2VXcXdFVUFwR2NuK0tCR1NQM1VOd1VHN2o5T1pEYm85?=
 =?utf-8?B?U2dIc2JwR1liZTlLYTZyWWhkbEFNc25wN0FBMTlGamlsWXB5KzFkSHVvM0I4?=
 =?utf-8?B?S0J0U2grMC9FQ3VINGhseTc0UVM1c0NwU2E2MlY3bGRhZGczc1dLZmhvN3dr?=
 =?utf-8?B?YWxuSjYrZFgrekFyR2N3a05iZW9rNkozZlRNYmtmNFBwS1djVm11ZDBtS28x?=
 =?utf-8?B?TXBZeDJxRU9KV0RxdXM3UjlZN1c4L0JyUzh4aTd1dTNucEx2K3FzWUF0VktK?=
 =?utf-8?B?c015S2twOWoxZ1VqeGpST1RFQ1BSdTBuVHo0MWIrZVhzOXVCVWJLUjBseFdu?=
 =?utf-8?B?eDlka09KZUtkRU02Y2VaN1JMRW5VcHF3anBPUC9zcTE4Vmh3eDhKUy9NZDdT?=
 =?utf-8?B?ay9ROVdVNGZsTnBPTkJtNFJrMmN3RDI0U3Jka3BldWZNY0tMYUdKbFc5T0N2?=
 =?utf-8?B?eklJQzl5WGVjZU1VNmVWcW5lUzlObXdNMUxvMVk3dXRzMnBzbXlpSTNDdU95?=
 =?utf-8?B?OGdNSndGWlNKRGNzSHhSa1VXVTJmYmtCM0I0NmxXWS9SK04ycU1qN09iM2lO?=
 =?utf-8?B?dGNsL2JlY0NWYXl2bkp1dWsvU1ZMeDU2THJhYkZFTjFxRmt1NGo2anhlWFZN?=
 =?utf-8?B?Q3hHVENob1pET2dieTJMVDYrUURHM1VZREw3S21CZ0dLU216ZEVSZmptMTRS?=
 =?utf-8?B?YnFPcjFFNVUrZ3NlNTl4VG1zVnJhR1h4aElsaFZIMG1Rd2xIMk1tRUpENTBu?=
 =?utf-8?B?QVJCNGltaU1UcTBrRXZ5QTNjaDlKaDF5ampFdS8zZU9IU3dhQURwN21wQk81?=
 =?utf-8?B?UEE3VTZaRGkzYVdQMjI1RDVWeVU4dXl6Vk1CZTlNZTc3M29LVC84K011T0RM?=
 =?utf-8?B?VDZCM2RsNmptc2VWTVhlNm03eUlUMlFGWGRlNHo2NkY1ODBsNkdISUVDNEww?=
 =?utf-8?B?d01mcHMwVThUZ2Q2U1FNYUVBR2tuRFMzUzRnNTVEYkVIbDFuTFJzc0lIKzAy?=
 =?utf-8?B?TitrTVlmVDF3NDUrYWUzMGpCQmxGdVA2b0FQZUQ3MGhNL2FRZ085d3Ewd0tK?=
 =?utf-8?B?TmVUQkpieHZYT2czcnFoc3M0OEUyenl6NFc3ZXZVM1g2SkVaVzdsNktvRjVR?=
 =?utf-8?Q?uMp+ORN8jKULgvu56t7MJYSli?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1bb09f2-4a8e-4ed9-d2a5-08dc800c597d
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5874.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 18:22:51.0477
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yz1mdzqOxNz5NK+QmK3XZy/36c69UvGZmGMrfDYuxfj1Z1s5J4BmQSusZQTtH6uV
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB7665

Hello Arnd,

Thanks for your patch.
I am okay to remove it. I will test this and provide TB.

Thanks,
Tanmay

On 5/28/24 7:02 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> irq_to_desc() is not exported to loadable modules, so this driver now
> fails to link in some configurations:
> 
> ERROR: modpost: "irq_to_desc" [drivers/mailbox/zynqmp-ipi-mailbox.ko] undefined!
> 
> I can't see a purpose for this call, since the return value is unused
> and probably left over from some code refactoring.
> 
> Address the link failure by just removing the line.
> 
> Fixes: 6ffb1635341b ("mailbox: zynqmp: handle SGI for shared IPI")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/mailbox/zynqmp-ipi-mailbox.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mailbox/zynqmp-ipi-mailbox.c b/drivers/mailbox/zynqmp-ipi-mailbox.c
> index 7c90bac3de21..4acf5612487c 100644
> --- a/drivers/mailbox/zynqmp-ipi-mailbox.c
> +++ b/drivers/mailbox/zynqmp-ipi-mailbox.c
> @@ -850,7 +850,6 @@ static int xlnx_mbox_init_sgi(struct platform_device *pdev,
>  		return ret;
>  	}
>  
> -	irq_to_desc(pdata->virq_sgi);
>  	irq_set_status_flags(pdata->virq_sgi, IRQ_PER_CPU);
>  
>  	/* Setup function for the CPU hot-plug cases */