Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp828063lqb; Wed, 29 May 2024 11:39:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU+hxp4Vj1l1ZwdAjElYIF5T6nmtbm0ENb1/c/pl44BdkRZtpRjorArc3R4O+SPKzwR58zPz6xjRUfSq3NdeS8omKZQDt0HJAKevwBajw== X-Google-Smtp-Source: AGHT+IHir3aigEqAPnUbKZ5wItH7vmrIAcNyTF6JfhZQ/KhQT9WeHkRlgZOzEvdrUJjNXtWOxi6S X-Received: by 2002:a05:6214:469f:b0:6ab:8fea:9bc1 with SMTP id 6a1803df08f44-6abcd0fbf17mr236563206d6.53.1717007986799; Wed, 29 May 2024 11:39:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717007986; cv=pass; d=google.com; s=arc-20160816; b=uDslvH9xXkD+WEJe2F5rcRTxFCWQUI7N1Bo4CU3S6STxgNzQ9ZwYggGYvCE19iD5tn WZB2bMyMLQU42rUwWaqR6W6aGR7EpwifN6b6LUeA3rCvK5OpvDT0Z1uaeYOlNGdbDlkX jzElCNbpccNTrY6VjAo1qVfo6wmyLuW1EWrqqgajUn8RhuNWh9UEuuJMxihIe3XR2fRE 1nPJz/diZ9B62WYPO/oBbBoZrzR/xf4283+17qJp55u55Mo+/rqglgWU0Vf7KtbZE/Wh QW+R6xv14VJJmv2qYgAHeG+NSu/cI7Jx+YzONaXYZL2l03gpyZ++tYona+mpWKUreZ09 tinA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=82u73bDkwEpL4j6qISSAOBsXkoJJqmYHvq6lf+QJZP8=; fh=bEbTCaPBMpa596EGMGkpNZmzkF1bSv8LKcFY3r28Lt0=; b=hkwjn5OufygTYcFPcPna6sdIDUl1/5WHxwfJ7NprW2BIIBo0npRTFBI1pQYibVUxZj Vw+VapIpHwmdo8MXSDzv5eddHfF8jN8OJ93zfdaoRb+xz1Kj7SuNIvnpjFx9ye6pA1kz OuNzOWw2ptFk1oxHnXmXIKQXzp3iobxfd4MZSRs7DcLwfgFQh3rvmBdeBkQ872MaSyfN kBigdboxbVRG0eK5B+9NnzFFwA87lH2++d/6gPs1cQkSRFeeyTzTvs6R99/J8nZX3dTl LMw+6Jm8WCnpa2uwfiUrZpVQBI294ziBiX/13Pk87qSCtWBJs6nhzdNZjL0WTEPSu/+B 1f5A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lv+48xcG; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-194576-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-194576-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id 6a1803df08f44-6ad7592ed4esi100394676d6.400.2024.05.29.11.39.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 11:39:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-194576-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=lv+48xcG; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-194576-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-194576-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 862481C21A69 for ; Wed, 29 May 2024 18:39:46 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id BDEFF1C0DE9; Wed, 29 May 2024 18:39:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="lv+48xcG" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FB7526286 for ; Wed, 29 May 2024 18:39:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717007979; cv=none; b=Yv+yXoJAiAHYgOoj+B8VWA6tj6xyX2N6GOs6RwCBnzoZG6HyhJ20TkW1ue28EahD89bWFWv0uRLC6v8MdTRQzxLAziYd6WQViYZt9exn0d9mPf0DZ5Kn6bbYzY+f+GM/e88tsE5e9NvR49vuldh48CxKDuqJ7q9UW2/qnnmm1R0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717007979; c=relaxed/simple; bh=CNvdaWG9fyNXV+XrVbGhthLEVOJ6Jk5dnVrf2KJ+fPY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jeByTwE9F9fL9WwPMwdH2IPLxVZrfKDUwnUVr9uNsSubsFGGwKIOnXySZhKOpfcsfujUiWHOk30bZk+JJI4wMBwPvsY9UACiDp/InJEGoXlEDPG/WQNtsd+caIAjWKoNXP77SdpwyX3jbCyJxjHWW5LmqEgGC5e67frHUoHfXhk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=lv+48xcG; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1717007978; x=1748543978; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=CNvdaWG9fyNXV+XrVbGhthLEVOJ6Jk5dnVrf2KJ+fPY=; b=lv+48xcGEyHKoF4vBjolgLO/Jj+KyAxfs4MPkEPWwF8Ks8B7nySydFnT GfK1Kil2UxSC/hVvuoYAOxgukjt2rNLmoz7tqk2BTSeBfCBEN//GmNhM4 XDvDzwYMASiEvT8TpVkAF+3xGiNOVfIWBqJfC7dFVqfatHxaCHcc1dIib 3kYyc2gR8qSM5W0WKSvKehOoBcGytz5nkLFL+fSDDCVfTBanxsiZWNF96 ugD1kITBpPmH1zWpm9ZS1aNN+qm34ko+CO7d6N+FxMwbmFSrbz54ucKFx RELDAZmFgrybRFUhjaor7mpb+KR4UOwQEQKJeQGa6WzIT/GqUSJtFJ0Vj Q==; X-CSE-ConnectionGUID: P51ewUtXRS22Rw0xMjjmvQ== X-CSE-MsgGUID: Tfgf0oqZQWyBZRj/c5OkHw== X-IronPort-AV: E=McAfee;i="6600,9927,11087"; a="17264808" X-IronPort-AV: E=Sophos;i="6.08,199,1712646000"; d="scan'208";a="17264808" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2024 11:39:37 -0700 X-CSE-ConnectionGUID: nUu9drqARRONXGdQIsNZPQ== X-CSE-MsgGUID: 5JRZQE+cRTCzexlN2ol/bw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,199,1712646000"; d="scan'208";a="35465590" Received: from kinlongk-mobl1.amr.corp.intel.com (HELO [10.125.111.96]) ([10.125.111.96]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2024 11:39:37 -0700 Message-ID: <8ef9d8ad-9236-4254-b819-50832cd05cd9@intel.com> Date: Wed, 29 May 2024 11:39:36 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] x86/cpu/intel: Drop stray FAM6 check with new Intel CPU model defines To: Andrew Cooper , LKML Cc: Tony Luck , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Ashok Raj , Alison Schofield References: <20240529183605.17520-1-andrew.cooper3@citrix.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240529183605.17520-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/29/24 11:36, Andrew Cooper wrote: > The outer if () should have been dropped when switching to c->x86_vfm. FWIW, we are going to need to do a pass over all of arch/x86 looking for these. I suspect many of the 'if (c->x86 == ...) ' checks can go away like this one. Thanks for finding this one, though!