Received-SPF: pass (google.com: domain of linux-kernel+bounces-194593-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <06380175-c258-4112-8cc4-4420b2860e7f@oracle.com>
Date: Wed, 29 May 2024 11:58:12 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] scsi: qla2xxx: remove unused struct 'scsi_dif_tuple'
To: linux@treblig.org, njavali@marvell.com,
        GR-QLogic-Storage-Upstream@marvell.com,
        James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240528215640.91771-1-linux@treblig.org>
Content-Language: en-US
From: Himanshu Madhani <himanshu.madhani@oracle.com>
Organization: Oracle America Inc
In-Reply-To: <20240528215640.91771-1-linux@treblig.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?dk9GNC9DR0xFYkFMWENDZXgzR0xDcUUvaHhEMXJ1aG5yeHNrZjR0Ui9QdFow?=
 =?utf-8?B?V2pRanRMTko3WlRJUHRQMFppK2NVYTVURm9VYUt3VCtqUFowYzVNckpIMXV4?=
 =?utf-8?B?MHpiSWFYb3dqVnBLZFoyOVFKQmpBbjhid0thV2tuS28wVjB2dWFsOURGaE44?=
 =?utf-8?B?R21HTk5wQjA0LzczbThpUjhQdnA0ZEFEUmx4ZGp0L2F1NGp4SlNHMHh4bUFh?=
 =?utf-8?B?azFzeTlGZHNESzltT0ZmKzRVK0VJclp3RjlzNlRWYVVsWXVKcFhzL3FlL0Jh?=
 =?utf-8?B?RjIyWVY0NnpCb2Y3dHpBMDNOWnBXU0dPeXRjRzl0TEo4cVd3WS9hYXl3SDFT?=
 =?utf-8?B?d0o3MlNaNmdEUSt2YURMMXhlOXJwaE05NTkrc3d6WmtQSzBIRkt4cGFKT3lH?=
 =?utf-8?B?QUhRdmVIOHY1bE5WeklCVlNKemxXNmQzeGlVb3N0blBMWStWMFZmcWJtTTRI?=
 =?utf-8?B?bHJhdTVJV2VpekUvaHF2aW9CcEs4VWY1bkJ2NEhQcEwwTVRUVWxjN3RsZHlT?=
 =?utf-8?B?VGdzZWIyRnlBZEtURFUxMEdZQmpkR2kzNXIxQ2tWNGhDMFBzdlo0cjVWbmF0?=
 =?utf-8?B?Q2I1Tll0RmMxUmx2NWxSVmNYNVBUeUdxSUJDby9jamZVNWptRm4yaGNPS2Ur?=
 =?utf-8?B?dWRZbEYxTFgyOFdtUW9HWFE2RTRQWnBYUUVXVStPODNrRitWTys2R0lBcm5Q?=
 =?utf-8?B?dUZsZkdvMkoreldzdjZ3dlFpU05kNzZGR29rLzBWVGNJSDFKdGlOOFhZaFRW?=
 =?utf-8?B?ZXJMWURycmtyZzV4UkVuNlZod3pnbHBsbnpqbFRsTktRWHpCVjcrWEg3eXEw?=
 =?utf-8?B?Wlg3WEs0YXFNZFd2a0QzWUFpSTM0Z2Y4b2tCM09zRGVRdVNOVjQ0eUw0SzF2?=
 =?utf-8?B?N2pEZys2Y09PK2VaLzBsc0JnazNQaXN1SGhBdWZCcmwvTERoNTJNQTFsdUht?=
 =?utf-8?B?c3F5azhsb1I0MW5OVS9iajQ4ZDg4R2NpNWJnUkVDMkVqSVBGRy9PNEpJMkVl?=
 =?utf-8?B?dEFMeVBXaVB3RW05YldkWEdRY2Z5ZldRVXdXS29oVi9Lem1EYnBwL3M2aklN?=
 =?utf-8?B?Mmc3Mjd4VDR6Mm1pUDVwSFIrcmRsSzhROGx3ZDJPeEF2ZnFKeEoxcnBzTlF0?=
 =?utf-8?B?ZjNDTjZvdmN0Rkg2ZjJDcGkweEVLN0EwRW96MjJWNFpWRll5cGFzaStldW03?=
 =?utf-8?B?ZUtsS1dvNTBCTmdwMDBFcWIzVUphSkhDRmxvSU9WR2dEQ251ZVZwK0Y5YUF1?=
 =?utf-8?B?c1BvVjNaL2RZY3hmYlZvNWVDekFSdGU1UlZwNGNTN1Z1WVZFL3RpZkdiSVdJ?=
 =?utf-8?B?V05DZjhxVlUrL0VTMkc1TjI1SXRBSGUybmJTWGc2T3ZnamdmdFkza3NXdjBQ?=
 =?utf-8?B?ZndCSFVFbFluSHpOaG5XM3BrSFhTVGE5bWptenRnSy9TSGtIRkxsTzJzcGxl?=
 =?utf-8?B?SXd1ZGFYa0M4K01LajZ4dU1TNSs5Qi9kbWJCZjVoMkNPSlVYcWFkQmU1NitO?=
 =?utf-8?B?VFhqVktZTmlYdXZ6NHpwYXl0Y0ljYjR3VG1tVnZqdlJZNFkvcGVOOHVXMFEr?=
 =?utf-8?B?QU9YRVZDSVBrZVBySmtNTExBVklXQ1N2UnZuZWRlb1NtZGdnOTZweGhBWFd2?=
 =?utf-8?B?TVdNUHVVQXJRODJMVWRmR0kwNDlYbGdpMXhPOHhaaEtyTTBWaTFmZUk2bG1X?=
 =?utf-8?B?UGd6bTZwMnlrelAyMGpUeDM3Q0IrK1VzWk9mL0dlTzhyR2lKYmh1Wk4yZ1pN?=
 =?utf-8?B?Y0dvd3h3Umx1TGtBUFMvYTRUZ1BqYzRvTFZ6emNUZG03K255K0FTSkthSmd4?=
 =?utf-8?B?dHM3SStsNEhGRWZmM01UWjgwQWI3OU5ENG8zZ0IweW5YMXNMZ0FZVFhrRFpj?=
 =?utf-8?B?N0FnNEQwM25MR0FUNDhGSCtobUEvL2h3aDVFckhTMC9TbjYyZjR5RmI4M0JF?=
 =?utf-8?B?azhXQXVSVkJkWndSSGlkeUlFRUpsZEdnOU9oaldSNjJZWGpYdjEzS3d0aFlV?=
 =?utf-8?B?WERoaFlmMEJ4UTNrWmlyRTZ5Q29xei9RWGdqSDlPSXpXTXdoSVFOR1ZqT21o?=
 =?utf-8?B?UDFmdTR2VElOaWU1WlZhUG5pK1ZXSVNWMzZRSy8rWVFFRHJ3eFgzSjcyekRu?=
 =?utf-8?B?SnlZYVhtaXNYZWRVVkRGQTVwcjBORlVUM3VzL3ozN2Fvd0tVWXVhenQxc0Za?=
 =?utf-8?B?WGc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	j+MH2azhUoEFj1eKL/7H4kot64FC+Gw6h43sXOZACQfKBzro+fEVjTt/jwWTgVM6LUyGw1LOBIr8JVYXdpD6wu3Lpp38HmfDuAqiGsSlFNYC7epbXG9KC8Lzszq5VkEENDu1tXAt+dktqGCtrNKdL7KblI93CcWcSFxdNBX4FwW7SuFkZ5VGE5xkJb1uuY/1gd1t/FjGw7JaQjBIQM9gxnnU3Xo5ygq5814e5+B2NVzKi2xSJep74UXjcc8IlMwK+fzPLN02NO3Mwy+SSSQDZrgLlo4WjoM+yY9NqKl/a0LMIY1v1tGZuFdE3rUCRgmNI3oPu0JhZiePP3ZxKk5k00udZVtgd1lAh9saNpiv4MramK4xXlBVx+TjwM6Jzc6wmqfTiliRCtoemtYCDOBVNLhQofoPqrfnIrHQP2Iq1t7JxJyUTBu++BfHd8p0+Hj1/UKqdj0MMqGrO/casgNIQheF0GtRtkzh16Rlr2y+tsI9cZ8Ly0ewtXZ+1LbU0KaNlzWu+WzCvkZc8oyvQqktnQaYvjBCyXN5FgcHOHQPNvZ0DmOg0VhJTGcxpTl9k40r3N/Ytd0rRVUhwfZP8MufbxUuPMAbwcVZZxxJFyKElJE=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3b5373cf-a5ff-4258-06b9-08dc80114b93
X-MS-Exchange-CrossTenant-AuthSource: CH3PR10MB7959.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 18:58:15.2691
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uTKlvRjYfNipuK33jp35uknh6stgok5ahdnEX1KzeCLHEK+o/f0C5c2YfLkQYJ714oQ0SNR7+WvP1FHZjVgyjexSmd0QjJK1btqC4XG8OVQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB7242
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-29_15,2024-05-28_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 suspectscore=0
 adultscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405290131
X-Proofpoint-ORIG-GUID: Qk6EbECUYQ__YOUYSm64WPaujvRw8VFn
X-Proofpoint-GUID: Qk6EbECUYQ__YOUYSm64WPaujvRw8VFn


On 5/28/24 14:56, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'scsi_dif_tuple' is unused since
> commit 8cb2049c7448 ("[SCSI] qla2xxx: T10 DIF - Handle uninitalized
> sectors.").
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>   drivers/scsi/qla2xxx/qla_isr.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index d48007e18288..fe98c76e9be3 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -3014,12 +3014,6 @@ qla2x00_handle_sense(srb_t *sp, uint8_t *sense_data, uint32_t par_sense_len,
>   	}
>   }
>   
> -struct scsi_dif_tuple {
> -	__be16 guard;       /* Checksum */
> -	__be16 app_tag;         /* APPL identifier */
> -	__be32 ref_tag;         /* Target LBA or indirect LBA */
> -};
> -
>   /*
>    * Checks the guard or meta-data for the type of error
>    * detected by the HBA. In case of errors, we set the

Looks Good.

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

-- 
Himanshu Madhani                                Oracle Linux Engineering