Received-SPF: pass (google.com: domain of linux-kernel+bounces-194621-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <63d35ddacc113598f1822486b882552a.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <ssnyujhgz64mbxawb43okjkdidd3tbxwjob36ikgbogy64xuqv@ckvir5vfqo63>
References: <20240528114254.3147988-1-quic_ajipan@quicinc.com> <20240528114254.3147988-8-quic_ajipan@quicinc.com> <ssnyujhgz64mbxawb43okjkdidd3tbxwjob36ikgbogy64xuqv@ckvir5vfqo63>
Subject: Re: [PATCH V3 7/8] clk: qcom: Add GPUCC driver support for SM4450
From: Stephen Boyd <sboyd@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Vinod Koul <vkoul@kernel.org>, Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Taniya Das <quic_tdas@quicinc.com>, Jagadeesh Kona <quic_jkona@quicinc.com>, Imran Shaik <quic_imrashai@quicinc.com>, Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
To: Ajit Pandey <quic_ajipan@quicinc.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date: Wed, 29 May 2024 12:48:14 -0700
User-Agent: alot/0.10

Quoting Dmitry Baryshkov (2024-05-28 06:23:27)
> On Tue, May 28, 2024 at 05:12:53PM +0530, Ajit Pandey wrote:
> > Add Graphics Clock Controller (GPUCC) support for SM4450 platform.
> >=20
> > Signed-off-by: Ajit Pandey <quic_ajipan@quicinc.com>
> > ---
> >  drivers/clk/qcom/Kconfig        |   9 +
> >  drivers/clk/qcom/Makefile       |   1 +
> >  drivers/clk/qcom/gpucc-sm4450.c | 805 ++++++++++++++++++++++++++++++++
> >  3 files changed, 815 insertions(+)
> >  create mode 100644 drivers/clk/qcom/gpucc-sm4450.c
>=20
> [trimmed]
>=20
> > +
> > +     /* Keep some clocks always enabled */
> > +     qcom_branch_set_clk_en(regmap, 0x93a4); /* GPU_CC_CB_CLK */
> > +     qcom_branch_set_clk_en(regmap, 0x9004); /* GPU_CC_CXO_AON_CLK */
> > +     qcom_branch_set_clk_en(regmap, 0x900c); /* GPU_CC_DEMET_CLK */
>=20
> I pinged Stephen regarding these clocks. LGTM otherwise.
>=20

Looks OK to me. I assume that these clks don't get turned off when the
GPU power domain is turned off. If that's the case then presumably we
would need to turn these on and off during power transitions.