Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp878562lqb; Wed, 29 May 2024 13:22:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWHCle/ubOuqOnpct0/AYNMZyXc5j4neYRmWE8bE+Mki7pxduv6qPsJIt7xa+S5HzEigV2JL4LOY8RYuw+rAvFDCx16iWBk14pbyAs7MQ== X-Google-Smtp-Source: AGHT+IFlptMjAHDkOV8k4sJ/RuyumyLczVwyQOWx7jK7wHnSJS40aS9V5qQvnLv1KLr8Y2g2mHec X-Received: by 2002:a17:903:1209:b0:1f4:5f6f:f05e with SMTP id d9443c01a7336-1f619839773mr1099475ad.57.1717014158984; Wed, 29 May 2024 13:22:38 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717014158; cv=pass; d=google.com; s=arc-20160816; b=uZNovOU8vNfxzSnOWWx2nuOdM9db096VTjl2K2BaAvJ4/7BreBjnQr5NUkdyel7dEY K88Cna2289TyL2Y68yE+fG9MrqNhOjtitaXvX1/kXqT9ZwZGRPYd/95h5iexXWO6nyo3 4Zr1jfrT39QbXf7jJ5XvXnbUyy5JVADUiCEma3Bi+4Y4NFjIdaBqWpgcEIBK12iBJbao r6ail18vf4DRlMz+RDHfA3bxrqK+UbI+iiH3DFBRUb00AQKFMJAUljz8C8P/g6I3UDtb MxRAHuYkAESiedOITwjAmQoieJgNadh7pJ8HGMpWPXpXFP/h7ommWYHwao8Q/QZ4z/j5 I/MQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ji6jBdkqbxFp+OuQ43Vad4Fu8h64VsKVi9xqFhSvyYA=; fh=3z/eYU4SSfHO5L6wPGiyUu+y7LtPn9diFUnVGdg7t+Y=; b=TW6HfZQc6qovqRxajo++AdPCDlxn5qm/9dqMRu7OifV6GXsC+N6bBVyP/5T3te9DGd pG8omNtzCNRQJ9cdoBBNsCkV87KiOV99gAGfgBf3iCulC6Ytp/uswKgE2vKMk8+Ak1/s L9X3UFEVzqoihyNostuZHhbvHRrBEuxSNCCBrrsQnHRkOFs1tbUmbR5r6yed4vR7wvgw yWHNJbaDa3nIbyhyJ494j/77SOEL1kzAdyObKvCzgSJ81ni6XhwuTRCBcPKN/CiwTjII DHZXAW6VSj5K2H/b5SQxR8R18Ipwm5lmwbU54j0CfGAHur4PwatG+3AzkAhfefSj4JE5 jz8w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=dJioNcsQ; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-194640-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-194640-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d9443c01a7336-1f44c7cdb3asi103046735ad.166.2024.05.29.13.22.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 13:22:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-194640-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=dJioNcsQ; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-194640-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-194640-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id C804E28A6CA for ; Wed, 29 May 2024 20:04:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A7BDF1C8FA2; Wed, 29 May 2024 20:04:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="dJioNcsQ" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADC7F13B290; Wed, 29 May 2024 20:04:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717013074; cv=none; b=pZq+KWOluAMWdRr5+ozKNF6EmPzIde/mF259jZZfUZ2DVH2e8bTP9XhGdTUBuLj+QKIfMhuokXTzLRqUqqQCAO0rVZWTQBugf6Bx4BxeC46sRXd0V46aTvTu0iG4qxorEvqPKXsqO0zLq5rdwp5wr7kflHsgojoDt1gtp05iodk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717013074; c=relaxed/simple; bh=fCNn7IfHYiOzuDTUVnSEiJ6oAZ7RajYcAuCjWzn1eC8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lshm2UFTjdzFlW6ng3tR9ZCGnPJKXvQ6g1swqEAU1jXi5346H2Egz9yuCShFwKvMDEegmYk5tcNZU/XgzTTE0/culi2q2ll3O58fad2NUsuycn09Y7AfBh1KdlG2txBa9kDoGRj+MsWAw96HxOieKIUHl8tiugqYSM1G28jX4q8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=dJioNcsQ; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ji6jBdkqbxFp+OuQ43Vad4Fu8h64VsKVi9xqFhSvyYA=; b=dJioNcsQZXAchoX1u3Z0RRXz24 IKDZp77Z4YGT1uctbu0exqw7hEpgGMUo2U4LksS6p6KiAbUwQbB3eHeJMEVWxTzdPlDZkt+Ib425y Jo2FDh9wzn8zWREigGcEoimGBekkEenTVCuFCOZXOY7cIyU7PTC/C82WHNEQq+Bfavpk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sCPWj-00GI0X-GX; Wed, 29 May 2024 22:04:01 +0200 Date: Wed, 29 May 2024 22:04:01 +0200 From: Andrew Lunn To: Sagar Cheluvegowda Cc: Vinod Koul , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Jochen Henneberg , linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: stmmac: dwmac-qcom-ethqos: Configure host DMA width Message-ID: <5044135d-5a99-4ea3-add5-08954f7a7809@lunn.ch> References: <20240529-configure_ethernet_host_dma_width-v1-1-3f2707851adf@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240529-configure_ethernet_host_dma_width-v1-1-3f2707851adf@quicinc.com> On Wed, May 29, 2024 at 11:39:04AM -0700, Sagar Cheluvegowda wrote: > Fixes: 070246e4674b ("net: stmmac: Fix for mismatched host/device DMA address width") > Signed-off-by: Sagar Cheluvegowda You need some sort of description in the commit message. How would i know i hit this bug? What do i see as a user? You want to give a hint to people looking at patches to know if they need this fix or not. Also, you need to make it clear why this patch meets the stable rules. > --- > Change-Id: Ifdf3490c6f0dd55afc062974c05acce42d5fb6a7 And what does this mean, in the context of mainline? Andrew --- pw-bot: cr