Received-SPF: pass (google.com: domain of linux-kernel+bounces-194674-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 29 May 2024 21:45:32 +0100
From: Gary Guo <gary@garyguo.net>
To: Masahiro Yamada <masahiroy@kernel.org>, Nathan Chancellor
 <nathan@kernel.org>, Nicolas Schier <nicolas@fjasle.eu>, Andrew Morton
 <akpm@linux-foundation.org>, Miguel Ojeda <ojeda@kernel.org>, Alex Gaynor
 <alex.gaynor@gmail.com>, Wedson Almeida Filho <wedsonaf@gmail.com>, Boqun
 Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>, =?UTF-8?B?Qmo=?=
 =?UTF-8?B?w7Zybg==?= Roy Baron <bjorn3_gh@protonmail.com>, Benno Lossin
 <benno.lossin@proton.me>, Andreas Hindborg <a.hindborg@samsung.com>, Alice
 Ryhl <aliceryhl@google.com>, Nick Desaulniers <ndesaulniers@google.com>,
 Bill Wendling <morbo@google.com>, Justin Stitt <justinstitt@google.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
 rust-for-linux@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [RFC PATCH 2/2] kbuild: rust: provide an option to inline C
 helpers into Rust
Message-ID: <20240529214532.7804a7d2.gary@garyguo.net>
In-Reply-To: <20240529202817.3641974-3-gary@garyguo.net>
References: <20240529202817.3641974-1-gary@garyguo.net>
	<20240529202817.3641974-3-gary@garyguo.net>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?tEHwKGZN6FLshT11w2OKFIG0rLEUvHmDjU+Qjtl6tyhhHnFGKN4ASE2mPJfW?=
 =?us-ascii?Q?B2vy4GwAnHh8TItEGcdnhk10su9hSyzMWZO9cpyoAhkZzCqJquxs0o2vvqlS?=
 =?us-ascii?Q?uO/hmCoLoGdIULvXbB2l8d74fnJ8GFI6QKM0GyucQqd7t05xA1z7nr+qVgP3?=
 =?us-ascii?Q?9Mj68vAQY/gjUjlJkYPLm4d+xUKfKE88fqdbLZUpovs7+e9V/liDoc04vawv?=
 =?us-ascii?Q?AITwKW3AYS3dGA8IgBh7YjMgAQl0bENqHO0brxRkbC8rIumHwLVUdhZd/lHy?=
 =?us-ascii?Q?UBOIio1D/BGFUuGpHZWyVC9mrIO9UOzhtEkjn3LyGOUHCFBZNtEPKTbj7Etg?=
 =?us-ascii?Q?Qp4IFbeQru1wZ0D+QkUMe51vlUKJ1lSpUB6D7mCao5KJxNlF4V1+htdjUfKm?=
 =?us-ascii?Q?So6Q54dqOApckFcjyCoRmSVkTUcF/iCxcDSblXwLV50QHlZYXq03Bx3mDQY2?=
 =?us-ascii?Q?kr5fDQZcnW+O5hUxTRpQzMbTZJdfwi29BsMwlg+GPyV6vyqe47xPhFVufqiH?=
 =?us-ascii?Q?9X7Q6QRx8d641w6wpaxq3z2rFJ1Zi5XtBWg2SufMdpRlzoPfw5Agiv0E6eOl?=
 =?us-ascii?Q?7FPA+GVpe/sPA8Nc1WGBKxRQAQUre2x9+2RAHBUcFZ72y+7JKPjyrV7J3y6s?=
 =?us-ascii?Q?KWUWOVo7PqcKiXkJ/8gHodcDr78DQSxmAJUpauigO+NaUz4TMyVFew7ZIa2B?=
 =?us-ascii?Q?wmYTflBoUPueRTcBIeGsAbARbp7vEyT2P9TIU0sqjXdd4tSb3vSfGcAmYBME?=
 =?us-ascii?Q?NCTChrDssCt3eljRm/qRiIGYyps9k9SC4zyoeogAVF62njdQsnjnsunJnktA?=
 =?us-ascii?Q?ruxmUvYKV3aOBPLjwoFsfAPqN7YZsBb2KgFT2IjR4XLsmrzuiUy5g3KCKYoP?=
 =?us-ascii?Q?SRj37V2lgPSRwYt9IB1BZlddj+f7WzGOYepYZPf0FKPah/+7QCFAYP9roGy/?=
 =?us-ascii?Q?M3EFb8gxdxaUPsb6CMFiorBSH24wqWK8r/V4FARThmawyZnOakvwcMHuPJpx?=
 =?us-ascii?Q?UQENpQM1ho5OJQnSx2EWCshp5LbA/7dGLPt9nY6iVbNjXP4iYNi7LEQ+LTQT?=
 =?us-ascii?Q?LzlbEJ6o/aKWrVProre9JQJaoGv4UmFIv+/ro1hFBKgiPBya6v2+FCOnVGOb?=
 =?us-ascii?Q?mGTZBtjOiZSwRSMjC7J+7G/KfwYDgKW8FKEGJAeOfQgOPjavd31vbW+1VJsU?=
 =?us-ascii?Q?sgCa+kZnbiZscGRfjAy21QdqXGTymeb3qBxLIkgH3d8k4eILQbclGXKEupEO?=
 =?us-ascii?Q?7N5LVD/3YB3ZB9re0P8MVmvp7Yzga/Dq+5mZNnqFYeEAu7X/CtfvaG94XDk9?=
 =?us-ascii?Q?fHT7mrT3dbNt3ksWDEVyQ9XWu7aD2K/8IXwADuBO+4SKTSOO3vfwbp0LVp92?=
 =?us-ascii?Q?bOrA76e+5GV5KhjrLE1tlRFqB2+IpWN3h1HH1wRSlvUmT1pEF/JL2NO1KSkp?=
 =?us-ascii?Q?njhhfqjeS0LOwAJAbWxXqkLoeMl10bw/fxPkHOPWqwoX61H9XVPZsTfKFBiP?=
 =?us-ascii?Q?7OqgC5VkQON/HSXg41qDKDbtdRc/ywKeR2J8ziQcbiJjmCMqYkug2nCJBI5p?=
 =?us-ascii?Q?9uGaR013kiNNPvq5Ok69Xaw/HGANLTpbhFmQX/BGegcjuee2Hm7fd1Kxy74j?=
 =?us-ascii?Q?qS2e0axGBfGfDeJ6W6ix1o0KF9PcaFy4Pnk3q4kVbhhN?=
X-OriginatorOrg: garyguo.net
X-MS-Exchange-CrossTenant-Network-Message-Id: 68599b3c-c649-4392-f705-08dc80204c18
X-MS-Exchange-CrossTenant-AuthSource: LO2P265MB5183.GBRP265.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2024 20:45:38.4942
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bbc898ad-b10f-4e10-8552-d9377b823d45
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oVnfyqsSWgJrMcCt177ruDh7olROktsOLshTd8+iy+RUz1HsVsLdjZhI8GNCjdxGPH32FKdEG3HSU+k8pNFVcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO0P265MB5141

On Wed, 29 May 2024 21:28:15 +0100
Gary Guo <gary@garyguo.net> wrote:

>  Makefile               |  4 +++-
>  lib/Kconfig.debug      | 10 ++++++++++
>  rust/Makefile          | 34 ++++++++++++++++++++++++++++++----
>  rust/exports.c         |  3 +++
>  rust/helpers.c         | 41 +++++++++++++++++++++--------------------
>  scripts/Makefile.build |  5 ++++-
>  6 files changed, 71 insertions(+), 26 deletions(-)
>
> diff --git a/rust/helpers.c b/rust/helpers.c
> index 895f4b696962..3abf96f14148 100644
> --- a/rust/helpers.c
> +++ b/rust/helpers.c
> @@ -32,18 +32,19 @@
>  #include <linux/spinlock.h>
>  #include <linux/wait.h>
>  #include <linux/workqueue.h>
> +#include "helpers.h"

I made a mistake during rebase and forgot to include rust/helpers.h in
this patch. The content is

```
#ifndef RUST_HELPERS_H
#define RUST_HELPERS_H

#include <linux/compiler_types.h>

#ifdef __BINDGEN__
#define __rust_helper
#else
#define __rust_helper inline
#endif

#endif
```

I'll include this in patch v2 but would like to get a general feedback
before sending another version.