Received-SPF: pass (google.com: domain of linux-kernel+bounces-194736-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 29 May 2024 15:16:13 -0700
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scftorture: make torture_type static
Message-ID: <aa151486-2166-427a-a82f-3f5ed7e6b278@paulmck-laptop>
Reply-To: paulmck@kernel.org
References: <20240529-static-scftorture-v1-1-b0ceaeefebaa@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240529-static-scftorture-v1-1-b0ceaeefebaa@quicinc.com>

On Wed, May 29, 2024 at 01:45:40PM -0700, Jeff Johnson wrote:
> Fix the 'make C=1' warning:
> kernel/scftorture.c:71:6: warning: symbol 'torture_type' was not declared. Should it be static?
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

I queued both this and the scftorture.c fix, thank you!!!

							Thanx, Paul

> ---
>  kernel/scftorture.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/scftorture.c b/kernel/scftorture.c
> index 59032aaccd18..13ad348143ca 100644
> --- a/kernel/scftorture.c
> +++ b/kernel/scftorture.c
> @@ -67,7 +67,7 @@ torture_param(int, weight_many_wait, -1, "Testing weight for multi-CPU operation
>  torture_param(int, weight_all, -1, "Testing weight for all-CPU no-wait operations.");
>  torture_param(int, weight_all_wait, -1, "Testing weight for all-CPU operations.");
>  
> -char *torture_type = "";
> +static char *torture_type = "";
>  
>  #ifdef MODULE
>  # define SCFTORT_SHUTDOWN 0
> 
> ---
> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
> change-id: 20240529-static-scftorture-c86eccd9e30e
>