Received-SPF: pass (google.com: domain of linux-kernel+bounces-194761-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Hillf Danton <hdanton@sina.com>
To: syzbot <syzbot+a7d2b1d5d1af83035567@syzkaller.appspotmail.com>
Cc: linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org,
	syzkaller-bugs@googlegroups.com,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Radoslaw Zielonek <radoslaw.zielonek@gmail.com>,
	Vinicius Costa Gomes <vinicius.gomes@intel.com>,
	Eric Dumazet <edumazet@google.com>
Subject: Re: [syzbot] [net?] INFO: rcu detected stall in packet_release
Date: Thu, 30 May 2024 06:52:14 +0800
Message-Id: <20240529225214.2968-1-hdanton@sina.com>
In-Reply-To: <0000000000007d66bc06196e7c66@google.com>
References: 
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Test Vlad's patch [1]
[1] https://lore.kernel.org/netdev/20240527153955.553333-1-vladimir.oltean@nxp.com/

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git  main

--- x/net/sched/sch_taprio.c
+++ y/net/sched/sch_taprio.c
@@ -1847,6 +1847,7 @@ static int taprio_change(struct Qdisc *s
 		return -EOPNOTSUPP;
 	}
 	q->flags = taprio_flags;
+	taprio_set_picos_per_byte(dev, q);
 
 	err = taprio_parse_mqprio_opt(dev, mqprio, extack, q->flags);
 	if (err < 0)
@@ -1907,7 +1908,6 @@ static int taprio_change(struct Qdisc *s
 	if (err < 0)
 		goto free_sched;
 
-	taprio_set_picos_per_byte(dev, q);
 	taprio_update_queue_max_sdu(q, new_admin, stab);
 
 	if (FULL_OFFLOAD_IS_ENABLED(q->flags))
--