Received-SPF: pass (google.com: domain of linux-kernel+bounces-194791-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Vasileios Amoiridis <vassilisamir@gmail.com>
Date: Thu, 30 May 2024 01:49:17 +0200
To: Jonathan Cameron <jic23@kernel.org>
Cc: Vasileios Amoiridis <vassilisamir@gmail.com>, lars@metafoo.de,
	andriy.shevchenko@linux.intel.com, ang.iglesiasg@gmail.com,
	mazziesaccount@gmail.com, ak@it-klinger.de,
	petre.rodan@subdimension.ro, phil@raspberrypi.com, 579lpy@gmail.com,
	linus.walleij@linaro.org, semen.protsenko@linaro.org,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 5/5] iio: pressure: bmp280: Add triggered buffer
 support
Message-ID: <20240529234917.GA83937@vamoiridPC>
References: <20240512230524.53990-1-vassilisamir@gmail.com>
 <20240512230524.53990-6-vassilisamir@gmail.com>
 <20240529211228.2d7fbd93@jic23-huawei>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240529211228.2d7fbd93@jic23-huawei>

On Wed, May 29, 2024 at 09:12:28PM +0100, Jonathan Cameron wrote:
> On Mon, 13 May 2024 01:05:24 +0200
> Vasileios Amoiridis <vassilisamir@gmail.com> wrote:
> 
> > BMP2xx, BME280, BMP3xx, and BMP5xx use continuous buffers for their
> > temperature, pressure and humidity readings. This facilitates the
> > use of burst/bulk reads in order to acquire data faster. The
> > approach is different from the one used in oneshot captures.
> > 
> > BMP085 & BMP1xx devices use a completely different measurement
> > process that is well defined and is used in their buffer_handler().
> > 
> > Suggested-by: Angel Iglesias <ang.iglesiasg@gmail.com>
> > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> > ---
> 
> > +
> > +const struct iio_buffer_setup_ops bmp280_buffer_setup_ops = {
> 0-day noted that this isn't actually used.
> I'll add it to the buffer setup where it's currently passed as null.

Hi Jonathan,

Yes, 0-day informed me, but I was not sure what to do so I was waiting
to see if you would see it during the weekend. Thanks for taking care
of it.

Cheers,
Vasilis
> > +	.preenable = bmp280_buffer_preenable,
> > +	.postdisable = bmp280_buffer_postdisable,
> > +};
> > +