Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp976433lqb; Wed, 29 May 2024 17:18:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVzLM9a94EEH+wDw7lT7zezX7NIhwoEh7uGGt738++l+n4hjRau0qWcSZzxI4kjtddx/F4KIsNcZUhHPH1aJpsdFYZGTZhOL3blLtU9JQ== X-Google-Smtp-Source: AGHT+IG7V1T8XdpQgKmFhkzE57gxfupG1eNKRga6GYsnrsHNf9Mt1/1MkH3pJ1rzfmfRHqFOqhiy X-Received: by 2002:a05:620a:6a84:b0:793:1bc7:b6dd with SMTP id af79cd13be357-794eaf0467emr50614985a.23.1717028312380; Wed, 29 May 2024 17:18:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717028312; cv=pass; d=google.com; s=arc-20160816; b=0UmsQvgYr28rMiRTIAzxdorNbwIAI72d9SyW75agHKFJ38ctTBRWnIm0NUzMAI1gqa 8Xi3sTI3y0+5FNDKvmNa3y+Ho/3hHRDk5gsxZ1aVe2qkEZfjABDKrn/3O2UHM/KwYLGr Z5/RgiMfc1aAgeMITNvfVdNExtfkuiHpVpcKP7eLrB0uxuJXTjk7IQm4m0kYvXAdcDYc r6Db+kytYpxfeBoOJFJYB7qHHu1rs2O7RnyQOyE4o1+JBanZ2pmON5zYVvK/ie+E4ZH1 WgFSYdVuUGJz9DG5ZdNYD8/jP9j8tUZIrOKQRRD0RmITp2AkTlIDewE4dFOKTgII3lf8 w6mQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=Jnype4jDB0uKuj3jMAJ+c8bNce65Id4lLol5zvBdT0I=; fh=sYoOjH+2xlfUaoDYdBbLySxZZp2PBTGbWueabftsPjs=; b=bhpP/2cVZTRSOS48NreX9sbOoXZyYGKli8QjMhlzdhGBdmsP+eQYpbpmKd42Q5dzWE 2WOuQyvm9OXgISof3KRuiDZNVj+gl1xjy8BoXsEGWfYCuOP10WFH0gYVaJycrQcWzYyY dtoC7T26c/6amUjzt3wHAHSvmJndtX1eAjNXXCr6neFasNR+58TJ0ffRqUZwUUp5qThM tEr9NUiz/Zz2L7aK2lqz0t6OszGtTObjiDGfhSg3UPGE7INw43Wt7Rro5lo+e9osvfZ6 A6AEKG5RuXUivLFw/MoxfInqxLWNWtHIODXrYtP7LyH0wtYnTt5TPmGZnc8dPwEnoTk/ 5vbg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="C7/bhxbh"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-194801-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-194801-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id af79cd13be357-794e837ce72si96450685a.489.2024.05.29.17.18.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 17:18:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-194801-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="C7/bhxbh"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-194801-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-194801-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 214841C213DC for ; Thu, 30 May 2024 00:18:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A86B718641; Thu, 30 May 2024 00:17:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C7/bhxbh" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAA6E14F62; Thu, 30 May 2024 00:17:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717028262; cv=none; b=V2h+iVPvxKYDwzdzYRRa8nkCvfvFOOrQfOzdx0zQLcsznrXVunRWAV+QukrYeZtM+O3eZTwpVjiW9B3WlPNDjAWOHdeaBo/ocCUoZzqwcdwpds06+2DB7x73DzNJUajMYd5PiVB56o0Wt+wSnNGSqOzIWS9OOKP5X0n0Kh4grxg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717028262; c=relaxed/simple; bh=djdHd8wIHONCymWta1CjqNGNBC7+yFbgjGcWEkWGUHg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OpIXUOilBiQZgA0l9eWIcSACzIPcapJ1wNA+CR1gB0B8tGrZUge+I45gxZ239+1WjbxbDLsBLcKw6VtMtIaRNXbBfRcLKQveVLQDLg6NR43XTQMlfAlEM0yE0PHZSuxHLOTASiGLf66hkVyJAw5SjJVV9qhMMW+Jo7Cm8YFFkx4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=C7/bhxbh; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id BD523C113CC; Thu, 30 May 2024 00:17:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717028262; bh=djdHd8wIHONCymWta1CjqNGNBC7+yFbgjGcWEkWGUHg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C7/bhxbhCQ2f9sVQXyL58m7qdJhdR83K6vwFSyAUYKSZg8+cp36I01HifiNaqHV0r 2zgIpDY7J0QlBS9QXIqmQvmUVPnR8JVoyIbNSQr0HFva5moTIikCr4qFH1BxCX47iz I4+ES8Ex9CTiD9utjC9srvXjvATl7/g4jRH0nN/NjkH9CXNFdj7H18C1P3JPVMqpPg Xk0uLhHSCdppObIX0jDkIRSWZiI20dyzNMbII2MFuz6Cf4FV4cpLO51LZOaIA3xbOT hefSAPPX+3X04hisxm1YZ9d4WX6bhlYbjWETU3fqQKLugVSDIKnLPoRnuBRa0yky/7 hznkxY928MTxw== Date: Wed, 29 May 2024 17:17:40 -0700 From: Jakub Kicinski To: Thorsten Blum Cc: Nicolas Pitre , "David S. Miller" , Eric Dumazet , Paolo Abeni , Breno Leitao , Uwe =?UTF-8?B?S2xl?= =?UTF-8?B?aW5lLUvDtm5pZw==?= , Andrew Lunn , John Paul Adrian Glaubitz , Arnd Bergmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: smc91x: Refactor SMC_* macros Message-ID: <20240529171740.0643a5a1@kernel.org> In-Reply-To: <20240528104421.399885-3-thorsten.blum@toblux.com> References: <20240528104421.399885-3-thorsten.blum@toblux.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 28 May 2024 12:44:23 +0200 Thorsten Blum wrote: > Use the macro parameter lp directly instead of relying on ioaddr being > defined in the surrounding scope. Have you tested this, or just compile tested (please mention what testing has been done in the commit message in the future)? What's the motivation - cleanup or this helps remove some warnings? (again, please mention in the commit message) AFAICT this will break smc_probe(). -- pw-bot: cr