Received-SPF: pass (google.com: domain of linux-kernel+bounces-194808-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <4039d0b0-8f75-46b1-8430-fe2f38ee4e38@quicinc.com>
Date: Thu, 30 May 2024 08:27:07 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sa8775p: Add IMEM and PIL info
 region
To: Mukesh Ojha <quic_mojha@quicinc.com>, <robh@kernel.org>,
        <krzk+dt@kernel.org>, <conor+dt@kernel.org>, <andersson@kernel.org>
CC: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <kernel@quicinc.com>
References: <20240529101929.3167610-1-quic_tengfan@quicinc.com>
 <20240529101929.3167610-3-quic_tengfan@quicinc.com>
 <8c317b50-c6c0-95e4-7d85-76516a387f85@quicinc.com>
From: Tengfei Fan <quic_tengfan@quicinc.com>
In-Reply-To: <8c317b50-c6c0-95e4-7d85-76516a387f85@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


On 5/29/2024 8:36 PM, Mukesh Ojha wrote:
> 
> 
> On 5/29/2024 3:49 PM, Tengfei Fan wrote:
>> Add a simple-mfd representing IMEM on SA8775p and define the PIL
>> relocation info region, so that post mortem tools will be able
>> to locate the loaded remoteprocs.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sa8775p.dtsi | 15 +++++++++++++++
>>   1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi 
>> b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> index 5632fa896b93..eb33b1587802 100644
>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> @@ -3025,6 +3025,21 @@ tlmm: pinctrl@f000000 {
>>               wakeup-parent = <&pdc>;
>>           };
>> +        sram: sram@146d8000 {
>> +            compatible = "qcom,sa8775p-imem", "syscon", "simple-mfd";
>> +            reg = <0x0 0x146d8000 0x0 0x1000>;
>> +
>> +            #address-cells = <1>;
>> +            #size-cells = <1>;
>> +
>> +            ranges = <0x0 0x0 0x146d8000 0x1000>;
> 
> This could be moved up along with reg region.
> 
> -Mukesh

Sure, I will move up along with reg region in the next version patch series.

> 
>> +
>> +            pil-reloc@94c {
>> +                compatible = "qcom,pil-reloc-info";
>> +                reg = <0x94c 0xc8>;
>> +            };
>> +        };
>> +
>>           apps_smmu: iommu@15000000 {
>>               compatible = "qcom,sa8775p-smmu-500", "qcom,smmu-500", 
>> "arm,mmu-500";
>>               reg = <0x0 0x15000000 0x0 0x100000>;

-- 
Thx and BRs,
Tengfei Fan