Received-SPF: pass (google.com: domain of linux-kernel+bounces-194803-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <e07d10d2-b73e-45ff-a2b2-ebe85306ddf9@quicinc.com>
Date: Thu, 30 May 2024 08:20:29 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/2] arm64: dts: qcom: sm8550: Move usb-role-switch to
 SoC dtsi
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
CC: <andersson@kernel.org>, <konrad.dybcio@linaro.org>, <robh@kernel.org>,
        <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <kernel@quicinc.com>
References: <20240529100256.3158447-1-quic_tengfan@quicinc.com>
 <20240529100256.3158447-2-quic_tengfan@quicinc.com>
 <ljwkn7ilsixrww4vt7cmnmtot6qgihqglasoaftuil6i37qsxi@ia4bpqhkulwo>
From: Tengfei Fan <quic_tengfan@quicinc.com>
In-Reply-To: <ljwkn7ilsixrww4vt7cmnmtot6qgihqglasoaftuil6i37qsxi@ia4bpqhkulwo>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 5/29/2024 8:47 PM, Dmitry Baryshkov wrote:
> On Wed, May 29, 2024 at 06:02:55PM +0800, Tengfei Fan wrote:
>> The usb-role-switch is SA8775p SoC property, so move it from board dts
>> to SA8775p SoC dtsi.
> 
> The commit message doesn't match patch contents. Other than that LGTM

I will update this commit message. I work on the sa8775p platform 
lately, so I wrote this commit message incorrectly.

> 
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sm8550-hdk.dts                     | 1 -
>>   arch/arm64/boot/dts/qcom/sm8550-mtp.dts                     | 1 -
>>   arch/arm64/boot/dts/qcom/sm8550-qrd.dts                     | 1 -
>>   arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts | 1 -
>>   arch/arm64/boot/dts/qcom/sm8550.dtsi                        | 1 +
>>   5 files changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
>> index 31f52df6b67e..411de3451db8 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8550-hdk.dts
>> @@ -1255,7 +1255,6 @@ &usb_1 {
>>   
>>   &usb_1_dwc3 {
>>   	dr_mode = "otg";
>> -	usb-role-switch;
>>   };
>>   
>>   &usb_1_dwc3_hs {
>> diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
>> index 42d4d558b7aa..84d16227ef80 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
>> @@ -948,7 +948,6 @@ &usb_1 {
>>   
>>   &usb_1_dwc3 {
>>   	dr_mode = "otg";
>> -	usb-role-switch;
>>   };
>>   
>>   &usb_1_dwc3_hs {
>> diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
>> index 2ed1715000c9..e20c6240f76d 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
>> @@ -1117,7 +1117,6 @@ &usb_1 {
>>   
>>   &usb_1_dwc3 {
>>   	dr_mode = "otg";
>> -	usb-role-switch;
>>   };
>>   
>>   &usb_1_dwc3_hs {
>> diff --git a/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts b/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts
>> index 92a88fb05609..6dd5232da9f9 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8550-sony-xperia-yodo-pdx234.dts
>> @@ -739,7 +739,6 @@ &usb_1 {
>>   
>>   &usb_1_dwc3 {
>>   	dr_mode = "otg";
>> -	usb-role-switch;
>>   };
>>   
>>   &usb_1_dwc3_hs {
>> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> index 79311a6bd1ad..8e3ce1152211 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> @@ -3264,6 +3264,7 @@ usb_1_dwc3: usb@a600000 {
>>   				snps,has-lpm-erratum;
>>   				tx-fifo-resize;
>>   				dma-coherent;
>> +				usb-role-switch;
>>   
>>   				ports {
>>   					#address-cells = <1>;
>> -- 
>> 2.25.1
>>
> 

-- 
Thx and BRs,
Tengfei Fan