Received-SPF: pass (google.com: domain of linux-kernel+bounces-194817-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <1bcaba5063820df7fd87d887835c42e2faad9d86.camel@codeconstruct.com.au>
Subject: Re: [PATCH 1/4] dt-bindings: gpio: aspeed,sgpio: Order properties
 by DTS style
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Krzysztof Kozlowski <krzk@kernel.org>, Linus Walleij
 <linus.walleij@linaro.org>, Bartosz Golaszewski <brgl@bgdev.pl>, Rob
 Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor
 Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, 
	linux-kernel@vger.kernel.org
Date: Thu, 30 May 2024 10:18:10 +0930
In-Reply-To: <080c4c05-e795-49d8-a547-d39d10ed8333@kernel.org>
References: 
	<20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-0-91c42976833b@codeconstruct.com.au>
	 <20240529-dt-warnings-gpio-sgpio-interrupt-cells-v1-1-91c42976833b@codeconstruct.com.au>
	 <080c4c05-e795-49d8-a547-d39d10ed8333@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4-2 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-05-29 at 09:26 +0200, Krzysztof Kozlowski wrote:
> On 29/05/2024 07:13, Andrew Jeffery wrote:
> > Tidy up the list of required properties and the example node by orderin=
g
> > the properties in terms of the DTS coding style.
> >=20
> > Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
> > ---
> >  Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml | 12 ++++++--=
----
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> >=20
> > diff --git a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml b=
/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml
> > index 46bb121360dc..6b15a3a3fb66 100644
> > --- a/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml
> > +++ b/Documentation/devicetree/bindings/gpio/aspeed,sgpio.yaml
> > @@ -51,12 +51,12 @@ properties:
> >  required:
> >    - compatible
> >    - reg
> > -  - gpio-controller
> > -  - '#gpio-cells'
> > +  - clocks
> >    - interrupts
> >    - interrupt-controller
> > +  - gpio-controller
> > +  - '#gpio-cells'
> >    - ngpios
> > -  - clocks
> >    - bus-frequency
>=20
> No, this should have the same order as properties are listed.
>=20
> Don't change it.

Ack.

>=20
> > =20
> >  additionalProperties: false
> > @@ -65,13 +65,13 @@ examples:
> >    - |
> >      #include <dt-bindings/clock/aspeed-clock.h>
> >      sgpio: sgpio@1e780200 {
> > -        #gpio-cells =3D <2>;
> >          compatible =3D "aspeed,ast2500-sgpio";
> > -        gpio-controller;
> > -        interrupts =3D <40>;
> >          reg =3D <0x1e780200 0x0100>;
> >          clocks =3D <&syscon ASPEED_CLK_APB>;
> > +        interrupts =3D <40>;
> >          interrupt-controller;
> > +        gpio-controller;
> > +        #gpio-cells =3D <2>;
>=20
> That's just example. I don't find this change useful but churn.

Sure, I'll drop the patch.

Thanks,

Andrew