Received-SPF: pass (google.com: domain of linux-kernel+bounces-194829-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 30 May 2024 09:59:58 +0900
From: Byungchul Park <byungchul@sk.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: "Huang, Ying" <ying.huang@intel.com>, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, kernel_team@skhynix.com,
	akpm@linux-foundation.org, vernhao@tencent.com,
	mgorman@techsingularity.net, hughd@google.com, willy@infradead.org,
	david@redhat.com, peterz@infradead.org, luto@kernel.org,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, rjgolo@gmail.com
Subject: Re: [PATCH v10 00/12] LUF(Lazy Unmap Flush) reducing tlb numbers
 over 90%
Message-ID: <20240530005958.GB47476@system.software.com>
References: <20240510065206.76078-1-byungchul@sk.com>
 <982317c0-7faa-45f0-82a1-29978c3c9f4d@intel.com>
 <20240527015732.GA61604@system.software.com>
 <8734q46jc8.fsf@yhuang6-desk2.ccr.corp.intel.com>
 <44e4f2fd-e76e-445d-b618-17a6ec692812@intel.com>
 <20240529050046.GB20307@system.software.com>
 <961f9533-1e0c-416c-b6b0-d46b97127de2@intel.com>
 <20240530005026.GA47476@system.software.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240530005026.GA47476@system.software.com>
User-Agent: Mutt/1.9.4 (2018-02-28)

On Thu, May 30, 2024 at 09:50:26AM +0900, Byungchul Park wrote:
> On Wed, May 29, 2024 at 09:41:22AM -0700, Dave Hansen wrote:
> > On 5/28/24 22:00, Byungchul Park wrote:
> > > All the code updating ptes already performs TLB flush needed in a safe
> > > way if it's inevitable e.g. munmap.  LUF which controls when to flush in
> > > a higer level than arch code, just leaves stale ro tlb entries that are
> > > currently supposed to be in use.  Could you give a scenario that you are
> > > concering?
> > 
> > Let's go back this scenario:
> > 
> >  	fd = open("/some/file", O_RDONLY);
> >  	ptr1 = mmap(-1, size, PROT_READ, ..., fd, ...);
> >  	foo1 = *ptr1;
> > 
> > There's a read-only PTE at 'ptr1'.  Right?  The page being pointed to is
> > eligible for LUF via the try_to_unmap() paths.  In other words, the page
> > might be reclaimed at any time.  If it is reclaimed, the PTE will be
> > cleared.
> > 
> > Then, the user might do:
> > 
> > 	munmap(ptr1, PAGE_SIZE);
> > 
> > Which will _eventually_ wind up in the zap_pte_range() loop.  But that
> > loop will only see pte_none().  It doesn't do _anything_ to the 'struct
> > mmu_gather'.
> > 
> > The munmap() then lands in tlb_flush_mmu_tlbonly() where it looks at the
> > 'struct mmu_gather':
> > 
> >         if (!(tlb->freed_tables || tlb->cleared_ptes ||
> > 	      tlb->cleared_pmds || tlb->cleared_puds ||
> > 	      tlb->cleared_p4ds))
> >                 return;
> > 
> > But since there were no cleared PTEs (or anything else) during the
> > unmap, this just returns and doesn't flush the TLB.
> > 
> > We now have an address space with a stale TLB entry at 'ptr1' and not
> > even a VMA there.  There's nothing to stop a new VMA from going in,
> > installing a *new* PTE, but getting data from the stale TLB entry that
> > still hasn't been flushed.
> 
> Thank you for the explanation.  I got you.  I think I could handle the
> case through a new flag in vma or something indicating LUF has deferred
> necessary TLB flush for it during unmapping so that mmu_gather mechanism
> can be aware of it.  Of course, the performance change should be checked
> again.  Thoughts?

I will check the existing optimization of TLB flsuh more in arch level
and suggest a better way.

	Byungchul

> Thanks again.
> 
> 	Byungchul