Received-SPF: pass (google.com: domain of linux-kernel+bounces-194886-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: "Ng, Boon Khai" <boon.khai.ng@intel.com>
To: Andrew Lunn <andrew@lunn.ch>
CC: Sunil Kovvuri Goutham <sgoutham@marvell.com>, Alexandre Torgue
	<alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, "David S .
 Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, "Jakub
 Kicinski" <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Maxime Coquelin
	<mcoquelin.stm32@gmail.com>, "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>, "linux-stm32@st-md-mailman.stormreply.com"
	<linux-stm32@st-md-mailman.stormreply.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "Ang, Tien Sung" <tien.sung.ang@intel.com>,
	"G Thomas, Rohan" <rohan.g.thomas@intel.com>, "Looi, Hong Aun"
	<hong.aun.looi@intel.com>, Andy Shevchenko
	<andriy.shevchenko@linux.intel.com>, Ilpo Jarvinen
	<ilpo.jarvinen@linux.intel.com>
Subject: RE: [Enable Designware XGMAC VLAN Stripping Feature v2 1/1] net:
 stmmac: dwxgmac2: Add support for HW-accelerated VLAN Stripping
Thread-Topic: [Enable Designware XGMAC VLAN Stripping Feature v2 1/1] net:
 stmmac: dwxgmac2: Add support for HW-accelerated VLAN Stripping
Thread-Index: AQHasM89szK8kSaG/E2tzqRYe3FnP7GsPSPAgABUdoCAAnD58A==
Date: Thu, 30 May 2024 02:16:05 +0000
Message-ID: <BL3PR11MB5748AC693D9D61FB56DB7313C1F32@BL3PR11MB5748.namprd11.prod.outlook.com>
References: <20240527093339.30883-1-boon.khai.ng@intel.com>
 <20240527093339.30883-2-boon.khai.ng@intel.com>
 <BY3PR18MB47372537A64134BCE2A4F589C6F02@BY3PR18MB4737.namprd18.prod.outlook.com>
 <DM8PR11MB5751CE01703FFF7CB62DAF9BC1F02@DM8PR11MB5751.namprd11.prod.outlook.com>
 <BY3PR18MB4737DAE0AD482B9660676F6BC6F02@BY3PR18MB4737.namprd18.prod.outlook.com>
 <DM8PR11MB5751118297FB966DA95F55DFC1F12@DM8PR11MB5751.namprd11.prod.outlook.com>
 <BY3PR18MB4737D071F3F747B6ECB15BF2C6F12@BY3PR18MB4737.namprd18.prod.outlook.com>
 <DM8PR11MB57515E89D10F06644155DA11C1F12@DM8PR11MB5751.namprd11.prod.outlook.com>
 <cf5ad64e-c9c3-426f-a262-3f03964b90fe@lunn.ch>
In-Reply-To: <cf5ad64e-c9c3-426f-a262-3f03964b90fe@lunn.ch>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rUln2l44OR72sYcfAiaDYUufSBWLegzXdKwceDFwl0PgjIqcRSXmGxrKmoKa?=
 =?us-ascii?Q?2kZUBQ1/n75CLW9sen+fX3+2iYvBFI+qfKfRzqDPnT75CU3hOxQj6OSjAASR?=
 =?us-ascii?Q?o9w62atOZtlAb9p0kkTOeEZsswLDWSFl4i/xI36Zs0iWCS6s47TrK1p4Gv4F?=
 =?us-ascii?Q?UkiiY8AYyNAPpPfAk2c+hVjZ1iNYQTRgZj0wAaM6V3V6HKxoZei9TJDt4Lqt?=
 =?us-ascii?Q?BMreIxbFELnBhsR4T/l9qQ8CJT4jbzzcZpeOWUd4RSbm69AdZWrkaMRLuGId?=
 =?us-ascii?Q?FHg2RYrWU8kN5FvwAUBngbC02VAlJcg2ZvgCI3vULl2uxsIKsiXOJXVZXawn?=
 =?us-ascii?Q?BzhBchb2m0EqO0fwH5IhiX7yxsnpFcQRg6sjlLBsQn5Qxs7BlshoxO/90oBH?=
 =?us-ascii?Q?M9RdVqH6pJ0+4IGOFpPQHBz/427eTDKTiuA8sWBwS1EbbZc62uUYRTZorISv?=
 =?us-ascii?Q?0WcaZhSFQDA3eG+F+ph4tH+nlwNixTm7lbNw/ssWCUs7lxoDi+wRrFvisloL?=
 =?us-ascii?Q?ZJVIPRA0Dzilbn8Qk/RoBJIum/hBXERwKE/0N+22RnVV9SmcNXseo7ZRwXjw?=
 =?us-ascii?Q?vuy3f9WAw+xcaRecvxlbnoJzPdjSnZKHxkhoRjG76kKsPe8he46RWaCUaL4d?=
 =?us-ascii?Q?1VFyFNih2o8vqAZ0niEPLjODU01DllYfVICeFBShpwxtI3bBnYVVkZkQFx8I?=
 =?us-ascii?Q?8Iu16N1MD5lkT/DTJPuWWFIjzchcA/8dFoG4CfYNO1CeskuWR6Ypy6sGTmPJ?=
 =?us-ascii?Q?SSuoinO74cE8dut4XFaa/Nnb2pQEZScOH+3MVT0DjBUx0p5wW3TkjStNoD4G?=
 =?us-ascii?Q?QSRxPhSc8H3167tucgPqzv4BHMOnMiEbLAyT+sN3zI/prx6r1aXphaQ7+TlD?=
 =?us-ascii?Q?+Aeo7MIrn5tbnjGz4OCkMYRtsX72XhMLmS6mn6DiZr1HjQyChkTzZpkORyRU?=
 =?us-ascii?Q?sd+Hk3dadSerFRozKHs2Ff1KOFirjZJllbfxYZlAeMBtDpB8rO4cqEOAG7Tk?=
 =?us-ascii?Q?QjWzpu7zGwaKeSWoY2CqtI0EzEdeI4mr9bRfXEVPthiJucevSiehxRruI/vK?=
 =?us-ascii?Q?DKDGRrX0tdNfom+7Spgj92ly5sP1R40xyyAWm0z0SeXUV5p2+fBoJxjF5+mb?=
 =?us-ascii?Q?Tqk8SCtAglJkjZhdkr5LvNhpXx1npcMxnWDu9/25qSSaPzaVk2TQy9BIToHy?=
 =?us-ascii?Q?+jIZbYSFz3Gdbq7E5BQ+srqganDbKepErPA1+p269vTOotoB146Ss09JlaEw?=
 =?us-ascii?Q?vjIWSDcSLKvX4FynqzGlFb7Baf5bvFOyWWlsXxgTC6mf5Chbbz15ZKrYzAzY?=
 =?us-ascii?Q?KrstEcMnhaYq2u7l0cZ1a0zNKDV9ZfZxKKPWRXqvilG++DD0lUkXQqDWic09?=
 =?us-ascii?Q?fD4jwxUaDBmP3QhztAoGyIc8rGtmfwy1b4h7Y8vT7aHkk6d0fS8GTgbwMCEl?=
 =?us-ascii?Q?tqS32gNxOwI4yO3Ezpm31MFVEcyN97tneRci90Wg3c2noHR5X70YvEpOPvsR?=
 =?us-ascii?Q?GHOfwVnSKiWWLkKrffwNieiMpV0nr57omnxOdXSOliH24zEhB2McIWcVvHuL?=
 =?us-ascii?Q?ckeEj2yRp+gOqvHpFljsvcKSHrDCQrvz1+p5aL9PMfBcw9YkN9/RSQlJfIIh?=
 =?us-ascii?Q?uiOVxQmZUl/19K7pm6+BYGJdLLjSdAEKrKCzknwaJ7Pz?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL3PR11MB5748.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 80226d70-5414-46a9-31b8-08dc804e75d0
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2024 02:16:05.1933
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: a2OXgyQYCoAvxVQjOXk2tZVkYtBJD5oBFBwUlMtqSNIQTzFNwQxQk2gEbsr4q1CFbwESgqQtgH1yE8l+MAr+ug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7171
X-OriginatorOrg: intel.com

> Please trim replies to what it just relevant.
>=20
> You probably should read:
>=20
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
>=20

Hi Andrew, Thanks for pointing that out, will take note on that.

> You might also want to read out to other Intel developers in Jesse Brande=
burg
> group and ask them to do an internal review before you post to the list.
>=20

I have reached out to our internal intel reviewer, and this patch
was reviewed by Andy Shevchenko for V1 and
Ilpo Jarvinen for V2.

For the V1 I got a NACK for the reason new hw_vlan_en switch
 is being introduced
https://lore.kernel.org/netdev/DM8PR11MB5751E5388AEFCFB80BCB483F
C13FA@DM8PR11MB5751.namprd11.prod.outlook.com/

So, after the internal review of V2 to detach the newly
Introduced hw_vlan_en switch, I have sent the v2 for=20
internal review and Ilpo helps to point out some of
the code that can be improved.

When I about to send out the v2, I found that the similar
implementation at dwmac4(which I got NACK) is=20
already accepted at dwmac4 driver
https://lore.kernel.org/lkml/20231121053842.719531-1-yi.fang.gan
@intel.com/T/

So, I have to revamp the v2 code again to match dwmac4
implementation. as we are using the same upper layer=20
code (stmmac_main.c). after sending this code out to
review internally again and no one else is entertaining the=20
review even after email and reminder also private message
were sent out several time and which leads me to publish
the review at the mailing list.

I hold no grievances toward the community or any individual,
I fully understand and appreciate the rigorous review process
necessary to maintain the high quality and integrity of the=20
linux codebase. My primary goal is to learn and grow as a
contributer and I believe that constructive feedback from
experienced members of the community will be invaluable
in this regard

With that said, I kindly request your assistance in providing
feedback on my code submissions. I am eager to understand
where improvements can be made and how I can align my
contributions more closely with the project's expectations.
By working together, I am confident that we can enhance
the quality of my code and ultimately contribute to the
success of the Linux project as a whole.

Please feel free to review my recent submissions and
share your insights, suggestions, and recommendations.
Your feedback is highly appreciated and will contribute
significantly to help with the linux codebase.

Thank you for your time and consideration.
I look forward to your valuable feedback and to continuing
my journey as a contributor to the Linux project.

Regards,
Boon Khai.