Received-SPF: pass (google.com: domain of linux-kernel+bounces-194897-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Vishnu Reddy'" <vishnu.reddy@samsung.com>, <krzk@kernel.org>,
	<s.nawrocki@samsung.com>, <linus.walleij@linaro.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-samsung-soc@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <pankaj.dubey@samsung.com>,
	<ravi.patel@samsung.com>
In-Reply-To: <20240529065939.36369-1-vishnu.reddy@samsung.com>
Subject: RE: [PATCH] pinctrl: samsung: Add support for pull-up and pull-down
Date: Thu, 30 May 2024 08:21:53 +0530
Message-ID: <002601dab23c$559263d0$00b72b70$@samsung.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQLxKHH81TrGQH9mk3YrmwmVK5Ft8wKHISlnr23t8YA=
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <CGME20240529070220epcas5p140580a28b93ce5cb256ef825c778c649@epcas5p1.samsung.com>
	<20240529065939.36369-1-vishnu.reddy@samsung.com>

Hi Vishnu,

> -----Original Message-----
> From: Vishnu Reddy <vishnu.reddy=40samsung.com>
> Sent: Wednesday, May 29, 2024 12:30 PM
> To: krzk=40kernel.org; s.nawrocki=40samsung.com; alim.akhtar=40samsung.co=
m;
> linus.walleij=40linaro.org
> Cc: linux-arm-kernel=40lists.infradead.org; linux-samsung-soc=40vger.kern=
el.org;
> linux-gpio=40vger.kernel.org; linux-kernel=40vger.kernel.org;
> pankaj.dubey=40samsung.com; ravi.patel=40samsung.com
> Subject: =5BPATCH=5D pinctrl: samsung: Add support for pull-up and pull-d=
own
>=20
> gpiolib framework has the implementation of setting up the PUD configurat=
ion
> for GPIO pins but there is no driver support.
>=20
> Add support to handle the PUD configuration request from the userspace in
> samsung pinctrl driver.
>=20
> Signed-off-by: Vishnu Reddy <vishnu.reddy=40samsung.com>
> ---
>  drivers/pinctrl/samsung/pinctrl-samsung.c =7C 51 +++++++++++++++++++++++
> drivers/pinctrl/samsung/pinctrl-samsung.h =7C  7 ++++
>  2 files changed, 58 insertions(+)
>=20
> diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c
> b/drivers/pinctrl/samsung/pinctrl-samsung.c
> index ed07e23e0912..a4b6eea5e168 100644
> --- a/drivers/pinctrl/samsung/pinctrl-samsung.c
> +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c
> =40=40 -939,6 +939,56 =40=40 static int samsung_pinctrl_unregister(struct
> platform_device *pdev,
>  	return 0;
>  =7D
>=20
> +/*
> + * samsung_gpio_set_pud will enable or disable the pull-down and
> + * pull-up for the gpio pins in the PUD register.
> + */
> +static void samsung_gpio_set_pud(struct gpio_chip *gc, unsigned int offs=
et,
> +				 unsigned int value)
> +=7B
> +	struct samsung_pin_bank *bank =3D gpiochip_get_data(gc);
> +	const struct samsung_pin_bank_type *type =3D bank->type;
> +	void __iomem *reg;
> +	unsigned int data;
> +
> +	reg =3D bank->pctl_base + bank->pctl_offset;
> +	data =3D readl(reg + type->reg_offset=5BPINCFG_TYPE_PUD=5D);
> +	data &=3D =7E(0xf << (offset * 4));
For the mask, you can use =22type->fld_width=22 as that is more generic and=
 will work for all SoC
I didn=E2=80=99t=20get,=20why=20you=20are=20multiplying=20offset=20with=204=
?=20Is=20this=20true=20for=20all=20SoC?=0D=0A=0D=0A>=20+=09data=20=7C=3D=20=
value=20<<=20(offset=20*=204);=0D=0A>=20+=09writel(data,=20reg=20+=20type->=
reg_offset=5BPINCFG_TYPE_PUD=5D);=0D=0A>=20+=7D=0D=0A>=20+=0D=0A>=20+/*=0D=
=0A>=20+=20*=20samsung_gpio_set_config=20will=20identify=20the=20type=20of=
=20PUD=20config=20based=0D=0A>=20+=20*=20on=20the=20gpiolib=20request=20to=
=20enable=20or=20disable=20the=20PUD=20configuration.=0D=0A>=20+=20*/=0D=0A=
>=20+static=20int=20samsung_gpio_set_config(struct=20gpio_chip=20*gc,=20uns=
igned=20int=20offset,=0D=0A>=20+=09=09=09=09=20=20=20unsigned=20long=20conf=
ig)=0D=0A>=20+=7B=0D=0A>=20+=09struct=20samsung_pin_bank=20*bank=20=3D=20gp=
iochip_get_data(gc);=0D=0A>=20+=09unsigned=20long=20flags;=0D=0A>=20+=09uns=
igned=20int=20value=20=3D=200;=0D=0A>=20+=0D=0A>=20+=09switch=20(pinconf_to=
_config_param(config))=20=7B=0D=0A>=20+=09case=20PIN_CONFIG_BIAS_DISABLE:=
=0D=0A>=20+=09=09value=20=3D=20DISABLE_PIN_PULL_UP_DOWN;=0D=0A>=20+=09=09br=
eak;=0D=0A>=20+=09case=20PIN_CONFIG_BIAS_PULL_DOWN:=0D=0A>=20+=09=09value=
=20=3D=20ENABLE_PIN_PULL_DOWN;=0D=0A>=20+=09=09break;=0D=0A>=20+=09case=20P=
IN_CONFIG_BIAS_PULL_UP:=0D=0A>=20+=09=09value=20=3D=20ENABLE_PIN_PULL_UP;=
=0D=0A>=20+=09=09break;=0D=0A>=20+=09default:=0D=0A>=20+=09=09return=20-ENO=
TSUPP;=0D=0A>=20+=09=7D=0D=0A>=20+=0D=0A>=20+=09raw_spin_lock_irqsave(&bank=
->slock,=20flags);=0D=0A>=20+=09samsung_gpio_set_pud(gc,=20offset,=20value)=
;=0D=0A>=20+=09raw_spin_unlock_irqrestore(&bank->slock,=20flags);=0D=0A>=20=
+=09return=200;=0D=0A>=20+=7D=0D=0A>=20+=0D=0A>=20=20static=20const=20struc=
t=20gpio_chip=20samsung_gpiolib_chip=20=3D=20=7B=0D=0A>=20=20=09.request=20=
=3D=20gpiochip_generic_request,=0D=0A>=20=20=09.free=20=3D=20gpiochip_gener=
ic_free,=0D=0A>=20=40=40=20-948,6=20+998,7=20=40=40=20static=20const=20stru=
ct=20gpio_chip=20samsung_gpiolib_chip=20=3D=20=7B=0D=0A>=20=20=09.direction=
_output=20=3D=20samsung_gpio_direction_output,=0D=0A>=20=20=09.to_irq=20=3D=
=20samsung_gpio_to_irq,=0D=0A>=20=20=09.add_pin_ranges=20=3D=20samsung_add_=
pin_ranges,=0D=0A>=20+=09.set_config=20=3D=20samsung_gpio_set_config,=0D=0A=
>=20=20=09.owner=20=3D=20THIS_MODULE,=0D=0A>=20=20=7D;=0D=0A>=20=0D=0A>=20d=
iff=20--git=20a/drivers/pinctrl/samsung/pinctrl-samsung.h=0D=0A>=20b/driver=
s/pinctrl/samsung/pinctrl-samsung.h=0D=0A>=20index=20ab791afaabf5..23b70ddc=
accc=20100644=0D=0A>=20---=20a/drivers/pinctrl/samsung/pinctrl-samsung.h=0D=
=0A>=20+++=20b/drivers/pinctrl/samsung/pinctrl-samsung.h=0D=0A>=20=40=40=20=
-61,6=20+61,13=20=40=40=20enum=20pincfg_type=20=7B=0D=0A>=20=20=23define=20=
PIN_CON_FUNC_INPUT=09=090x0=0D=0A>=20=20=23define=20PIN_CON_FUNC_OUTPUT=09=
=090x1=0D=0A>=20=0D=0A>=20+/*=0D=0A>=20+=20*=20Values=20for=20the=20pin=20P=
UD=20register.=0D=0A>=20+=20*/=0D=0A>=20+=23define=20DISABLE_PIN_PULL_UP_DO=
WN=090x0=0D=0A>=20+=23define=20ENABLE_PIN_PULL_DOWN=09=090x1=0D=0A>=20+=23d=
efine=20ENABLE_PIN_PULL_UP=09=090x3=0D=0AUse=20consistent=20naming=20conven=
tions=20as=20per=20this=20file,=20so=20=0D=0APIN_PUD_PULL_UP_DOWN_DISABLE=
=0D=0APIN_PUD_PULL_DOWN_ENABLE=0D=0APIN_PUD_PULL_UP_ENABLE=0D=0A=0D=0A>=20+=
=0D=0A>=20=20/**=0D=0A>=20=20=20*=20enum=20eint_type=20-=20possible=20exter=
nal=20interrupt=20types.=0D=0A>=20=20=20*=20=40EINT_TYPE_NONE:=20bank=20doe=
s=20not=20support=20external=20interrupts=0D=0A>=20--=0D=0A>=202.17.1=0D=0A=
=0D=0A=0D=0A