Received-SPF: pass (google.com: domain of linux-kernel+bounces-194860-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\))
Subject: Re: [PATCH net-next] net: smc91x: Refactor SMC_* macros
From: Thorsten Blum <thorsten.blum@toblux.com>
In-Reply-To: <20240529171740.0643a5a1@kernel.org>
Date: Thu, 30 May 2024 03:53:00 +0200
Cc: Nicolas Pitre <nico@fluxnic.net>,
 "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>,
 Paolo Abeni <pabeni@redhat.com>,
 Breno Leitao <leitao@debian.org>,
 =?utf-8?Q?Uwe_Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>,
 Andrew Lunn <andrew@lunn.ch>,
 John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
 Arnd Bergmann <arnd@arndb.de>,
 netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <A004D09E-E9CC-4DD4-ADE7-791D63D962D3@toblux.com>
References: <20240528104421.399885-3-thorsten.blum@toblux.com>
 <20240529171740.0643a5a1@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>

On 30. May 2024, at 02:17, Jakub Kicinski <kuba@kernel.org> wrote:
> On Tue, 28 May 2024 12:44:23 +0200 Thorsten Blum wrote:
>> Use the macro parameter lp directly instead of relying on ioaddr =
being
>> defined in the surrounding scope.
>=20
> Have you tested this, or just compile tested (please mention what
> testing has been done in the commit message in the future)?

Just compile tested.

> What's the motivation - cleanup or this helps remove some warnings?
> (again, please mention in the commit message)

It's a cleanup suggested by Andrew Lunn [1][2]. His suggestion might=20
have been for SMC_PUSH_DATA() and SMC_PULL_DATA() only; or to add=20
another macro param for ioaddr if lp->base and ioaddr are different (as=20=

in smc_probe()).

> AFAICT this will break smc_probe().

Yes, it does break smc_probe(). I'll fix it and submit a v2.

Thanks,
Thorsten

[1] =
https://lore.kernel.org/linux-kernel/0efd687d-3df5-49dd-b01c-d5bd977ae12e@=
lunn.ch/
[2] =
https://lore.kernel.org/linux-kernel/f192113c-9aee-47be-85f6-cd19fcb81a5e@=
lunn.ch/=