Received-SPF: pass (google.com: domain of linux-kernel+bounces-194905-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <ad3d0781-08aa-4cab-8dc8-eaf753c6671a@linux.intel.com>
Date: Thu, 30 May 2024 11:09:45 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Cc: baolu.lu@linux.intel.com, David Airlie <airlied@gmail.com>,
 Daniel Vetter <daniel@ffwll.ch>, Kalle Valo <kvalo@kernel.org>,
 Bjorn Andersson <andersson@kernel.org>,
 Mathieu Poirier <mathieu.poirier@linaro.org>,
 Alex Williamson <alex.williamson@redhat.com>, mst@redhat.com,
 Jason Wang <jasowang@redhat.com>, Thierry Reding <thierry.reding@gmail.com>,
 Jonathan Hunter <jonathanh@nvidia.com>,
 Mikko Perttunen <mperttunen@nvidia.com>, iommu@lists.linux.dev,
 dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/20] iommu: Add iommu_paging_domain_alloc() interface
To: Yi Liu <yi.l.liu@intel.com>, Joerg Roedel <joro@8bytes.org>,
 Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>,
 Jason Gunthorpe <jgg@ziepe.ca>, Kevin Tian <kevin.tian@intel.com>
References: <20240529053250.91284-1-baolu.lu@linux.intel.com>
 <20240529053250.91284-6-baolu.lu@linux.intel.com>
 <eedb1df0-e745-4b48-9261-faa0ff320ee9@intel.com>
 <dc9fa861-628f-4a96-ae37-e419b23c6ea0@linux.intel.com>
Content-Language: en-US
From: Baolu Lu <baolu.lu@linux.intel.com>
In-Reply-To: <dc9fa861-628f-4a96-ae37-e419b23c6ea0@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 5/30/24 9:59 AM, Baolu Lu wrote:
> On 5/29/24 5:04 PM, Yi Liu wrote:
>> On 2024/5/29 13:32, Lu Baolu wrote:
>>> Commit <17de3f5fdd35> ("iommu: Retire bus ops") removes iommu ops from
>>> bus. The iommu subsystem no longer relies on bus for operations. So the
>>> bus parameter in iommu_domain_alloc() is no longer relevant.
>>>
>>> Add a new interface named iommu_paging_domain_alloc(), which explicitly
>>> indicates the allocation of a paging domain for DMA managed by a kernel
>>> driver. The new interface takes a device pointer as its parameter, that
>>> better aligns with the current iommu subsystem.
>>
>> you may want to move this patch before patch 03/04.
> 
> Emm, why?

I see. The commit subject is misleading. It should be "vfio/type1: Use
iommu_user_domain_alloc()".

Best regards,
baolu