Received-SPF: pass (google.com: domain of linux-kernel+bounces-194938-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <873b7a7b-139d-498e-89da-098cb3d7599d@amd.com>
Date: Wed, 29 May 2024 23:41:12 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] drm/client: Detect when ACPI lid is closed during
 initialization
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
 =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
 Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>,
 David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
 linux-kernel@vger.kernel.org, Chris Bainbridge <chris.bainbridge@gmail.com>,
 hughsient@gmail.com
References: <20240528210319.1242-1-mario.limonciello@amd.com>
 <Zlc4V1goFvU2antl@intel.com> <197d195f-9206-41dd-8ff1-f4bb4988fb9b@amd.com>
 <ZldMKZ1MzSDXOheJ@intel.com>
 <g34f3sdk22grheq2vaaonkl543dtk7nb5sffqgmkl5ywtj5skk@p5ht5ug33q4z>
Content-Language: en-US
From: "Limonciello, Mario" <mario.limonciello@amd.com>
In-Reply-To: <g34f3sdk22grheq2vaaonkl543dtk7nb5sffqgmkl5ywtj5skk@p5ht5ug33q4z>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?c1M0M3E0anozSjR2YVJSQ3g1VEJRTjNVb2MvOGg0ZFRtVjNRckdub2twMlhn?=
 =?utf-8?B?Z1p1UDM1Yi9INDdaNktEUEowbEJmanhNYTI1bUxKZElxWk4wQXYvYWdRR2ZP?=
 =?utf-8?B?UjJKWXZCOUZITlkxa0g3dU5iK1RVVnVCakN5bTdxNnRTTFdGdzJFcVMwcUNM?=
 =?utf-8?B?R0hNL01TQ2thbzBueHNKZFNncFJSQWVBLzRkNkZ1NmRzWTVLcW94VTBQZGNG?=
 =?utf-8?B?RHY2VnM0YzhzSzdiSDRDQk9iRzRlTStmU0lrVjZpSkNSaUlSMU44MFFiNFI1?=
 =?utf-8?B?N0lhTFQ5dzBMTmVIN3RldXBrQW1VcFdBcGpuSDQvRWhubHBGWHRRRTJRQ3lp?=
 =?utf-8?B?ODdibGtUaFEwZWVVenBMenRqdmVtOElycnRYaHd5eGVkZ3F0d1hqNUd3aGVW?=
 =?utf-8?B?VDVKNVBvYWRzay85T1d5TndaSnlBeXdpK0pHT3pqVGdEMklnVmh6bTNWZUtV?=
 =?utf-8?B?bDNhZEt5eXVhS04rNzc2WUptdTFrV3BWOFI4eTRLRGRnSVJOZzJVcFI4OS9y?=
 =?utf-8?B?WG03WFpWUHBHTElFLytabUxzS0E1WTlETVliWVQvdkoyZ0VrU0NXeGdVMk4y?=
 =?utf-8?B?WGQ2WER4VXV1bHl0R2JVRld2cC9sMzJ5Z214ODNMS1VpemtiaGZ1WWoreEY1?=
 =?utf-8?B?bTZYd00vQmIzSzZmMGtYRnAxSkpnZ0hzN0NUYzJtVjhac2RGdEEyWjZ3S3Ar?=
 =?utf-8?B?V2I4UzZRNHpTdnluNUxVV2RFbUxJeXdBcnkzSFM3NXNBNk0xZGIvclVjbU5E?=
 =?utf-8?B?Tjh0anFGRHUzdHRUNGMrRko4ZkVzZy9hblVVNlNhNUdQKzBWYTJKNzVieGJx?=
 =?utf-8?B?Qk80VHRPSGg2TE1meGVZbVlXSUt3RmxKRXQ2Skp0K3JCVzIwcUZmeHQyTlp2?=
 =?utf-8?B?NVFZcHB2SURHdUZJbHhMTmcxbndacjViVlhMV202NkY4QnBGMEN6SWk2RVlL?=
 =?utf-8?B?cStmWFR3aklBZDgzOEdOSFZseTlCazhHdkRRUEY4WFBPMWh3N1dueWxFbWlo?=
 =?utf-8?B?WnRjaXdnWkJYMlJzNENlaHU2L2p2dzRrQ2lpZVRacDk0eWgweEdSbGhEazVo?=
 =?utf-8?B?cFJOSGMra0p1QVZEZEhoT0g0bzBibjVMVmwyUTdoS3BvYkRGYWpCdHppek0z?=
 =?utf-8?B?cE9FdnhSTFFiOERUOWZUd3NGV0ZDL0s0aEpoeCt2eE56N0l0ay9VbmxZdm5h?=
 =?utf-8?B?VzFDaHdrTDl3S1RLV0VCMDc2VDZZRjQwQ0gxcnlBc1ZjaFBOTDBSNGJicVdF?=
 =?utf-8?B?eDVVTk9LZEp1ZjhDUU9FMzV5bDRMKzRwbTl6aS9Bd2VIVnprdWxrUUt6TVpQ?=
 =?utf-8?B?eEdYcmdjd3ZWbmp5akxNMDBHTHFnSUozajU0bFNod3RQcC9DMGhZVE15Z01D?=
 =?utf-8?B?MWJaT2s0UmpsT1hhbG9mNXBNOXJxT3lzRjNicDlRZHNBUW9OY1VrMFRVWW5G?=
 =?utf-8?B?eXNKYnZ1aWxwK0MyRW94Y2tnVm5tSU9iNi9EUDVHWWdzMDZJOW02UllnZ2V5?=
 =?utf-8?B?R29jbE42SEs4SCt6dkFEcjFaUnk5bkNOcThaNGlTKzlucHAvbWJ3MFRCZGdl?=
 =?utf-8?B?aE1DYW9Dd294S0hXT0xuMXh2RDVCeSsrWmdMLyt3OEhIQm1kMVVsa0dQZEo4?=
 =?utf-8?B?SndkWk9VRnNzSzNMR3ZzYk9BVW56Mi92QW53MnJZUy82VnMxMTl6SUEwb1lX?=
 =?utf-8?B?QWYzcHM5aVl3MjhLNExRMlpyWjdrV2l6RkhxaU5TNjE2ZENtVHdBbEFOZ2JB?=
 =?utf-8?B?WDIyV2NTOVdIMS9IazJvTGRGZG5qZ0ZmUnhxUGYxTGRzaVg1NldlYWRMWm5D?=
 =?utf-8?B?RVFsUlpzRGdJNzBYbTNiamgrdlFYdzV1TnpUV2JOUThKVkdlQUFPbXFLb0R4?=
 =?utf-8?B?S3h0dFJhbXBWZjUzYXMvOWJmazIxeERxWFVKczZTRVVwQWxvWStQaThHY1p3?=
 =?utf-8?B?UmtXUzc1MzhkaEI4Q1JNUDJJSjBQTU1vSklWNXJ0UkFjWHNnN0cyZ1llYU9M?=
 =?utf-8?B?Wm1LQnNVUmVWT0N2U0tONEJHb1BpWUVKdHhuY2UvSElnUjNjOWFrSkxuRmdD?=
 =?utf-8?B?d1pYT0NnanpBUkVMcTVlMmc3SzlvTzdOcmNvem1HQXQxdjRDWHZNR2FsMUoz?=
 =?utf-8?Q?oYq1D3vSTT1VD+Hqy71cgkhf1?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f6ca288c-5d9d-44e9-38b0-08dc8062bdf1
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 04:41:16.2969
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cA3StnI0+0/wer/09otnb/KGuGMXw+nrDZqrZ6gkxcN8ELxG4NWCgYxEOQDVaXFwqUoR/cWH4+nn3v5eyN2qHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5748


>> Also a direct acpi_lid_open() call seems a bit iffy. But I guess if
>> someone needs this to work on non-ACPI system they get to figure out
>> how to abstract it better. acpi_lid_open() does seem to return != 0
>> when ACPI is not supported, so at least it would err on the side
>> of enabling everything.
> 
> Thanks. I was going to comment, but you got it first. I think a proper
> implementation should check for SW_LID input device instead of simply
> using acpi_lid_open(). This will handle the issue for other,
> non-ACPI-based laptops.
> 

Can you suggest how this would actually work?  AFAICT the only way to 
discover if input devices support SW_LID would be to iterate all the 
input devices in the kernel and look for whether ->swbit has SW_LID set.

This then turns into a dependency problem of whether any myriad of 
drivers have started to report SW_LID.  It's also a state machine 
problem because other drivers can be unloaded at will.

And then what do you if more than one sets SW_LID?

IOW - a lot of complexity for a non-ACPI system.  Does such a problem 
exist in non-ACPI systems?