Received-SPF: pass (google.com: domain of linux-kernel+bounces-194959-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: "Rout, ChandanX" <chandanx.rout@intel.com>
To: "Zaremba, Larysa" <larysa.zaremba@intel.com>,
	"intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
	"Keller, Jacob E" <jacob.e.keller@intel.com>
CC: "Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>, "Jesper Dangaard
 Brouer" <hawk@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, "Kitszel,
 Przemyslaw" <przemyslaw.kitszel@intel.com>, John Fastabend
	<john.fastabend@gmail.com>, Alexei Starovoitov <ast@kernel.org>, "David S.
 Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>, Jakub Kicinski
	<kuba@kernel.org>, "bpf@vger.kernel.org" <bpf@vger.kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Magnus Karlsson <magnus.karlsson@gmail.com>, "Bagnucki,
 Igor" <igor.bagnucki@intel.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "Kuruvinakunnel, George"
	<george.kuruvinakunnel@intel.com>, "Pandey, Atul" <atul.pandey@intel.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net 1/3] ice: remove af_xdp_zc_qps
 bitmap
Thread-Topic: [Intel-wired-lan] [PATCH iwl-net 1/3] ice: remove af_xdp_zc_qps
 bitmap
Thread-Index: AQHapuJRbS/eNf6gdUKKM3kTrFGqCrGvXNrg
Date: Thu, 30 May 2024 05:53:42 +0000
Message-ID: <CH3PR11MB83134F4EC024CDB544040707EAF32@CH3PR11MB8313.namprd11.prod.outlook.com>
References: <20240515160246.5181-1-larysa.zaremba@intel.com>
 <20240515160246.5181-2-larysa.zaremba@intel.com>
In-Reply-To: <20240515160246.5181-2-larysa.zaremba@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yLsiC2pUMAmJeT5ac4VFfe0R48+wwJ85KRdmcrP0+kTZKG/DUgNtPnSW18Ym?=
 =?us-ascii?Q?7KzGWU1YC761NOA1et5uN3xCaAEpmnQ5mRpZxFJzTPFHaDyeR7CS9c9hfZho?=
 =?us-ascii?Q?tpLuF9sG2Z18dnYK8lcyhpLxB2igNwfOXfuvE5aQmf6N438pQhCyB/dD+LV0?=
 =?us-ascii?Q?yAWq8j+cdJxEaUBOrzibgx0hmVsB6bqJAs5SdOXpAvNFauIVWgL8QEW0b246?=
 =?us-ascii?Q?rjQMJXZXGvl7+MwXgt2pwryLQL0CVPoqTacYA98F9Zu+mflw8Eyia5uVQYSh?=
 =?us-ascii?Q?9K7PUeKamUDpbmgZuXrLaKHfoHSvklWlftCkP6PIpoV5UnTUynFXWCaUOC++?=
 =?us-ascii?Q?Vi1NYwXSTgYNo7BdFsBtq20i4YDXHlYB1jylk3CllWjo96y7fAfwrxJaABcx?=
 =?us-ascii?Q?9a5z+ftnJ6mQBTQzKmmluM6Dsi0NuwojDG5xRmNNs2yRocBgDfULsQYdSHcz?=
 =?us-ascii?Q?LeABugd6DcnlXOmn0C1UKWrO49f3jPI2KSOSkBJw3LecquGAvHT/MxeOKW9Y?=
 =?us-ascii?Q?hlzC9kErU/0Xeub8r8ktoWAIzqs8roBzH2E2cBT49YrGEXEvHa5/AARynqDA?=
 =?us-ascii?Q?mj74PbmQMl7N05Kvb7NXkwrAS6r1WONhPgSfhPsdlUrOto0nXGCv7Qz3E7DN?=
 =?us-ascii?Q?V3H9zE3d3FP/lcGFsYT31GooIa8gkA1ApgXG7hwMzkinqE5nsAqhDHqksIhl?=
 =?us-ascii?Q?6jE/gXJZ/IGbQB04pOS14dQnsl+Ra01gsXX25/BrimN7he8T9hdNPZxcrds8?=
 =?us-ascii?Q?Uu2RVViOgVj2hSZvfmCsZ+ic9Md3V2602weGPOobowGUoSeXwUVK2I/naAKR?=
 =?us-ascii?Q?SiBcO8xdYtS4Jk08iPgXLU8U3tjzUHpDzsvPtj/oKtam1eiiCDRedLabeL/e?=
 =?us-ascii?Q?LgAY7HoL1eKXyiNo1hZw0kn3AyZ741Gzv28uFTfVZAt7DuL0E8t7PsKXYw5w?=
 =?us-ascii?Q?raD43odY56OTodtDl720ZUHSLJP5ox2yggD/8HwvR7Vwyu7Q0Qy5BgndMPc1?=
 =?us-ascii?Q?TSE6SbU9iwkm9+CZopspeibCxEtnk+3tAzar955p1kERGjqdGQ0HVAjOZ/wf?=
 =?us-ascii?Q?PuONWjMo3GQiPNnhuVZ4AlG1T5jF/fiGaHokKEylv93N0Al+WFH9LkcAEPMS?=
 =?us-ascii?Q?djl9cseMD+iN8eEt+cWIwiOrYauuoxL9AO0auGup6FA71dFPfa0MoelLrZrQ?=
 =?us-ascii?Q?9E84JH23CC6QBBke4YcFOpHRSvTURL4lKHCx/nqj7G+lPTG3eBhuVKEJgtFB?=
 =?us-ascii?Q?GuBnyWr3uBYOfmEYxkboutZGWa1oz0RmyOh1zwx8YNALiJb+gh4OEkjS38y3?=
 =?us-ascii?Q?Bkm/kaHvhubXu1gsScR27uYYG5GQ2k+OS3k/n5hEwhyUiXKXFNr2AMo9caLU?=
 =?us-ascii?Q?ly5zSSQBgKZ2WVX/jH4NyQmqdzsEY8VV8d4RkRb4ihHbLxGQqwWW5QM+72GI?=
 =?us-ascii?Q?9K/crYzeNpPa4WdoFf6bSkkUJXehVW7ew8ZLzWP1JrS/0OtzSsPCgG4APPZ1?=
 =?us-ascii?Q?EIJXEFY1hyZUjdssvSkWWWmkutIFQFmHt2gSXclw8AOGI73qwQSTMJDrhU9X?=
 =?us-ascii?Q?Ff+F7I02FttaeViHxrDJl5DbfZwIAssT9pH00aWV?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CH3PR11MB8313.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 368c4fbd-290c-4f80-97e5-08dc806cdc76
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 May 2024 05:53:42.3268
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ggmupPfZOs0/U+X2l3wjIxzsmkeUgtymN/6H5NMB/LfGW53brGMeGg36W9Md9/ZmR0Y4bG7LMzDS/KlsYmOb1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7204
X-OriginatorOrg: intel.com


>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
>Zaremba, Larysa
>Sent: Wednesday, May 15, 2024 9:32 PM
>To: intel-wired-lan@lists.osuosl.org; Keller, Jacob E <jacob.e.keller@inte=
l.com>
>Cc: Fijalkowski, Maciej <maciej.fijalkowski@intel.com>; Jesper Dangaard Br=
ouer
><hawk@kernel.org>; Daniel Borkmann <daniel@iogearbox.net>; Zaremba,
>Larysa <larysa.zaremba@intel.com>; Kitszel, Przemyslaw
><przemyslaw.kitszel@intel.com>; John Fastabend
><john.fastabend@gmail.com>; Alexei Starovoitov <ast@kernel.org>; David S.
>Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>;
>netdev@vger.kernel.org; Jakub Kicinski <kuba@kernel.org>;
>bpf@vger.kernel.org; Paolo Abeni <pabeni@redhat.com>; Magnus Karlsson
><magnus.karlsson@gmail.com>; Bagnucki, Igor <igor.bagnucki@intel.com>;
>linux-kernel@vger.kernel.org
>Subject: [Intel-wired-lan] [PATCH iwl-net 1/3] ice: remove af_xdp_zc_qps
>bitmap
>
>Referenced commit has introduced a bitmap to distinguish between ZC and
>copy-mode AF_XDP queues, because xsk_get_pool_from_qid() does not do
>this for us.
>
>The bitmap would be especially useful when restoring previous state after
>rebuild, if only it was not reallocated in the process. This leads to e.g.
>xdpsock dying after changing number of queues.
>
>Instead of preserving the bitmap during the rebuild, remove it completely =
and
>distinguish between ZC and copy-mode queues based on the presence of a
>device associated with the pool.
>
>Fixes: e102db780e1c ("ice: track AF_XDP ZC enabled queues in bitmap")
>Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
>---
> drivers/net/ethernet/intel/ice/ice.h     | 32 ++++++++++++++++--------
> drivers/net/ethernet/intel/ice/ice_lib.c |  8 ------
>drivers/net/ethernet/intel/ice/ice_xsk.c | 13 +++++-----
> 3 files changed, 27 insertions(+), 26 deletions(-)
>

Tested-by: Chandan Kumar Rout <chandanx.rout@intel.com> (A Contingent Worke=
r at Intel)