Received-SPF: pass (google.com: domain of linux-kernel+bounces-194978-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 30 May 2024 09:07:23 +0300
Message-Id: <D1MR5P0W2DSW.MI93JIMHBXKI@kernel.org>
Cc: "Paul Moore" <paul@paul-moore.com>, "Fan Wu"
 <wufan@linux.microsoft.com>, <corbet@lwn.net>, <zohar@linux.ibm.com>,
 <jmorris@namei.org>, <serge@hallyn.com>, <tytso@mit.edu>,
 <axboe@kernel.dk>, <agk@redhat.com>, <snitzer@kernel.org>,
 <mpatocka@redhat.com>, <eparis@redhat.com>, <linux-doc@vger.kernel.org>,
 <linux-integrity@vger.kernel.org>, <linux-security-module@vger.kernel.org>,
 <fsverity@lists.linux.dev>, <linux-block@vger.kernel.org>,
 <dm-devel@lists.linux.dev>, <audit@vger.kernel.org>,
 <linux-kernel@vger.kernel.org>, "Deven Bowers"
 <deven.desai@linux.microsoft.com>
Subject: Re: [PATCH v19 15/20] fsverity: expose verified fsverity built-in
 signatures to LSMs
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Eric Biggers" <ebiggers@kernel.org>
References: <1716583609-21790-16-git-send-email-wufan@linux.microsoft.com>
 <06bb61dc838eeff63bb5f11cea6d4b53@paul-moore.com>
 <D1MQTEW77RY8.36THC7YDK7CZO@kernel.org>
 <20240530060120.GB29189@sol.localdomain>
In-Reply-To: <20240530060120.GB29189@sol.localdomain>

On Thu May 30, 2024 at 9:01 AM EEST, Eric Biggers wrote:
> On Thu, May 30, 2024 at 08:51:21AM +0300, Jarkko Sakkinen wrote:
> > On Thu May 30, 2024 at 4:44 AM EEST, Paul Moore wrote:
> > > > +	err =3D security_inode_setintegrity(inode,
> > > > +					  LSM_INT_FSVERITY_BUILTINSIG_VALID,
> > > > +					  signature,
> > > > +					  le32_to_cpu(sig_size));
> > >
> > > I like this much better without the explicit inode cast :)
> >=20
> > Would be nice btw if that was 'ret' or 'rc' because err is such
> > a common name for exception handler alike goto-labels... Looks
> > confusing just because of that :-)
> >=20
>
> A lot of kernel code, including the rest of fs/verity/, uses the conventi=
on that
> "0 or negative errno" return values are named 'err' (and return values th=
at
> aren't necessarily an errno are named something else).  So it's fine as-i=
s.

Right, just hadn't seen such naming convention before.

BR, Jarkko