Received-SPF: pass (google.com: domain of linux-kernel+bounces-195001-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 30 May 2024 09:17:03 +0200 (CEST)
From: Ricard Wanderlof <ricardw@axis.com>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
cc: Andrzej Hajda <andrzej.hajda@intel.com>, 
    Neil Armstrong <neil.armstrong@linaro.org>, Robert Foss <rfoss@kernel.org>, 
    Laurent Pinchart <Laurent.pinchart@ideasonboard.com>, 
    Jonas Karlman <jonas@kwiboo.se>, Jernej Skrabec <jernej.skrabec@gmail.com>, 
    Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, 
    Maxime Ripard <mripard@kernel.org>, 
    Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, 
    Daniel Vetter <daniel@ffwll.ch>, dri-devel@lists.freedesktop.org, 
    linux-kernel@vger.kernel.org, kernel@axis.com
Subject: Re: [PATCH] drm: bridge: adv7511: Accept audio sample widths of 32
 bits via I2S
In-Reply-To: <m7sghjgqtm45yjkpzrekeab7doojagxjts7vmw23a3tqtjltdj@v2oencka3uer>
Message-ID: <adac6043-19f1-e965-e9eb-f3f1eaa6e067@axis.com>
References: <91472c14-3aeb-766a-1716-8219af6e8782@axis.com> <m7sghjgqtm45yjkpzrekeab7doojagxjts7vmw23a3tqtjltdj@v2oencka3uer>
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Pd2wnZYR87Y9R89I7S3khWKH3oqnUvNtIkKGkGDnFAYRIcxTNlAAZb0jziOs?=
 =?us-ascii?Q?BWhP7CEUVTeW+7s503Acrs7vA5fgfb5R0l5hwFHKPacH4tRQYyELlzqST5Fr?=
 =?us-ascii?Q?bL1G2Ex8+WwPjuKzQvwcwmqt6+Uv7VndOHFRx7OGKZ1sS2uGfMiXrcX916Wx?=
 =?us-ascii?Q?lQbhVKLE6gq/9jplZ2SLk7UR+xfrkOHwQU/7RqCIV3yJk3oF31kIW172+u2R?=
 =?us-ascii?Q?c8ML7OanC3oVoVxR7jOZnqz2HfSom7x55KwQWXadZC0rTaRvT/vbAA1uDAVh?=
 =?us-ascii?Q?2cv4fmialXrwPbTGrBBCwSRHhg7Q88gaEfOSsy2xG8kvL96JjAc1jsufbiM9?=
 =?us-ascii?Q?6B1uceTr9O0RJBdkoYvc8ibV0USJe44L51QlkL31aVbQKJbZVhRd2Oae1HJW?=
 =?us-ascii?Q?xYTKK+93ZTqL7yZlpPSwSEQ8i/UsV/relFtry+1c4U6XKmlvLHS7cNyC/AOS?=
 =?us-ascii?Q?Rbd7MkAAi9UwPYz6FSYZ3+hyoJb+ulACIrS7OrCAkGtVEzA0keRXg1wxhvy/?=
 =?us-ascii?Q?yvIblDY+dzRDCxbrd0aLmyP/5+GuKOLvg87/GO1Ba8U4NnMqs32sxaZEAmVW?=
 =?us-ascii?Q?slTsFsGmf7Ot6gJPJmsrYLugU+NeOPMoVcrgiNsZoKd8FtcVerXN3QxXHiVx?=
 =?us-ascii?Q?QxivWNIAljnYJACAsHkZlxiaVz5LoR1dqk9DQ8R4Sc88sITxK0BLXMq5gu18?=
 =?us-ascii?Q?Mm0n5RekL4Vwhn8PchVQw7TUHpO1M5Kv/OAbX4Wp05NMCWgCk36/cMVrNKST?=
 =?us-ascii?Q?hcvf32iGB79POdvCNngMFJcpTC6TVkgAVW0Su2s93wrCTmIoC79HHW7gSosu?=
 =?us-ascii?Q?Q0NcdJCHQdnLiyjsI7UA2sQWxf6HV58oyWowNrxj1L/GLFDqgtuH2OJy88Kx?=
 =?us-ascii?Q?ELRMzMqMxZBhuJqOTZs5jlg7IQOOrNtetzpR3xKQ/z8AXEj5XQLRaQYYXOrH?=
 =?us-ascii?Q?p0RuzayLUxeQ7SgiaWRDw6+GiwJ0C2fsCdqYXTT0fJ+9fUmU2XZ2unon1ePD?=
 =?us-ascii?Q?TaRrESim5UUgRwQdRi8AQXyYUIya2hwv6o8DGN0ehomZqc2EF+XgTmE/zJ4U?=
 =?us-ascii?Q?kKf48v7snIfaBpbJi/oD2iy0EPg9CDTEBEp0C5El3M4MB7o1kqiLwcxwF7eV?=
 =?us-ascii?Q?wB2dgbGsiAOSs9QolaRvOuVGcw57HrdrN98vE4QO+r9YfFBg5+4VYgIQKthG?=
 =?us-ascii?Q?Xde07QiWKheZXlh3u/bcFTj/jbEciMydz0a+BkauAM5Lb6MGyRqnNaSgy2Ib?=
 =?us-ascii?Q?59vBQ8zfrR3xwKVBcZttWknUtjBOrS+JA/PmOxAwVD9qDXvSh+17TQUm4loB?=
 =?us-ascii?Q?exq73jqOb0h5wZufCmVbe5rTBQ61Y+iypmrPGIbYBDmVXpvW6j1q3Mmt7l/p?=
 =?us-ascii?Q?RMwKDI3hNXccQk4inIlssGRyFbcWVRlvqJH66Z5pKY6hoVJdEGBsvXsmnjFQ?=
 =?us-ascii?Q?iNSTNu7bMEkZaG4E1Ki2Z5fK/SYsMpEUqZ1Ni7/sDF9P6Uo5k6u3w8BZcJOq?=
 =?us-ascii?Q?G0voxH7l7F8X3Uq+hGV9EA2AtA0D/+yal29KbZQ7t2Gf+lJdEz+Rc6V1ujl/?=
 =?us-ascii?Q?sCpAejthLhIKwTmpVXY=3D?=
X-OriginatorOrg: axis.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a274d18f-90a3-4af3-dadb-08dc807881fa
X-MS-Exchange-CrossTenant-AuthSource: VI1PR02MB3229.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 07:17:04.7181
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eZJo5UJTbi8OP/V7enbELs2iacML/kIPrn34ZCxAP8ajXPTA5aPWMY5gvErzF7U22kyxEeoi8qOf9YQPXrp+RA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR02MB8957


On Tue, 28 May 2024, Dmitry Baryshkov wrote:

> On Tue, May 28, 2024 at 12:04:49PM +0200, Ricard Wanderlof wrote:
> > 
> > Even though data is truncated to 24 bits, the I2S interface does
> > accept 32 bit data (the slot widths according to the data sheet
> > can be 16 or 32 bits) so let the hw_params callback reflect this,
> > even if the lowest 8 bits are not used when 32 bits are specified.
> ...
> > ---
> >  drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 11 +++++++----
> >  1 file changed, 7 insertions(+), 4 deletions(-)
> > 
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> 
> What about:
> 
> Fixes: ae053fa234f4 ("drm: bridge: adv7511: Support I2S IEC958 encoded PCM format")
> 
> ?

IMHO, commit ae053fa234f4 doesn't break anything, so there's nothing to be 
fixed. It adds S/PDIF support, which uses a 32 bit format, but the 32 bit 
format was not supported at all prior to that commit.

I don't really have a problem adding the Fixes tag if you think it's 
useful, but it doesn't seem quite right to me.

/Ricard
-- 
Ricard Wolf Wanderlof                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30