Received-SPF: pass (google.com: domain of linux-kernel+bounces-195011-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <202405291318.4dfbb352-oliver.sang@intel.com> <CAHk-=wg29dKaLVo7UQ-0CWhja-XdbDmUOuN7RrY9-X-0i-wZdA@mail.gmail.com>
In-Reply-To: <CAHk-=wg29dKaLVo7UQ-0CWhja-XdbDmUOuN7RrY9-X-0i-wZdA@mail.gmail.com>
From: Yafang Shao <laoar.shao@gmail.com>
Date: Thu, 30 May 2024 15:37:13 +0800
Message-ID: <CALOAHbDYSXzv-c-bOBTR0Rp70zZWGWBG0Hwd-0OkA-YzA-QHtg@mail.gmail.com>
Subject: Re: [linus:master] [vfs] 681ce86235: filebench.sum_operations/s -7.4% regression
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: kernel test robot <oliver.sang@intel.com>, oe-lkp@lists.linux.dev, lkp@intel.com, 
	linux-kernel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>, 
	Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>, Waiman Long <longman@redhat.com>, 
	Matthew Wilcox <willy@infradead.org>, Wangkai <wangkai86@huawei.com>, 
	Colin Walters <walters@verbum.org>, linux-fsdevel@vger.kernel.org, ying.huang@intel.com, 
	feng.tang@intel.com, fengwei.yin@intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 30, 2024 at 12:38=E2=80=AFAM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> On Tue, 28 May 2024 at 22:52, kernel test robot <oliver.sang@intel.com> w=
rote:
> >
> > kernel test robot noticed a -7.4% regression of filebench.sum_operation=
s/s on:
> >
> > commit: 681ce8623567 ("vfs: Delete the associated dentry when deleting =
a file")
>
> Well, there we are. I guess I'm reverting this, and we're back to the
> drawing board for some of the other alternatives to fixing Yafang's
> issue.

Hi Linus,

I just checked the test case webproxy.f[0], which triggered the regression.

This test case follows a deletefile-createfile pattern, as shown below:

  - flowop deletefile name=3Ddeletefile1, filesetname=3Dbigfileset
  - flowop createfile name=3Dcreatefile1, filesetname=3Dbigfileset, fd=3D1

It seems that this pattern is causing the regression. As we discussed
earlier, my patch might negatively impact this delete-create pattern.
The question is whether this scenario is something we need to address.
Perhaps it only occurs in this specific benchmark and doesn't
represent a real-world workload.

[0] https://github.com/filebench/filebench/blob/master/workloads/webproxy.f

>
> Al, did you decide on what approach you'd prefer?
>
>                      Linus


--=20
Regards
Yafang