Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp1136663lqb; Thu, 30 May 2024 00:56:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCX1PAGGdNbW6d7YsEU6OesvYjkwj8ENGK9gKlJHyEPptH52Pimma6IyZGLu+v89Ci4tK1GhpzyDBenB+w2LyNSQNRP8S2aXYvtLcQ0O8w== X-Google-Smtp-Source: AGHT+IFAmF5kUVYIQpkQXVqkqrP7XjrPaATEnUXxDiJ1f3MMyO2uH5JoVxy29hc6Z4i8vr0U76mj X-Received: by 2002:a05:6a21:613:b0:1b0:8b2:702a with SMTP id adf61e73a8af0-1b26460b314mr1165394637.51.1717055793670; Thu, 30 May 2024 00:56:33 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717055793; cv=pass; d=google.com; s=arc-20160816; b=RHiBkhavtuo6zOIEkyVqJvwb3+0RnXSL9daN0u969ZFy4wF3Phbm2xkF8hmjP7Knt+ p8clAdZJu6NTIdSArrPTQ7EmeHEAyid6ZVJSHtY7Wh+zmC2lKviwmJshX+oHSneqxqFn eyuPNGsgOfvcLMvF/SIVIVfQSZLb+fFm/ao0ww2qlGwC3UsGStrf5zPnf/CK8/B+KY1K bCPeox/OGVTy87U2ussd0ZQ0cK+OGkJkyoZw2Kev3YvfHFVwmyiZGeReud8KtP1xKKsM 78IWONPwBvcU14Nm4aibIpGU4JBoHbFdiJAu7edIXGWAAR5rnDqdF4sJH0hkqGfei6IU JAYw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=mzh/UiHdl5hzkg2InsW3LfBL/uIYipnNKCWbnh02pdg=; fh=2WWE6w6oaQS+3uxp5i+voU9QvpiPNu/JML3X0EoBZJo=; b=Jvyb8pIZ5jOjyF7HD+1dE3ec+b+VRVUaYihhGmOl0ToXNT9x70IFm8lmQ1a41wvORd O3qrn5cSnln21O1Htbm5ox4k5ewDC/LajsnSaSBTe9H2p0p0PQ8v+Uk+sZwp2VYhsbuS xj3GYnIPnvfGtFbEQolCD1r4aNV4Vr1YZEsKD4UJLK14RLP5YmPPfhepfRzCobnxgCWq 744+iSaJ2ju7l2jUDn5/SLgPfdoDqeExKsxVCRnPMjZV3D+GfJyZPp/ueSkYcSa3AlVJ /dTgx0RGkkwDAN5cDkfthcx2ql2YF7vPKvScY5mpuF5jBtzwuh01etblDqIb0hJ2wdgi mBAw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=molgen.mpg.de); spf=pass (google.com: domain of linux-kernel+bounces-195026-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-195026-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d9443c01a7336-1f44c970026si117170805ad.232.2024.05.30.00.56.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 00:56:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-195026-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=molgen.mpg.de); spf=pass (google.com: domain of linux-kernel+bounces-195026-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-195026-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id BC3A6B233B2 for ; Thu, 30 May 2024 07:56:30 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7986114375A; Thu, 30 May 2024 07:56:21 +0000 (UTC) Received: from mx3.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C6C920322; Thu, 30 May 2024 07:56:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=141.14.17.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717055781; cv=none; b=hdHyTlynsppRvHJ5TDCCwlvDBjVtQg/bQiL6LyWauDFuJHvCZwH5LM8BuWff7OYW2DtrMBm/A0oZ2XMeuD56TQs3oiL36AY0eINK9zMUSV81caBpZF8LFscVkowM+OtO7k+kqZOTrlB3VJplTP8GOrvCW7zKADNK2nareRz3afc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717055781; c=relaxed/simple; bh=jZYkJjTMMLj6Qp75t5LqXGLqfkGsSkYKiCFJDOFDvPU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=U3LfD0SiWo7epqvd9kCJGO1IEP4kvufAPLQ3w3v4FDsLCW+l7AlT6qg7voHAV7w+73t7YLCwa4zeL+oo/uTz21NhGoxuojaPqyqgrNPX0Mz5Osk98ELk8FvEULnDAJ/tTd/Fq+TPYgDfn/NXeAD/h54bNokSe6HqA+s2V4GanvM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de; spf=pass smtp.mailfrom=molgen.mpg.de; arc=none smtp.client-ip=141.14.17.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=molgen.mpg.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=molgen.mpg.de Received: from [141.14.13.3] (g258.RadioFreeInternet.molgen.mpg.de [141.14.13.3]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 8BF5D61E5FE01; Thu, 30 May 2024 09:55:33 +0200 (CEST) Message-ID: <8d61678f-7494-4c26-a039-f5db633ab140@molgen.mpg.de> Date: Thu, 30 May 2024 09:55:32 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Intel-wired-lan] [PATCH] ice: irdma hardware init failed after suspend/resume To: En-Wei WU Cc: jesse.brandeburg@intel.com, intel-wired-lan@lists.osuosl.org, rickywu0421@gmail.com, linux-kernel@vger.kernel.org, edumazet@google.com, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net, wojciech.drewek@intel.com References: <20240528100315.24290-1-en-wei.wu@canonical.com> <88c6a5ee-1872-4c15-bef2-dcf3bc0b39fb@molgen.mpg.de> <971a2c3b-1cd9-48c5-aa50-e3c441277f0a@molgen.mpg.de> Content-Language: en-US From: Paul Menzel In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Dear En-Wei, Thank you for your quick reply. Am 30.05.24 um 09:08 schrieb En-Wei WU: >> Sorry for being unclear. I meant, does resuming the system take longer >> now? (initcall_debug might give a clue.) > I've tested the S3 suspend/resume with the initcall_debug kernel > command option, and it shows no clear difference between having or not > having the ice_init_rdma in ice_resume: > Without ice_init_rdma: > ``` > [ 104.241129] ice 0000:86:00.0: PM: pci_pm_resume+0x0/0x110 returned 0 after 9415 usecs > [ 104.241206] ice 0000:86:00.1: PM: pci_pm_resume+0x0/0x110 returned 0 after 9443 usecs > ``` > With ice_init_rdma: > ``` > [ 122.749022] ice 0000:86:00.1: PM: pci_pm_resume+0x0/0x110 returned 0 after 9485 usecs > [ 122.749068] ice 0000:86:00.0: PM: pci_pm_resume+0x0/0x110 returned 0 after 9532 usecs > ``` Thank you for verifying this. Nice to hear, it has no impact. […] Kind regards, Paul