Received-SPF: pass (google.com: domain of linux-kernel+bounces-195035-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <138a7fb9-fd69-4c41-8a55-629321a28521@axis.com>
Date: Thu, 30 May 2024 10:02:09 +0200
User-Agent: Mozilla Thunderbird
From: Amna Waseem <Amna.Waseem@axis.com>
Subject: Re: [PATCH v2 2/2] hwmon: (ina2xx) Add device tree support to pass
 alert polarity
To: Guenter Roeck <linux@roeck-us.net>, Jean Delvare <jdelvare@suse.com>,
 Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>, linux-hwmon@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@axis.com
References: <20240529-apol-ina2xx-fix-v2-0-ee2d76142de2@axis.com>
 <20240529-apol-ina2xx-fix-v2-2-ee2d76142de2@axis.com>
 <6b87136a-01e7-4b4b-b36f-632cf59b4760@roeck-us.net>
Content-Language: en-US
In-Reply-To: <6b87136a-01e7-4b4b-b36f-632cf59b4760@roeck-us.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?dk1hUE16MDE3WnZheWI4OGtmUFh5UjhOSjg4UjFCd1M3WS9FNHdwQVQ4bGlD?=
 =?utf-8?B?dkd2ZHJQcll6c1MxZ3U2VzhuMnlSc1dZUEllUXBUK2dDTU9SUTU3V1RrSFBl?=
 =?utf-8?B?Ly9VaThGWjNPZHdPUk9nc3p3NWRwSzdwalZkN24wTHZkVDB2T0xseWpnL1NK?=
 =?utf-8?B?aEZXN1c3dmVpSmxYZzB5TnM2c2RudE1SUGN1NjNNOEpsNU14VzZvNlJpbjkw?=
 =?utf-8?B?RHJtemhOT0dLRllaZUFCditjVllQbStQTVp1dC9wblV3aVZackhpVlJ0UGtL?=
 =?utf-8?B?MFJQL2RzK2w3UEhlUTNPdm9wVk45VnAwRmR0M1FvL3AvN3d5eTFWaFNIK3By?=
 =?utf-8?B?bVpFenVQZFpzR05ZQ3Fkb1R1WkMwZFNTbmU2U3VZeHVnVi94S2VabldremtX?=
 =?utf-8?B?RUJ4dVNLUWJVTTMrWjRDeWZ5TVdlNVYyNG12eWpnQ0ViRmZZOFIwMndPa0dS?=
 =?utf-8?B?dGM4SlFEa0ZocWFzVE1jYVZEVHQ4bk92M0VaU1d2V2ttSGZ3NGdOM0NiRUhU?=
 =?utf-8?B?ZlJ3cEJrY21xTStLTFJrZXRzZEtMOXc1VUllb2h5cTRhTTZiUFRYWE1MdXlG?=
 =?utf-8?B?UmxDb3c4TGxsN0ZLUGd3Z1czd2c2MWtWQVl0SjJyVUZzd0ZRemRuMS9FMFdP?=
 =?utf-8?B?cXYzSkoxUnhYdUlmTGU0UFN0RXdqQWMya0EvRk5hYUpBeUVMY1lndTRqQldk?=
 =?utf-8?B?OTVPbkxQMXczRVVXYzZDMnVIYkp0ektIdFBtQXRmM3BwZXpJNmFzK3VFVWEr?=
 =?utf-8?B?WGxURlJ0QVZJWjh6Y0Q1bHZmZGcrVGlLN3dKenpMcTZHODBLUlJZWkEraXA5?=
 =?utf-8?B?VjNCalIySnRNUnA5VFhXdGpFZXdMNk1adkxCWVVobDFjZDU0T29yZDhxZDlo?=
 =?utf-8?B?VlNmOFprSXNFUExQS1o3RktvTngzNUgyVXBLa2dzL3FUNCtYdnVtT2pqbmNG?=
 =?utf-8?B?UDNVV1dQRWlQUjR1UjhXUkRMUTNSTlE1T1RWcGdJMWRCSzZ4TWFzWXpxOFVC?=
 =?utf-8?B?eTJJYmZWZW1kcHZVMy9Wd0IxbXplckJ4MEFaL3h0RVdIODQvVFVENHM0LzVq?=
 =?utf-8?B?QnBYZmV1b0RIdmlMeDY0REVXaGhKWU9MaVBBTUxsbGx2R0lJNnJRVVllWThv?=
 =?utf-8?B?a2Ztbkk3ZHU1WTNnZ0JtU2J0S0VrVWF0b0tmTXNHRUVqNm1xNGQwbWFKUnAx?=
 =?utf-8?B?dnRHNjJLSllWUWdmZFR5N2RxUVRuakU3WEhOSXJncXdURWhWTHE3K1duYU52?=
 =?utf-8?B?VFFtRHFUS202ZlFYVSthNlk0ODhJclRveXRVcEZxbml4bytKeXIxeGRTVWFw?=
 =?utf-8?B?YXRKMXNqaFR1Ujc5ZmgzUXdYdmRkdCt1MnNOYjFWK3M5SHhjM0tKVDJhVjhw?=
 =?utf-8?B?TTQwVHJpTzltRGMzQ09qK1lQcTYxeDJiTTEyNUxYaHgyRHZwd0VpNkpOMWdO?=
 =?utf-8?B?eUtDODBwdnFNNWJmYnk5UEsyd0g2ZW5RZG9WTkNILzRGN3h4TmYrdlp6VERI?=
 =?utf-8?B?WE1WZGp6ZXpFSkZvTDd2eXdtT1MxemRJRHFuV1hyWjQ4OGcyRXF5Y1crTWR6?=
 =?utf-8?B?MVAyTUM4bmEwNk9IYkNDakVKREEyYnR5Q0IzZ0Nva1ljaE41V1ptVGRhdUFU?=
 =?utf-8?B?bS8zVnFaVmNHOTVqYUZZNlV3ZS83U0RIRHdGemNTTkgzVEM3ZGZvZmxzeHM2?=
 =?utf-8?B?WnBmd3lidHJYSGNpT1liYm82enQ3eXRUR1F3V3NCMU9hRjYrZ2hBZ0FwUFVL?=
 =?utf-8?B?RGsvWi9LVFpvdHFNS3hrcGdiM2ZlSEo3cnREWW9wQVlqb1o3Y1BIeHJKenlE?=
 =?utf-8?B?YjJXdlhQTE42TTA0SE9SQVRXMi8vV0ZMQlpVRWNuRWtQeVRaanV3ZFVPZHJI?=
 =?utf-8?B?Y3pjK0I3VmJQNVZScThSblpISjc1cDBHVys5ckVSRjdZT0ZVUlhSRFB3YW42?=
 =?utf-8?B?Q0U4MXlzb3VjbFYwVjA4L1RFd0pPOHhJWmJOYVdPbkdiOEpvUHZub1NHSmNk?=
 =?utf-8?B?R01nUGRqOTZhNkYvcXRyRU4rTkdSTXA5QmpMYkc2YTlBZW1wc1pMNGM0dFJZ?=
 =?utf-8?B?dU5takM0WkpDa0h6aFBzVXpCZ0IzK0pubVhwWmZnM050NnVNeWZLTm5jay9u?=
 =?utf-8?Q?PAkM=3D?=
X-OriginatorOrg: axis.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 22660e73-a293-4a94-1677-08dc807ecf3d
X-MS-Exchange-CrossTenant-AuthSource: DB9PR02MB9994.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 08:02:11.3265
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3kD7G5FrFHlhSNuU4g8bq6+Omrrd9+uMMWoEFZw027sdKMyRBlIUxm2lEVwzadLf
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR02MB9715

On 5/29/24 16:11, Guenter Roeck wrote:
> On 5/29/24 02:47, Amna Waseem wrote:
>> The INA230 has an Alert pin which is asserted when the alert
>> function selected in the Mask/Enable register exceeds the
>> value programmed into the Alert Limit register. Assertion is based
>> on the Alert Polarity Bit (APOL, bit 1 of the Mask/Enable register).
>> It is default set to value 0 i.e Normal (active-low open collector).
>> However, hardware can be designed in such a way that expects Alert pin
>> to become active high if a user-defined threshold in Alert limit
>> register has been exceeded. This patch adds a way to pass alert polarity
>> value to the driver via device tree.
>>
>> Signed-off-by: Amna Waseem <Amna.Waseem@axis.com>
>
> Please address my earlier comments, and in the future please wait a 
> few minutes
> before sending another version to give people time to provide feedback
> on the earlier version(s).
Ok.
>> ---
>>   drivers/hwmon/ina2xx.c | 27 +++++++++++++++++++++++++++
>>   1 file changed, 27 insertions(+)
>>
>> diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
>> index d8415d1f21fc..9afaabdc367d 100644
>> --- a/drivers/hwmon/ina2xx.c
>> +++ b/drivers/hwmon/ina2xx.c
>> @@ -73,6 +73,9 @@
>>   #define INA226_READ_AVG(reg)        (((reg) & INA226_AVG_RD_MASK) 
>> >> 9)
>>   #define INA226_SHIFT_AVG(val)        ((val) << 9)
>>   +#define INA226_ALERT_POLARITY_MASK        0x0002
>> +#define INA226_SHIFT_ALERT_POLARITY(val)    ((val) << 1)
>> +
>>   /* bit number of alert functions in Mask/Enable Register */
>>   #define INA226_SHUNT_OVER_VOLTAGE_BIT    15
>>   #define INA226_SHUNT_UNDER_VOLTAGE_BIT    14
>> @@ -178,6 +181,21 @@ static u16 ina226_interval_to_reg(int interval)
>>       return INA226_SHIFT_AVG(avg_bits);
>>   }
>>   +static int ina2xx_set_alert_polarity(struct ina2xx_data *data,
>> +                     unsigned long val)
>> +{
>> +    int ret;
>> +
>> +    if (val > INT_MAX || !(val == 0 || val == 1))
>> +        return -EINVAL;
>> +
>> +    ret = regmap_update_bits(data->regmap, INA226_MASK_ENABLE,
>> +                 INA226_ALERT_POLARITY_MASK,
>> +                 INA226_SHIFT_ALERT_POLARITY(val));
>> +
>> +    return ret;
>
> ret is an unnecessary variable.
>     return regmap_update_bits(...);
>
Agreed. Will do it in next patch
>
>> +}
>> +
>>   /*
>>    * Calibration register is set to the best value, which eliminates
>>    * truncation errors on calculating current register in hardware.
>> @@ -659,6 +677,15 @@ static int ina2xx_probe(struct i2c_client *client)
>>       if (ret)
>>           return dev_err_probe(dev, ret, "failed to enable vs 
>> regulator\n");
>>   +    if (!of_property_read_u32(dev->of_node, "ti,alert-polarity", 
>> &val)) {
>> +        ret = ina2xx_set_alert_polarity(data, val);
>> +        if (ret < 0) {
>> +            return dev_err_probe(
>> +               dev, ret,
>> +               "failed to set APOL bit of Enable/Mask register\n");
>
> Line split is still as bad as before.
>
> Guenter
>
I have tried to apply clang-format and it still shows the line split as 
follows:

     if (!of_property_read_u32(dev->of_node, "ti,alert-polarity", &val)) {
         ret = ina2xx_set_alert_polarity(data, val);
         if (ret < 0) {
             return dev_err_probe(
                 dev, ret,
                 "failed to set APOL bit of Enable/Mask register\n");
         }
     }

What format will you suggest for line split? Is there any reference you 
can provide for splitting up the lines in Linux kernel drivers' code?

Amna