Received-SPF: pass (google.com: domain of linux-kernel+bounces-195036-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <8a41d875-8e6c-43da-90c7-0547648f214a@axis.com>
Date: Thu, 30 May 2024 10:02:40 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/2] dt-bindings: hwmon: ti,ina2xx: Add
 ti,alert-polarity property
To: Guenter Roeck <linux@roeck-us.net>, Conor Dooley <conor@kernel.org>
Cc: Jean Delvare <jdelvare@suse.com>, Rob Herring <robh@kernel.org>,
 Krzysztof Kozlowski <krzk+dt@kernel.org>, Conor Dooley
 <conor+dt@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>,
 linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, kernel@axis.com
References: <20240529-apol-ina2xx-fix-v2-0-ee2d76142de2@axis.com>
 <20240529-apol-ina2xx-fix-v2-1-ee2d76142de2@axis.com>
 <20240529-untangled-occultist-5c9804aa9c8f@spud>
 <f41480c8-f149-4826-aa28-549a504df181@roeck-us.net>
Content-Language: en-US
From: Amna Waseem <Amna.Waseem@axis.com>
In-Reply-To: <f41480c8-f149-4826-aa28-549a504df181@roeck-us.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bXd1QlBteC9VcWdUL3hTNzdPRmR6cG1QYXFUOXE0bzNjUHM2cEJJNmdBSlJV?=
 =?utf-8?B?Zy9LTmdyMm5ldHhwblpwckNZL09BbHoxSlhWajF1Wkl3dmhMQ0N2T1krSWlK?=
 =?utf-8?B?L3FtRTV2VkRyMjdhOGxTYlNOODVma1dESWZtdDgvODZXZHlhamV5b25HM3ZR?=
 =?utf-8?B?QWpxaUcvczVyc2pBUXo5OGpWVmRTRWUvaUZPanNhNDM1QmdpeGxrcmk4N0Jr?=
 =?utf-8?B?NjlJZ3FvdFFhMWVwMjB5QTN4SEhVbGZSNFZHclFHRW9tYmdvanBXMW1DWk9L?=
 =?utf-8?B?ZTZWVG8yajFIdHFKSDFsM28xRHIzVkl6YzZDcytkUmg1UCtVOUN5bUl0ZjhQ?=
 =?utf-8?B?eHVtRXNsV05sWWNSVGs4MWNsRE1oVWVYOVU3Z2htYlpaRlFEbVc3dUcyaU5Z?=
 =?utf-8?B?cW9FQ2JlTjg3Qzk5aEVCVzA0emFCdVIraGJpaytaTWh1aFVKa1lVQVhaOUpw?=
 =?utf-8?B?M3JhZkFXa1NMNXpjZ3prUUVKVS9pWHVQMVZkU2dNcHB5dEIwclZWbmpJNFpa?=
 =?utf-8?B?WTNRZGRSb3FFMkhyWWkvd1lFbnVmaEs3dWJTcThmdHIvTGVVbERRd1htMkR6?=
 =?utf-8?B?T3k2UUZBYTNOSDkwMkdValVwZ2NqL3V1NmI1VVBGVTRzOEpvUkRxY1J2OTIz?=
 =?utf-8?B?NlQ2QkFxWGRCQlFEMW1GeVVFaEpTd2Jub1B0NzRtQ2NrRlV5UHc5ZEVwMXNi?=
 =?utf-8?B?NHpmZlJURE00dTZJa1VWSFZodlU0Y3BDQXMrSXlRdWt4SWJ4ZVVha0Rxdyto?=
 =?utf-8?B?TllpdGJOTjBhTENSa2FYUDB2NG1tbm1EVnFLa3RxekM1N1owRWFwTXYwcTBE?=
 =?utf-8?B?OE1qbDNrTEU0YzRhbXdoQW9Ld3FSMjZHVGZCZkV6NjhEUS8welA5YVQ1SHhK?=
 =?utf-8?B?WFV1eVlyT3RNNjVSbjlQdEZjQzYzYUxlOUd0OFpuMjEyUXFCNVc4b2ZVemQy?=
 =?utf-8?B?V2l2QjVrS3A1KzA1K2tIUU96b01WbXNua2NBT3dsWUlUajdYalp5Si9BWEVu?=
 =?utf-8?B?M0tSbUQzejdsMjI3cGw5WUtOVy9hUHZGa0xaUytZWE9Fbng1ckhUYzA4bjFv?=
 =?utf-8?B?MmlUMmdQVUhlVE1tYzNTS2EzdkE5Z1RBWGpFVEtvQUVWY2pEcW8xM0FSVU9a?=
 =?utf-8?B?Z2s0eTJPZmVQVzFwNnV2a0VRdFRmb0FScGE2QUhvdXlleGUxdmI2c05jcC9R?=
 =?utf-8?B?Ylc5c1JwVis2OHhVMEJoMmxhZkdoK21BOU9zVGVpY0xsZGlnWjAvZHk3a1ho?=
 =?utf-8?B?Sk9Xazh4TmxtNXArMDVWSWNLbll0T1ZLbXN4M1k0eGxqY3oyRC9qaXA2bnhL?=
 =?utf-8?B?NmtDTk95bEdaUUM3NkM5TVU2VUdZRXlDNGo3dXQ1KzR3NmdNZ2N1VG1lN2Zs?=
 =?utf-8?B?eXc2blM4dDc3RlV2KzNDV09GMUdCaHh5Z3B3U01kNjIwSFd6V1dqMGN6cGUv?=
 =?utf-8?B?RWNXeTZMRWVGMTc2emdaeHhBa3pBUXQySmc4eWM4clJkT202ZWg4K2ZCM3pM?=
 =?utf-8?B?MG9UZDdwcnVWeWxudWcvNU1YNWROUXhEK0ZuampoYks4Si94UERaMWcyWnBV?=
 =?utf-8?B?czVNQm1zcjZrTXdsTnowK0hHd2FNRS8yTUduc0cwNTBVcExhOUdWNUswaW14?=
 =?utf-8?B?enFCREtORjNMVHZPY1puanFqNGg0RjFkTTNTbFllWXAyMjE4RXhDK3NzK3Nk?=
 =?utf-8?B?ZzJ2YmtWTHA1eE5HMkdyWGVvcmZjaml3Z09aZU1HcHF4L2Mxc1E2a2JRVU54?=
 =?utf-8?B?VWMySjJZa1BqYzV6MHdTZ3YrTjhtT1FDQytXTk4wRnZZYlF2M0NJM2diSWg4?=
 =?utf-8?B?bHh3RTEyTGQ5MTlnWDI2RkNrbFJhNnhsMHU0dGYxTk9ERFlLeE1MR3pkV08w?=
 =?utf-8?B?aHB1SXVNVHU1bXNyYzBSMGFFNjZnK2V6ZlhZSUFsb09ZQTdYZXNJWE9iQXFm?=
 =?utf-8?B?ZnNoemU2Mlh0cTcwKy9rZFF5UHlZMG16KzdtSmxmSzZJS29Lc2FIK0lqeDVX?=
 =?utf-8?B?aHp3UjFJNi9jbllYenRkT2hKZ0UvZEQ4QmpBQjE0N3JuNThQSENzUmZxY0sx?=
 =?utf-8?B?VWtZcDY4b0E2T3NoL3YvQzdFRlFHZDdGSVRXc3dGcW85cDBSL3M3K1VlUWdC?=
 =?utf-8?Q?522o=3D?=
X-OriginatorOrg: axis.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 025755b3-0252-44fb-5a9b-08dc807ee1ac
X-MS-Exchange-CrossTenant-AuthSource: DB9PR02MB9994.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 08:02:42.1011
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Rbu3OOFU75MCEAxw+mG38WO08I2AY2r4AAYmkmb3rZl+7tddVWXVnzntqLG2yTy7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR02MB9715

On 5/29/24 18:20, Guenter Roeck wrote:
> On 5/29/24 09:17, Conor Dooley wrote:
>> On Wed, May 29, 2024 at 11:47:44AM +0200, Amna Waseem wrote:
>>> Add a property to the binding to configure the Alert Polarity.
>>> Alert pin is asserted based on the value of Alert Polarity bit of
>>> Mask/Enable register. It is by default 0 which means Alert pin is
>>> configured to be active low open collector. Value of 1 maps to
>>> Inverted (active high open collector).
>>>
>>> Signed-off-by: Amna Waseem <Amna.Waseem@axis.com>
>>> ---
>>>   Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 9 +++++++++
>>>   1 file changed, 9 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml 
>>> b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>> index df86c2c92037..5a16d2d94587 100644
>>> --- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
>>> @@ -66,6 +66,14 @@ properties:
>>>       description: phandle to the regulator that provides the VS 
>>> supply typically
>>>         in range from 2.7 V to 5.5 V.
>>>   +  ti,alert-polarity:
>>> +    description: Alert polarity bit value of Mask/Enable register. 
>>> Alert pin is
>>> +      asserted based on the value of Alert polarity Bit. Default 
>>> value is Normal
>>> +      (0 which maps to active-low open collector). The other value 
>>> is Inverted
>>> +      (1 which maps to active-high open collector).
>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>> +    enum: [0, 1]
>>
>> There's no need for this to have a value, it's sufficient to be a flag
>> of "ti,alert-active-high". Present would mean active-high and absent
>> active-low. This has the added benefit the devicetree node being
>> understandable to a reader.
>>
>
> Agreed, makes sense. Even better, at the same time simplifies the code.
>
> Guenter
>
>
Agreed. Will do it in next patch

Amna