Received-SPF: pass (google.com: domain of linux-kernel+bounces-195037-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <08921791-452a-4bb1-950c-2dd7747a1d14@axis.com>
Date: Thu, 30 May 2024 10:06:46 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] hwmon: (ina2xx) Add device tree support to pass alert
 polarity
To: Guenter Roeck <linux@roeck-us.net>, Jean Delvare <jdelvare@suse.com>,
 Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzk+dt@kernel.org>,
 Conor Dooley <conor+dt@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>, linux-hwmon@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@axis.com
References: <20240529-apol-ina2xx-fix-v1-0-77b4b382190f@axis.com>
 <20240529-apol-ina2xx-fix-v1-2-77b4b382190f@axis.com>
 <6f2d2e7e-99b4-4f5d-a2c5-523b5534917b@roeck-us.net>
Content-Language: en-US
From: Amna Waseem <Amna.Waseem@axis.com>
In-Reply-To: <6f2d2e7e-99b4-4f5d-a2c5-523b5534917b@roeck-us.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Z1YzOGFwTk5hdGhTTktJSVN2YWRqNVkvUlVJMFlVME5ma2dkYVh0dTlpdnJ4?=
 =?utf-8?B?ZklVWWh0TVRlcUFiVzZtNXpHYlR5WjUxT2w5UjZjRnJjd1ZyUnBVeWNBK0l2?=
 =?utf-8?B?dEx0UG4wUHU5NHhYOXl1SnFKR085cW5xWVMvZzFHRkMxN1ZhQWJPT0VPeWRm?=
 =?utf-8?B?Z3hzWW90SUJFVk1GbzJGMXloZ3Y4SllxTjE1WngxMDBUYktCUjdGODVsaG50?=
 =?utf-8?B?ZHBkM2xHWEtva1BOTTQ5d1J0cXgxaVIzQU8zNGdIU1ZUekVtaW5hd1d0YnlJ?=
 =?utf-8?B?ZUI4cFJVeDJzd0lkZG5DbklQTVZHYzVXb3JjZ0czWkRKTlVLTDNjcVBHOUxZ?=
 =?utf-8?B?MXZNZnRRWE1LNkxJTnZSQlFKL1p6a2g2Wnh5bzVzdThqNUVWZkZRcE1aZTcz?=
 =?utf-8?B?RmlJdzRuTTFqSm5rMWg1Ym9kekZiTm9LaW03WE5wOUpQU3NzWkZvdUp5TUw3?=
 =?utf-8?B?TnlUbDBjMG9zN2ZJampvTEhSenF1bzNQWU1YSkhpTkhWdUdVMjZXMVdDNUZ3?=
 =?utf-8?B?NEQzOG9VM1Q3cjJmbWExcGJTVm5mZjNIT3NsZjZCQ0wxNUkxWEgrR1N3Znl2?=
 =?utf-8?B?UVkvRDlVZnQvc0xRd2xiM1BFbXQ4NkQrSWNwdWpETDk4bEoveS9ONEpJSERw?=
 =?utf-8?B?bnBCNEtJdDJmdmJXWURLNDIrNkRtR1dwamZaTnUrMmlNOUJ5ZHlUaVhvSEVD?=
 =?utf-8?B?Qm41bVZya0dBUlBVKzZFSzdpL2llbXd5QzNMd0ttZCtMMzhqZWVRbkYrcXZw?=
 =?utf-8?B?OVgyWlAzbzA1OWwvQnhaSGlXNjZVLytWLzQzQnIyeUFaUFVFV3pxRlNnYXZl?=
 =?utf-8?B?cGJzOWlqT0tRNWR5Ukh5ZDlETHlxY1piby9IZnhzZGZtdW5qcWR3WXUrdHRI?=
 =?utf-8?B?UUpMT1ZLbjBUTWpCZlVyL2FjREtYcGxHZXBaSTZCaVcxY2JXQkNUYXgvRUdz?=
 =?utf-8?B?WnhsQUkwYVgvTmEwcWUyWldsSmkwS0RIcm9EeUVQd0wzc1ZXS0YrTFpsSVk2?=
 =?utf-8?B?dFZDc0xFQUxDZHorUmlOaDVuMjJ2U0hXenJ1RkFzUng4UUsxcFg0bE4yV0Qz?=
 =?utf-8?B?Ti9vYmkySW5qNTlnTksyS2xma1ZCKzRBaXdSZC82NHVvdlY4bW5CVVFYWmRv?=
 =?utf-8?B?YzBrVzBjWkpzRXFVVE9NSDBEbTZ5QlNicUcvVHIxQ2E2TnJucTJiNXgrN2Nk?=
 =?utf-8?B?Lys5UFRhOFM2SW5ZQjVWeG1sUUduNnBaRXY2UnFjbUZQT3RYeEVGMUdPUkli?=
 =?utf-8?B?RUVvcXhSTWI0TDJsOW03c2xuQlBlNWhyWWhnQkNCeGt6UGMzbWlEc2pVcTB2?=
 =?utf-8?B?VUs4anN4VDUwS2k5cDA2Z2FIcU9OQWxLdXYwOUpnUTI0QmRhMTdEVmVZaFlQ?=
 =?utf-8?B?U2tLdk5TNkV1bHdDUnFZYnAzU1JZY0tGcHFpVnhtRTA3ZzE2QkZTNmp1ZHgr?=
 =?utf-8?B?TFdMMlY5YnBhTzVsL3hKaTVWcEFMOXhCM0ZhRVJvMXFNY3Y0Tk15RDZmUEti?=
 =?utf-8?B?M3BoS0NpS2dRQnZBcHRkQ05lVVVLUFczV1BHUHJtaVM5bjZIenBGa2JnZEdP?=
 =?utf-8?B?eEZhbThLaStaTWp6M3BmU2ZuQS81endyNHBCbXk1NEFGYXJUOWlvSzNqc1V2?=
 =?utf-8?B?VGw3VmZhdm5OcWJxR2lMbFJaRjcxb2JJcjZ5bjI2VkhzRis0N1dQd2E1a0FO?=
 =?utf-8?B?SWN4MUNNNFYzKzBHcnVHVkUwQXdGUkxseC9teU1BWGlERGM1d285cFhZOVBF?=
 =?utf-8?B?M1FnUWdHNHdWRG8xbTI1dkpoZWl1bkhWVUkwM3o3MktTYk1RL1JNVXZrNjdw?=
 =?utf-8?B?R0ZPeStsbDJabzhob0xlNHo5VlN3UXlQdnZSeDFLeUFOVFRTejVWdUczRkxv?=
 =?utf-8?B?bUdlckVCVmlpS2U0SFJzWmRpaG1sZVhrSENpNHEySlVXVU1IQkRoSGJra0ZI?=
 =?utf-8?B?QWpDZnVPS0VEbXRIOERyUmZ0VjIyWUdKVFBrZWZhSTl5VW9Fa1IyZmwzMDdO?=
 =?utf-8?B?bTlJTDlrMFRaUHZCT1RET3REYnRsUVdMVVpYRkttbCtYVklhTmc1bjJKelFB?=
 =?utf-8?B?SzZxQjFZNFhBL1R5dmZZVDRwekZPa1pCT0d0RWRZSFBKMmwweTFKd0dTMm5M?=
 =?utf-8?Q?uZHE=3D?=
X-OriginatorOrg: axis.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 124aad85-7b0e-46f5-5b77-08dc807f7472
X-MS-Exchange-CrossTenant-AuthSource: DB9PR02MB9994.eurprd02.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 08:06:48.3676
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JCJa9HmCb/pzu+wPL4Q/TSV8PhBQfzI5TNQKnnn94aK3+4VyyQF4QpuK1TmniNwe
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR02MB8804

On 5/29/24 16:07, Guenter Roeck wrote:
> On 5/28/24 23:07, Amna Waseem wrote:
>> The INA230 has an Alert pin which is asserted when the alert
>> function selected in the Mask/Enable register exceeds the
>> value programmed into the Alert Limit register. Assertion is based
>> on the Alert Polarity Bit (APOL, bit 1 of the Mask/Enable register).
>> It is default set to value 0 i.e Normal (active-low open collector).
>> However, hardware can be designed in such a way that expects Alert pin
>> to become active high if a user-defined threshold in Alert limit
>> register has been exceeded. This patch adds a way to pass alert polarity
>> value to the driver via device tree.
>>
>> Signed-off-by: Amna Waseem <Amna.Waseem@axis.com>
>> ---
>>   drivers/hwmon/ina2xx.c | 28 ++++++++++++++++++++++++++++
>>   1 file changed, 28 insertions(+)
>>
>> diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
>> index d8415d1f21fc..b58e795bdc8f 100644
>> --- a/drivers/hwmon/ina2xx.c
>> +++ b/drivers/hwmon/ina2xx.c
>> @@ -73,6 +73,9 @@
>>   #define INA226_READ_AVG(reg)        (((reg) & INA226_AVG_RD_MASK) 
>> >> 9)
>>   #define INA226_SHIFT_AVG(val)        ((val) << 9)
>>   +#define INA226_ALERT_POLARITY_MASK        0x0002
>> +#define INA226_SHIFT_ALERT_POLARITY(val)    ((val) << 1)
>> +
>>   /* bit number of alert functions in Mask/Enable Register */
>>   #define INA226_SHUNT_OVER_VOLTAGE_BIT    15
>>   #define INA226_SHUNT_UNDER_VOLTAGE_BIT    14
>> @@ -178,6 +181,23 @@ static u16 ina226_interval_to_reg(int interval)
>>       return INA226_SHIFT_AVG(avg_bits);
>>   }
>>   +static int ina2xx_set_alert_polarity(struct ina2xx_data *data,
>> +                     unsigned long val)
>> +{
>> +    int ret;
>> +
>> +    if (val > INT_MAX || !(val == 0 || val == 1))
>
>     if (val != 0 && val !=1)
>
> would be sufficient and much easier to understand.


Agreed.

>
>> +        return -EINVAL;
>> +
>> +    mutex_lock(&data->config_lock);
>
> Pointless lock.
>
>> +    ret = regmap_update_bits(data->regmap, INA226_MASK_ENABLE,
>> +                 INA226_ALERT_POLARITY_MASK,
>> +                 INA226_SHIFT_ALERT_POLARITY(val));
>> +
>> +    mutex_unlock(&data->config_lock);
>> +    return ret;
>> +}
>> +
>>   /*
>>    * Calibration register is set to the best value, which eliminates
>>    * truncation errors on calculating current register in hardware.
>> @@ -659,6 +679,14 @@ static int ina2xx_probe(struct i2c_client *client)
>>       if (ret)
>>           return dev_err_probe(dev, ret, "failed to enable vs 
>> regulator\n");
>>   +    if (!of_property_read_u32(dev->of_node, "alert-polarity", 
>> &val)) {
>> +        ret = ina2xx_set_alert_polarity(data, val);
>> +        if (ret < 0)
>> +            return dev_err_probe(
>> +                dev, ret,
>> +                "failed to set APOL bit of Enable/Mask register\n");
>> +    }
>
> INA219 and INA220 do not support alert pin configuration (or, naturally,
> the mask register in the first place). This will need to be validated.
>
> Guenter
>
Would "of_property_read_bool" be sufficient to check whether the 
property exists or not for different chips? It means that if INA219 and 
INA220 are being used, they will not have a property "alert-polarity" 
defined in their devicetree so of_property_read_bool will return false 
and nothing will happen for these chips.